This is a list of all comments for HD-DEN-15272-1.

Review Summary: No summary


----------------------------------------
File: Accel.c
Revision Comment by Sean Nash on 22 June 2023, 08:29 
https://devapps.diality.us/cru/HD-DEN-15272-1#c17964

  Why is the L lower case?

  Reply by Darren Cox on 22 June 2023, 10:28
  > Fixed.

    Reply by Sean Nash on 22 June 2023, 11:33
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 22 June 2023, 08:36 
https://devapps.diality.us/cru/HD-DEN-15272-1#c17967

  Remove comment.  Maybe move part about bumping to brief above.

  Reply by Darren Cox on 22 June 2023, 10:29
  > Moved to function header.

    Reply by Sean Nash on 22 June 2023, 11:33
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 22 June 2023, 08:35 
https://devapps.diality.us/cru/HD-DEN-15272-1#c17966

  Prefer not to have local statics.  Move to top of file.

  Reply by Darren Cox on 22 June 2023, 10:29
  > Moved declarations to top of file.

    Reply by Sean Nash on 22 June 2023, 11:33
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 22 June 2023, 08:32 
https://devapps.diality.us/cru/HD-DEN-15272-1#c17965

  Why are we passing test here?  I think if you pass here, you
  will not return and retry.  Should leave result as in progress
  to keep the test going.

  Reply by Darren Cox on 22 June 2023, 10:37
  > Value is overridden below if the test is repeated.  If it is
  > the last time through test, it needs to be set here as
  > Pass/Fail based on Fail counter.

    Reply by Sean Nash on 22 June 2023, 11:43
    > I think I understand how this works now.  Kind of confusing
    > how this is done and strange to see passed set here when it
    > just failed.  
    > If I understand correctly, test must fail 3 out of the 5
    > tests to fail the whole test - otherwise it passes?

      Reply by Darren Cox on 22 June 2023, 12:15
      > I simplified it. Now if fails, test ends.  If passed ( <
      > 3 errors), PASS result is set on exit with Complete
      > state.

        Reply by Sean Nash on 23 June 2023, 10:38
        > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 22 June 2023, 08:38 
https://devapps.diality.us/cru/HD-DEN-15272-1#c17968

  state is already in progress - no need to reassign it here.
  result is already in progress as well.

  Reply by Darren Cox on 22 June 2023, 10:30
  > Removed.

    Reply by Sean Nash on 22 June 2023, 11:46
    > RESOLVED in CODE WALKTHROUGH.


---

ID: HD-DEN-15272-1 https://devapps.diality.us/cru/HD-DEN-15272-1

Title: HD-DEN-15272_FW Alarm 9 DG Fault Acc Vector Triggers ON Startup
Statement of Objectives:


State: Closed

Summary: 

Author: Darren Cox
Moderator: Darren Cox
Reviewers: (4 active, 2 completed*)
     Sean Nash   (*)
     wbracken   (*)
     Michael Garthwaite
     Dara Navaei
     jtaylor
     Steve Jarpe