This is a list of all comments for HD-DEN-15330-1.

Review Summary: No summary


----------------------------------------
File: firmware/App/Modes/TreatmentStop.c
Revision Comment by Sean Nash on 15 June 2023, 10:09 
https://devapps.diality.us/cru/HD-DEN-15330-1#c17913

  Don't need this include.

  Reply by Michael Garthwaite on 15 June 2023, 10:17
  > Fixed. Thanks!

    Reply by Sean Nash on 15 June 2023, 16:28
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 14 June 2023, 17:10 
https://devapps.diality.us/cru/HD-DEN-15330-1#c17898

  If you search for where execReservoirs() is called, you will
  see that it's already called by ModeTreatment.c right before
  this function is called.

  Reply by Michael Garthwaite on 15 June 2023, 09:45
  > Fixed. Thanks!

    Reply by Sean Nash on 15 June 2023, 10:10
    > RESOLVED in CODE WALKTHROUGH.

----------------------------------------
File: firmware/App/Services/Reservoirs.c
Revision Comment by Sean Nash on 14 June 2023, 17:13 
https://devapps.diality.us/cru/HD-DEN-15330-1#c17899

  Add space between if and (.

  Reply by Michael Garthwaite on 15 June 2023, 09:44
  > Fixed. Thanks!

    Reply by Sean Nash on 15 June 2023, 10:13
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 14 June 2023, 17:14 
https://devapps.diality.us/cru/HD-DEN-15330-1#c17900

  Why is this a separate condition when it's doing the exact same
  thing as above?

  Reply by Michael Garthwaite on 15 June 2023, 09:46
  > With this being a WIP im unsure at the moment if both
  > conditions need to do the same thing.

    Reply by Sean Nash on 15 June 2023, 10:11
    > Looks like they do need to do the same thing.  We should
    > combine with condition above.

      Reply by Michael Garthwaite on 15 June 2023, 17:13
      > Combined. Thanks!

        Reply by Sean Nash on 16 June 2023, 11:05
        > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Dara Navaei on 14 June 2023, 18:23 
https://devapps.diality.us/cru/HD-DEN-15330-1#c17904

  Please remove the extra blank line.

  Reply by Michael Garthwaite on 15 June 2023, 09:44
  > Fixed. Thanks!

    Reply by Dara Navaei on 16 June 2023, 10:35
    > RESOLVED in CODE WLAKTHROUGH

Revision Comment by Sean Nash on 15 June 2023, 10:16 
https://devapps.diality.us/cru/HD-DEN-15330-1#c17919

  Align the TRUEs.

  Reply by Michael Garthwaite on 15 June 2023, 10:19
  > Fixed. Thanks!

    Reply by Sean Nash on 15 June 2023, 16:28
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 14 June 2023, 17:15 
https://devapps.diality.us/cru/HD-DEN-15330-1#c17901

  I think we should be checking alarm condition instead of alarm
  active.  Temperature may have come back into range (condition
  cleared) but user hasn't resumed to clear alarm (maybe stepped
  away for a minute).

  Reply by Michael Garthwaite on 15 June 2023, 09:45
  > Fixed. Thanks!

    Reply by Sean Nash on 15 June 2023, 10:14
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 14 June 2023, 17:16 
https://devapps.diality.us/cru/HD-DEN-15330-1#c17902

  Add blank line after function scope.

  Reply by Michael Garthwaite on 15 June 2023, 09:45
  > Fixed. Thanks!

    Reply by Sean Nash on 15 June 2023, 10:12
    > RESOLVED in CODE WALKTHROUGH.


---

ID: HD-DEN-15330-1 https://devapps.diality.us/cru/HD-DEN-15330-1

Title: HD-DEN-15330_Dialysate Temp Alarm Recovery Takes A Long Time NO Reservoir Switching
Statement of Objectives:


State: Closed

Summary: 

Author: Michael Garthwaite
Moderator: Michael Garthwaite
Reviewers: (4 active, 2 completed*)
     Sean Nash   (*)
     wbracken   (*)
     Dara Navaei
     Darren Cox
     jtaylor
     Steve Jarpe