This is a list of all comments for HD-DEN-15359-1.

Review Summary: No summary


----------------------------------------
File: firmware/App/Controllers/PresOccl.c
Revision Comment by Behrouz NematiPour on 30 May 2023, 00:46 
https://devapps.diality.us/cru/HD-DEN-15359-1#c17669

  Seems the only message which is providing the calculated A/V
  min/max is here in message 0x09.
  I think it was better to keep the min, max of the arterial and
  venous in the message 0x47 (A/V InTx adj) to let UI immediately
  have the updated values, 
  instead of the x09 which is a broadcast and won't immediately
  send the updated/calculated min/max, and causes a short delay
  (depending on interval of the broadcast) to update the UI.
  Or in both if the message 0x09 is getting continuously updated
  during treatment.

  Reply by Sean Nash on 30 May 2023, 08:17
  > Can't keep in message x47 as f/w will not have calculated new
  > min/max yet.  
  > I made it so message x9 will broadcast immediately after user
  > changes pressure limit windows.

    Reply by Behrouz NematiPour on 30 May 2023, 18:32
    > Thanks, that works too.
    > RESOLVED IN CODE WALKTHROUGH

Revision Comment by wbracken on 30 May 2023, 15:18 
https://devapps.diality.us/cru/HD-DEN-15359-1#c17677

  Add stabilizationStartTimeMs to header.

  Reply by Sean Nash on 31 May 2023, 08:20
  > Done.

    Reply by wbracken on 31 May 2023, 19:46
    > RESOLVED IN CODE WALKTHROUGH

Revision Comment by wbracken on 25 May 2023, 11:44 
https://devapps.diality.us/cru/HD-DEN-15359-1#c17648

  Could these recently added variables be defined as F32 instead
  of casting?

  Reply by Sean Nash on 26 May 2023, 13:45
  > Will always be integers.  Prefer to store them that way.

    Reply by wbracken on 27 May 2023, 23:49
    > RESOLVED IN CODE WALKTHROUGH

Revision Comment by wbracken on 27 May 2023, 23:50 
https://devapps.diality.us/cru/HD-DEN-15359-1#c17653

  Add pressureLimitsActive to header.

  Reply by Sean Nash on 29 May 2023, 22:34
  > Fixed.

    Reply by wbracken on 30 May 2023, 11:29
    > RESOLVED IN CODE WALKTHROUGH

Revision Comment by wbracken on 27 May 2023, 23:52 
https://devapps.diality.us/cru/HD-DEN-15359-1#c17654

  Add pressureLimitsActive to header.

  Reply by Sean Nash on 29 May 2023, 22:34
  > Fixed.

    Reply by wbracken on 30 May 2023, 11:29
    > RESOLVED IN CODE WALKTHROUGH

----------------------------------------
File: firmware/App/Modes/ModeTreatmentParams.c
Revision Comment by Behrouz NematiPour on 29 May 2023, 17:41 
https://devapps.diality.us/cru/HD-DEN-15359-1#c17657

  don't you need to add the venous asymmetric here to be reset?
  Since I am going to give user an option to adjust it during
  treatment.

  Reply by Sean Nash on 29 May 2023, 22:36
  > Yes.  Fixed.

    Reply by Behrouz NematiPour on 30 May 2023, 00:41
    > RESOLVED IN CODE WALKTHROUGH.

Revision Comment by Behrouz NematiPour on 29 May 2023, 20:05 
https://devapps.diality.us/cru/HD-DEN-15359-1#c17659

  same here?

  Reply by Sean Nash on 29 May 2023, 22:38
  > Fixed.

    Reply by Behrouz NematiPour on 30 May 2023, 00:42
    > RESOLVED IN CODE WALKTHROUGH.

Revision Comment by Behrouz NematiPour on 29 May 2023, 20:01 
https://devapps.diality.us/cru/HD-DEN-15359-1#c17658

  Isn't the Venous Asymmetric missing?

  Reply by Sean Nash on 29 May 2023, 22:38
  > Yes.  Fixed.

    Reply by Behrouz NematiPour on 30 May 2023, 00:42
    > RESOLVED IN CODE WALKTHROUGH.


---

ID: HD-DEN-15359-1 https://devapps.diality.us/cru/HD-DEN-15359-1

Title: HD-DEN-15359_Usability Arterial And Venous Pressure Alarm Limits
Statement of Objectives:


State: Closed

Summary: 

Author: Sean Nash
Moderator: Sean Nash
Reviewers: (6 active, 1 completed*)
     Dara Navaei   (*)
     Michael Garthwaite
     wbracken
     Behrouz NematiPour
     Darren Cox
     jtaylor
     Steve Jarpe