This is a list of all comments for HD-DEN-15741-2. Review Summary: No summary ---------------------------------------- File: firmware/App/Controllers/BloodFlow.c Revision Comment by wbracken on 01 August 2023, 15:55 https://devapps.diality.us/cru/HD-DEN-15741-2#c18350 Update header. Reply by jtaylor on 02 August 2023, 11:32 > Change postponed for further testing. No change in > BloodPumps. > Done. Reply by wbracken on 03 August 2023, 16:36 > RESOLVED IN CODE WALKTHROUGH Revision Comment by Sean Nash on 01 August 2023, 12:29 https://devapps.diality.us/cru/HD-DEN-15741-2#c18343 Why was all of this necessary? Reply by jtaylor on 01 August 2023, 13:00 > Change postponed for further testing. No change in > BloodPumps. Reply by Sean Nash on 03 August 2023, 09:47 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Controllers/DialInFlow.c Revision Comment by wbracken on 01 August 2023, 15:52 https://devapps.diality.us/cru/HD-DEN-15741-2#c18349 Update header Reply by jtaylor on 02 August 2023, 11:31 > Change postponed for further testing. No change in DialIn. > Done. Reply by wbracken on 03 August 2023, 16:35 > RESOLVED IN CODE WALKTHROUGH ---------------------------------------- File: firmware/App/Controllers/DialOutFlow.c Revision Comment by wbracken on 01 August 2023, 15:51 https://devapps.diality.us/cru/HD-DEN-15741-2#c18348 Update header Reply by jtaylor on 02 August 2023, 11:31 > Change postponed for further testing. No change in DialOut. > DONE. Reply by wbracken on 03 August 2023, 16:34 > RESOLVED IN CODE WALKTHROUGH ---------------------------------------- File: firmware/App/Modes/TreatmentRecirc.c Revision Comment by Sean Nash on 01 August 2023, 12:18 https://devapps.diality.us/cru/HD-DEN-15741-2#c18342 Comment is copy. What is this flag for? Is it user requested? Reply by jtaylor on 01 August 2023, 13:28 > Approach simplified. Reply by Sean Nash on 03 August 2023, 09:48 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 03 August 2023, 15:28 https://devapps.diality.us/cru/HD-DEN-15741-2#c18428 Blank line before banner comment. Reply by jtaylor on 04 August 2023, 11:00 > Done. Reply by Sean Nash on 04 August 2023, 12:55 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 03 August 2023, 09:28 https://devapps.diality.us/cru/HD-DEN-15741-2#c18396 Why are we talking about rinseback here? This is recirc sub-mode of treatment mode - not rinseback. Reply by jtaylor on 03 August 2023, 12:55 > s/b recirculate. Done. Reply by Sean Nash on 03 August 2023, 15:24 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 03 August 2023, 09:30 https://devapps.diality.us/cru/HD-DEN-15741-2#c18397 Everything in this function except DPi and trimmer heater stops should already be set in transition to recirc function. Most of this is redundant. Reply by jtaylor on 03 August 2023, 12:56 > BP is turned on in the resume from stop, and patient > reconnect states, .100ml/min. Removed anything that is off, > and stays off in recirculation. > Done. Reply by Sean Nash on 03 August 2023, 15:20 > Still more here than should be. Trimmer heater is being > turned off twice now. DPo should already be stopped. And > VBA/VBV should be handled by state machine I would think > unless user stop requirement talks about valves too - and > even if so, valves should only close when user stop alarm > is active - nothing to do with recirc properties in alarms. Reply by jtaylor on 04 August 2023, 09:51 > Done. Reply by Sean Nash on 04 August 2023, 12:57 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 03 August 2023, 09:35 https://devapps.diality.us/cru/HD-DEN-15741-2#c18398 Why does this function return/set state? It is not a state handler function. Reply by jtaylor on 03 August 2023, 13:09 > Done. Reply by Sean Nash on 03 August 2023, 15:19 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 01 August 2023, 12:31 https://devapps.diality.us/cru/HD-DEN-15741-2#c18344 I reviewed DEN-15741 which is re: desire to stop DPi if user stopped with button. Everything I see changed in this module seems like a very complicated way to achieve that using properties that I don't think were intended for this. I think all we needed to do was check if user stop alarm is active and, in that special case, stop DPi instead of recirculating dialysate like it usually does in the recirc stop state. Reply by jtaylor on 01 August 2023, 13:10 > Change simplified in TreatmentRecirc.c > Pump control changes reverted. Christina's earlier testing > confirmed these worked, similar to the findings in the > DEN-16016 resolution. Reply by Sean Nash on 03 August 2023, 09:48 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 04 August 2023, 12:58 https://devapps.diality.us/cru/HD-DEN-15741-2#c18455 Should blood recirc blocked be based on alarm properties (as you've written here) or based on whether user stopped (specifically)? My feeling is that since there is no blood in blood side of circuit (because rinseback was completed before we got to recirc), the NoBloodRecirc alarm property maybe doesn't apply here and we should only stop BP if the user stop alarm is active. Reply by jtaylor on 04 August 2023, 13:10 > Wouldn't we want to stop if an alarm occurred during > recirculation, which affected the blood circuit? My > inclination would be to manage which alarms were enabled in > this state rather than not implement the mechanism to stop > the pumps. > > Implementing the change. > Done. Reply by Sean Nash on 04 August 2023, 15:40 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 04 August 2023, 12:49 https://devapps.diality.us/cru/HD-DEN-15741-2#c18448 We already know dialysateRecircBlocked != TRUE here - should this just be a simple "else"? Reply by jtaylor on 04 August 2023, 12:50 > Done. Reply by Sean Nash on 04 August 2023, 12:57 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 03 August 2023, 16:22 https://devapps.diality.us/cru/HD-DEN-15741-2#c18429 I don't think you need to repeat @details Inputs: and @details Outputs:. Only need those for first row. See other functions for example. Reply by jtaylor on 04 August 2023, 09:59 > Done. Reply by Sean Nash on 04 August 2023, 12:55 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 03 August 2023, 11:16 https://devapps.diality.us/cru/HD-DEN-15741-2#c18409 Add inputs. Reply by jtaylor on 03 August 2023, 12:53 > Done Reply by Sean Nash on 03 August 2023, 15:15 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 03 August 2023, 09:40 https://devapps.diality.us/cru/HD-DEN-15741-2#c18401 Call these blocked functions once and save values to local vars. Use local vars throughout function so you don't have to keep calling the functions. Also, why are we looking at blood recirc at all? BP is never on in recirc states so no need to manage blocking blood recirculation. Reply by jtaylor on 03 August 2023, 12:06 > In treatment recirc, BP is turned on in the resume from stop, > and patient reconnect states, .100ml/min. It seems as though > the user stop should turn off both pumps. Reply by Sean Nash on 03 August 2023, 12:48 > Agree that BP is on in the recirc state. Forget 2nd > comment - focus on multiple function calls comment. Reply by jtaylor on 03 August 2023, 13:06 > Done. Reply by Sean Nash on 03 August 2023, 15:16 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 03 August 2023, 16:25 https://devapps.diality.us/cru/HD-DEN-15741-2#c18430 So this is only going to stop pumps/heater if both block recircs are active. I don't think that's what you want. My understanding of what you're trying to do here is this: 1) if dialysate recirc is blocked by an active alarm (includes user stop alarm), we should stop DPi and HR. Otherwise, we should run DPi and HR. 2) if user stop alarm is active or we are in any state other than recirc state, we should stop BP. Otherwise, we should run BP to recirculate blood side of circuit. Reply by jtaylor on 04 August 2023, 10:46 > Done. Reply by Sean Nash on 04 August 2023, 12:55 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 03 August 2023, 09:42 https://devapps.diality.us/cru/HD-DEN-15741-2#c18403 Should not go to stopped state - let state machine manage state transitions. Just stop DPi and trimmer heater. Reply by jtaylor on 03 August 2023, 12:50 > Done. Reply by Sean Nash on 03 August 2023, 15:17 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 03 August 2023, 16:37 https://devapps.diality.us/cru/HD-DEN-15741-2#c18434 Resume requested flag gets set elsewhere (from user clearing alarm -> CAN -> AlarmMgmt -> Modes -> this module) and should not be set here. Reply by jtaylor on 04 August 2023, 09:36 > The user stop alarm drops the recirc state machine into the > stopped state (stop alarm property is true). To full resume > requires that "OK" is pressed, then "Resume", to continue > with recirculation. Is that the behavior we want, or do we > want to continue with only the "OK" acknowledgment? Reply by Sean Nash on 04 August 2023, 10:02 > Keep resume behavior as it was unless Systems is telling > you current behavior is wrong. recircResumeRequested flag > gets set to TRUE somewhere else and I think that is the > only place where the flag should be set. I see no reason > why it should be set here. Reply by jtaylor on 04 August 2023, 10:35 > Done. Reply by Sean Nash on 04 August 2023, 12:47 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 03 August 2023, 09:37 https://devapps.diality.us/cru/HD-DEN-15741-2#c18399 Function header says no return value and I think that should be right. Remove return here. Reply by jtaylor on 03 August 2023, 12:57 > Done. Reply by Sean Nash on 03 August 2023, 15:17 > RESOLVED in CODE WALKTHROUGH. --- ID: HD-DEN-15741-2 https://devapps.diality.us/cru/HD-DEN-15741-2 Title: HD-DEN-15741_Dpi Does Not Stop When Recirculation IS Paused 2 Statement of Objectives: State: Closed Summary: Author: jtaylor Moderator: jtaylor Reviewers: (4 active, 2 completed*) Sean Nash (*) wbracken (*) Michael Garthwaite Dara Navaei Darren Cox Steve Jarpe