This is a list of all comments for HD-DEN-15980-1.

Review Summary: No summary


----------------------------------------
File: firmware/App/Controllers/AirTrap.c
Revision Comment by jtaylor on 22 August 2023, 08:49 
https://devapps.diality.us/cru/HD-DEN-15980-1#c18663

  Please check comment column alignment

  Reply by Darren Cox on 23 August 2023, 11:59
  > Fixed

    Reply by jtaylor on 23 August 2023, 15:55
    > RESOLVED in CODE WALKTHROUGH

Revision Comment by Sean Nash on 22 August 2023, 13:02 
https://devapps.diality.us/cru/HD-DEN-15980-1#c18683

  Maybe create a public #define USE_SHORT_STABILIZATION_PERIOD
  TRUE    somewhere in PresOccl.h to make these more readable.

  Reply by Darren Cox on 23 August 2023, 10:49
  > Done

    Reply by Sean Nash on 23 August 2023, 14:16
    > RESOLVED in CODE WALKTHROUGH.

----------------------------------------
File: firmware/App/Controllers/PresOccl.c
Revision Comment by Sean Nash on 24 August 2023, 11:19 
https://devapps.diality.us/cru/HD-DEN-15980-1#c18720

  Fix comment alignment.

  Reply by Darren Cox on 24 August 2023, 13:52
  > Fixed.

    Reply by Sean Nash on 25 August 2023, 09:01
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 22 August 2023, 12:53 
https://devapps.diality.us/cru/HD-DEN-15980-1#c18678

  This is a parameter, not an input - though there is a static
  variable that gets set by signal function, so not clear to me
  why you're not using that here instead of parameter.

  Reply by Darren Cox on 23 August 2023, 10:44
  > Updated header, removed parameter to use static var instead.
  > Good catch.

    Reply by Sean Nash on 23 August 2023, 14:17
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 23 August 2023, 14:17 
https://devapps.diality.us/cru/HD-DEN-15980-1#c18711

  useShortStablizeTime is an input, not output (and is
  mis-spelled).

  Reply by Darren Cox on 23 August 2023, 15:00
  > Updated spelling and as Input here.

    Reply by Sean Nash on 24 August 2023, 11:14
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 22 August 2023, 13:00 
https://devapps.diality.us/cru/HD-DEN-15980-1#c18681

  This is a parameter, not an input.

  Reply by Darren Cox on 23 August 2023, 10:42
  > Updated header.

    Reply by Sean Nash on 24 August 2023, 11:22
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 23 August 2023, 14:18 
https://devapps.diality.us/cru/HD-DEN-15980-1#c18712

  This is an odd description of useShort parameter.

  Reply by Darren Cox on 23 August 2023, 15:05
  > Updated to slightly less odd description.

    Reply by Sean Nash on 24 August 2023, 11:15
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 22 August 2023, 12:57 
https://devapps.diality.us/cru/HD-DEN-15980-1#c18679

  Why set to false here?  Seems like if statement in next state
  will always be false now.

  Reply by Darren Cox on 23 August 2023, 10:46
  > signalInitiatePressureStabilization() call and periodic
  > re-stabilize will go to PRESSURE_LIMITS_STATE_STABILIZATION.
  > When coming from this state (PRESSURE_LIMITS_STATE_WIDE),
  > stabilization should always be the Normal length, not the
  > Short length.

    Reply by Sean Nash on 23 August 2023, 14:20
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 22 August 2023, 12:57 
https://devapps.diality.us/cru/HD-DEN-15980-1#c18680

  Be explicit (i.e. TRUE == useShortStabilizeTime).

  Reply by Darren Cox on 23 August 2023, 10:48
  > Updated

    Reply by Sean Nash on 24 August 2023, 11:21
    > RESOLVED in CODE WALKTHROUGH.

----------------------------------------
File: firmware/App/Controllers/PresOccl.h
Revision Comment by Sean Nash on 22 August 2023, 13:01 
https://devapps.diality.us/cru/HD-DEN-15980-1#c18682

  Provide parameter name in prototype.

  Reply by Darren Cox on 23 August 2023, 10:49
  > Done

    Reply by Sean Nash on 23 August 2023, 14:22
    > RESOLVED in CODE WALKTHROUGH.


---

ID: HD-DEN-15980-1 https://devapps.diality.us/cru/HD-DEN-15980-1

Title: HD-DEN-15980_Pressure Alarm Windows Widened For Extended Period OF Time Due TO Frequency OF Air
Statement of Objectives:


State: Closed

Summary: 

Author: Darren Cox
Moderator: Darren Cox
Reviewers: (3 active, 3 completed*)
     Sean Nash   (*)
     wbracken   (*)
     jtaylor   (*)
     Michael Garthwaite
     Dara Navaei
     Steve Jarpe