This is a list of all comments for HD-DEN-16164-1.

Review Summary: No summary


----------------------------------------
File: firmware/App/Modes/SelfTests.c
Revision Comment by wbracken on 17 August 2023, 13:11 
https://devapps.diality.us/cru/HD-DEN-16164-1#c18620

  Add dryPressureTestsCompleted to header.

  Reply by Michael Garthwaite on 17 August 2023, 14:20
  > dryPressureTestsCompleted is already in this header.
  > dryPressureTestsCompleted was added to setupForSelfTestStop()
  > header.

    Reply by wbracken on 18 August 2023, 10:20
    > RESOLVED IN CODE WALKTHROUGH

Revision Comment by Sean Nash on 16 August 2023, 15:26 
https://devapps.diality.us/cru/HD-DEN-16164-1#c18608

  What if we got some other alarm during pressure test states?
  Would it be better to check dryPressureTestsCompleted?

  Reply by Michael Garthwaite on 17 August 2023, 12:56
  > Updated to handle any active alarm if we havent passed
  > pressure tests. I also modified the logic to where this valve
  > change should only happen in d.s.p.t.

    Reply by Sean Nash on 18 August 2023, 09:40
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 16 August 2023, 15:26 
https://devapps.diality.us/cru/HD-DEN-16164-1#c18607

  Put constant on other side of comparison operator.  We only put
  constant first when using "==".

  Reply by Michael Garthwaite on 17 August 2023, 12:55
  > Fixed. Thanks!

    Reply by Sean Nash on 17 August 2023, 13:44
    > RESOLVED in CODE WALKTHROUGH.


---

ID: HD-DEN-16164-1 https://devapps.diality.us/cru/HD-DEN-16164-1

Title: HD-DEN-16164_FW Pre Treatment Pressure Test Failures Vent TO Saline Bag
Statement of Objectives:


State: Closed

Summary: 

Author: Michael Garthwaite
Moderator: Michael Garthwaite
Reviewers: (3 active, 3 completed*)
     Sean Nash   (*)
     wbracken   (*)
     jtaylor   (*)
     Dara Navaei
     Darren Cox
     Steve Jarpe