This is a list of all comments for HD-DEN-16446-2.

Review Summary: No summary


----------------------------------------
File: firmware/App/Modes/ModeTreatment.c
Revision Comment by wbracken on 13 October 2023, 10:41 
https://devapps.diality.us/cru/HD-DEN-16446-2#c19029

  Check casting.  Result is U32 but could be assigned an S32.

  Reply by Dara Navaei on 19 October 2023, 14:23
  > The result will be an unsigned integer

    Reply by wbracken on 19 October 2023, 16:36
    > RESOLVED IN CODE WALKTHROUGH

Revision Comment by Sean Nash on 16 October 2023, 11:04 
https://devapps.diality.us/cru/HD-DEN-16446-2#c19033

  I think we need the minimum check too.  uFRate can be negative
  if user sets volume to something lower than what has already
  been collected (negative volume) which would yield a negative
  rate which is < 0.0.

  Reply by Vinayakam Mani on 19 October 2023, 13:33
  > In the If conditions, we check "uFVolume > colUFVol"
  > conditions, that makes uFRate always positive and hence the
  > condition for minimum check is not required.

    Reply by Sean Nash on 19 October 2023, 14:11
    > RESOLVED in CODE WALKTHROUGH.


---

ID: HD-DEN-16446-2 https://devapps.diality.us/cru/HD-DEN-16446-2

Title: HD-DEN-16446_HD Dev Test Clean UP Vectorcast
Statement of Objectives:


State: Closed

Summary: 

Author: Dara Navaei
Moderator: Dara Navaei
Reviewers: (5 active, 2 completed*)
     Sean Nash   (*)
     wbracken   (*)
     jpaguio
     Vinayakam Mani
     Michael Garthwaite
     dcox
     jtaylor