This is a list of all comments for HD-DEN-16512-1.

Review Summary: No summary


----------------------------------------
File: firmware/App/Controllers/DialOutFlow.c
Revision Comment by Sean Nash on 27 November 2023, 09:26 
https://devapps.diality.us/cru/HD-DEN-16512-1#c19264

  5% seems like a reasonable max step.  I don't think we want to
  go to ramp up/down states if > 5% change.  I think we just want
  to limit the change to max 5% for a single control interval.

  Reply by Vinayakam Mani on 27 November 2023, 13:34
  > Done.

    Reply by Sean Nash on 28 November 2023, 09:24
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 27 November 2023, 09:24 
https://devapps.diality.us/cru/HD-DEN-16512-1#c19262

  Add space after if.

  Reply by Vinayakam Mani on 27 November 2023, 13:35
  > Done.

    Reply by Sean Nash on 28 November 2023, 09:23
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 27 November 2023, 09:25 
https://devapps.diality.us/cru/HD-DEN-16512-1#c19263

  Remove blank line.

  Reply by Vinayakam Mani on 27 November 2023, 13:34
  > Done.

    Reply by Sean Nash on 28 November 2023, 09:25
    > RESOLVED in CODE WALKTHROUGH.

----------------------------------------
File: firmware/App/Modes/ModeTreatment.c
Revision Comment by Sean Nash on 04 December 2023, 14:22 
https://devapps.diality.us/cru/HD-DEN-16512-1#c19302

  Consider splitting this if and the setDialysisParams() function
  into two: 1) blood flow rate changed and 2) dialysate flow rate
  changed.

  Reply by Vinayakam Mani on 06 December 2023, 16:05
  > Done.

    Reply by Sean Nash on 07 December 2023, 09:41
    > RESOLVED in CODE WALKTHROUGH.


---

ID: HD-DEN-16512-1 https://devapps.diality.us/cru/HD-DEN-16512-1

Title: HD-DEN-16512_Dpo Stops During Treatment After Reconfirming Dialysate Flow Rate
Statement of Objectives:


State: Closed

Summary: 

Author: Vinayakam Mani
Moderator: Vinayakam Mani
Reviewers: (5 active, 2 completed*)
     Sean Nash   (*)
     Dara Navaei   (*)
     jpaguio
     Michael Garthwaite
     wbracken
     Darren Cox
     jtaylor