This is a list of all comments for HD-DEN-16595-2.

Review Summary: No summary


----------------------------------------
File: firmware/App/Services/AlarmMgmt.c
Revision Comment by Dara Navaei on 08 January 2024, 08:56 
https://devapps.diality.us/cru/HD-DEN-16595-2#c19342

  Why was this block removed? We do not need to check of the
  empty bottles alarms anymore?

  Reply by Vinayakam Mani on 08 January 2024, 12:59
  > The removed code changes are dead code due to condition of
  > "if" condition check at top level ( ALARM_TABLE[ a
  > ].alarmClearOnly). these alarms have property of 'clear only'
  > as 'TRUE" in the alarm table. hence condition always be false
  > and the removed code changes never executed.

    Reply by Dara Navaei on 08 January 2024, 20:10
    > RESOLVED in CODE WALKTHROUGH


---

ID: HD-DEN-16595-2 https://devapps.diality.us/cru/HD-DEN-16595-2

Title: HD-DEN-16595_Vectorcast Unit And Integration Testing
Statement of Objectives:


State: Closed

Summary: 

Author: Vinayakam Mani
Moderator: Vinayakam Mani
Reviewers: (3 active, 2 completed*)
     Sean Nash   (*)
     Dara Navaei   (*)
     jpaguio
     Michael Garthwaite
     Darren Cox