This is a list of all comments for HD-DEN-16693-1.

Review Summary: No summary


----------------------------------------
File: firmware/App/Modes/ModeTreatmentParams.c
Revision Comment by Sean Nash on 07 March 2024, 14:32 
https://devapps.diality.us/cru/HD-DEN-16693-1#c19580

  Cast constant as (F32) as before.

  Reply by Dara Navaei on 07 March 2024, 14:38
  > Done

    Reply by Sean Nash on 07 March 2024, 14:56
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 27 February 2024, 16:06 
https://devapps.diality.us/cru/HD-DEN-16693-1#c19518

  All of these ternaries should say ... ? result : FALSE );

  Reply by Dara Navaei on 29 February 2024, 09:26
  > I check these against result since it is result &= ().

    Reply by Sean Nash on 29 February 2024, 10:24
    > RESOLVED in CODE WALKTHROUGH.

----------------------------------------
File: firmware/App/Modes/ModeTreatmentParams.h
Revision Comment by Sean Nash on 27 February 2024, 16:08 
https://devapps.diality.us/cru/HD-DEN-16693-1#c19519

  Remove blank line.

  Reply by Dara Navaei on 29 February 2024, 09:25
  > Done

    Reply by Sean Nash on 29 February 2024, 10:23
    > RESOLVED in CODE WALKTHROUGH.

----------------------------------------
File: firmware/App/Services/WatchdogMgmt.c
Revision Comment by Sean Nash on 01 March 2024, 10:18 
https://devapps.diality.us/cru/HD-DEN-16693-1#c19549

  This alarm should be restored.

  Reply by Dara Navaei on 04 March 2024, 12:55
  > Done

    Reply by Sean Nash on 05 March 2024, 10:14
    > RESOLVED in CODE WALKTHROUGH.

----------------------------------------
File: firmware/App/Modes/ModeTreatment.c
Revision Comment by Sean Nash on 07 March 2024, 14:35 
https://devapps.diality.us/cru/HD-DEN-16693-1#c19581

  Do we need to add check for minimum treatment duration?

  Reply by Dara Navaei on 07 March 2024, 14:46
  > Done

    Reply by Sean Nash on 07 March 2024, 14:59
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by pvedantam on 08 March 2024, 15:16 
https://devapps.diality.us/cru/HD-DEN-16693-1#c19596

  We did not check for the upper limit in the past, does this add
  new rejection scenarios

  Reply by pvedantam on 08 March 2024, 15:33
  > RESOLVED IN CODE WALKTHGROUGH

Revision Comment by Sean Nash on 07 March 2024, 14:10 
https://devapps.diality.us/cru/HD-DEN-16693-1#c19578

  dialVolume is a volume (not a flow).  Use constant (as before)
  for dialVolume check.

  Reply by Dara Navaei on 07 March 2024, 14:14
  > Done

    Reply by Sean Nash on 07 March 2024, 14:41
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 07 March 2024, 14:58 
https://devapps.diality.us/cru/HD-DEN-16693-1#c19586

  Add minimum check here too.

  Reply by Dara Navaei on 07 March 2024, 15:02
  > Done

    Reply by Sean Nash on 07 March 2024, 15:13
    > RESOLVED in CODE WALKTHROUGH.


---

ID: HD-DEN-16693-1 https://devapps.diality.us/cru/HD-DEN-16693-1

Title: HD-DEN-16693_Institutional Settings Implementation
Statement of Objectives:


State: Closed

Summary: 

Author: Dara Navaei
Moderator: Dara Navaei
Reviewers: (4 active, 2 completed*)
     Sean Nash   (*)
     Vinayakam Mani   (*)
     pvedantam
     jpaguio
     Michael Garthwaite
     Darren Cox