This is a list of all comments for HD-DEN-16773-1.

Review Summary: No summary


----------------------------------------
File: firmware/App/Controllers/AirPump.c
Revision Comment by Vinayakam Mani on 18 March 2024, 15:12 
https://devapps.diality.us/cru/HD-DEN-16773-1#c19631

  Can we remove the AIR_PUMP_OPERATION_TIMEOUT Macro?

  Reply by Dara Navaei on 18 March 2024, 15:26
  > Done

    Reply by Vinayakam Mani on 18 March 2024, 15:40
    > RESOLVED IN CODE WALKTHROUGH

----------------------------------------
File: firmware/App/Modes/ModeStandby.c
Revision Comment by Sean Nash on 18 March 2024, 21:38 
https://devapps.diality.us/cru/HD-DEN-16773-1#c19636

  This should probably be in an else below.

  Reply by Dara Navaei on 19 March 2024, 09:29
  > Done

    Reply by Sean Nash on 19 March 2024, 10:03
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 18 March 2024, 21:39 
https://devapps.diality.us/cru/HD-DEN-16773-1#c19637

  Put this in an else below.

  Reply by Dara Navaei on 19 March 2024, 08:28
  > I thought about having an else below but this way we write
  > less code. I have done similar in the past.

    Reply by Sean Nash on 19 March 2024, 08:55
    > It's 1 line of code either way.  Just on top or below in an
    > else.  Vectorcast will see as a branch you need to test
    > either way.
    > If you put it in an else, the processor does less work and
    > I think it's a lot easier to read.

      Reply by Dara Navaei on 19 March 2024, 09:29
      > Done

        Reply by Sean Nash on 19 March 2024, 10:03
        > RESOLVED in CODE WALKTHROUGH.

----------------------------------------
File: NVDataMgmt.c
Revision Comment by Sean Nash on 18 March 2024, 21:35 
https://devapps.diality.us/cru/HD-DEN-16773-1#c19635

  disinfect is misspelled.

  Reply by Dara Navaei on 19 March 2024, 08:23
  > Done

    Reply by Sean Nash on 19 March 2024, 08:54
    > RESOLVED in CODE WALKTHROUGH.


---

ID: HD-DEN-16773-1 https://devapps.diality.us/cru/HD-DEN-16773-1

Title: HD-DEN-16773_Add Chemical Disinfect Enable TO The Institutional Record
Statement of Objectives:


State: Closed

Summary: 

Author: Dara Navaei
Moderator: Dara Navaei
Reviewers: (3 active, 2 completed*)
     Sean Nash   (*)
     pvedantam   (*)
     jpaguio
     Vinayakam Mani
     Michael Garthwaite