This is a list of all comments for HD-DEN-2390-1.

Review Summary: No summary


----------------------------------------
File: firmware/App/Modes/Dialysis.c
Revision Comment by pmontazemi on 29 March 2020, 21:23 
https://devapps.diality.us/cru/HD-DEN-2390-1#c1552

  function name not verbose enough, elaborate.

  Reply by Sean Nash on 31 March 2020, 08:54
  > Done.

    Reply by pmontazemi on 01 April 2020, 08:33
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by pmontazemi on 29 March 2020, 21:24 
https://devapps.diality.us/cru/HD-DEN-2390-1#c1553

  Same comment on being more verbose on naming of function, here.

  Reply by Sean Nash on 30 March 2020, 08:39
  > Done.

    Reply by pmontazemi on 01 April 2020, 08:33
    > RESOLVED in CODE WALKTHROUGH.

----------------------------------------
File: firmware/App/Modes/ModeTreatment.c
Revision Comment by pmontazemi on 29 March 2020, 21:25 
https://devapps.diality.us/cru/HD-DEN-2390-1#c1554

  Avoid questions in code comments, turn them all to affirmations
  reflecting what this line of code is doing.

  Reply by Sean Nash on 30 March 2020, 08:37
  > Done.

    Reply by pmontazemi on 30 March 2020, 10:24
    > RESOLVED in CODE WALKTHROUGH.

----------------------------------------
File: firmware/App/HDCommon.h
Revision Comment by pmontazemi on 29 March 2020, 21:31 
https://devapps.diality.us/cru/HD-DEN-2390-1#c1556

  This build shall be overwritten by Bamboo server (no action
  item here, but one action item for DevOps).

  Reply by Dara Navaei on 30 March 2020, 08:22
  > Will do

    Reply by Sean Nash on 30 March 2020, 08:32
    > Yes, my thinking is that an "official" build will never be
    > zero.  If we see zero, it means it's an unofficial build -
    > probably from somebody's branch.

      Reply by pmontazemi on 30 March 2020, 10:26
      > RESOLVED in CODE WALKTHROUGH. Dara will create a DevOps
      > Task on Bamboo server to address this.

----------------------------------------
File: firmware/App/Controllers/DialOutFlow.c
Revision Comment by pmontazemi on 29 March 2020, 21:22 
https://devapps.diality.us/cru/HD-DEN-2390-1#c1549

  dialIn or dialOut?

  Reply by Sean Nash on 31 March 2020, 08:44
  > Fixed.

    Reply by pmontazemi on 31 March 2020, 08:45
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by pmontazemi on 29 March 2020, 21:22 
https://devapps.diality.us/cru/HD-DEN-2390-1#c1550

  dialIn or dialOut?

  Reply by Sean Nash on 30 March 2020, 08:42
  > dialOut.  Fixed.

    Reply by pmontazemi on 30 March 2020, 10:20
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by pmontazemi on 29 March 2020, 21:22 
https://devapps.diality.us/cru/HD-DEN-2390-1#c1551

  Where does the conversion from voltage to grams happen?

  Reply by Sean Nash on 30 March 2020, 08:39
  > Done by DG before it is sent to HD.

    Reply by pmontazemi on 30 March 2020, 10:20
    > RESOLVED in CODE WALKTHROUGH.

----------------------------------------
File: firmware/App/Services/SystemComm.c
Revision Comment by pmontazemi on 29 March 2020, 21:28 
https://devapps.diality.us/cru/HD-DEN-2390-1#c1555

  How is 120 ms computed?

  Reply by Sean Nash on 30 March 2020, 08:34
  > At 50ms task interval, it can't.  I believe what I was
  > thinking is that 100 ms would be ok, but 150 ms would fail.
  > Changed to 150 ms.

    Reply by pmontazemi on 01 April 2020, 08:35
    > RESOLVED in CODE WALKTHROUGH.

----------------------------------------
File: firmware/App/Controllers/BloodFlow.c
Revision Comment by pmontazemi on 29 March 2020, 21:18 
https://devapps.diality.us/cru/HD-DEN-2390-1#c1548

  Why have these been move to the corresponding header file? I
  would like to understand which #defines belong to *.h and which
  ones to *.c.

  Reply by Sean Nash on 30 March 2020, 08:43
  > I needed the treatment mode module to be able to see these so
  > it could verify user settings changes.

    Reply by pmontazemi on 30 March 2020, 10:18
    > RESOLVED in CODE WALKTHROUGH.

----------------------------------------
File: MsgDefs.h
Revision Comment by pmontazemi on 29 March 2020, 21:17 
https://devapps.diality.us/cru/HD-DEN-2390-1#c1547

  Should we mention that the user request is via UI?

  Reply by Sean Nash on 30 March 2020, 08:44
  > Not sure how else user would request something.  I'm trying
  > to keep these enums short while still being descriptive.

    Reply by pmontazemi on 30 March 2020, 10:17
    > RESOLVED in CODE WALKTHROUGH.


---

ID: HD-DEN-2390-1 https://devapps.diality.us/cru/HD-DEN-2390-1

Title: HD-DEN-2390_HD Dialysate Temperature (1 of 2)
Statement of Objectives:


State: Closed

Summary: 

Author: Sean Nash
Moderator: Sean Nash
Reviewers: (0 active, 2 completed*)
     Dara Navaei   (*)
     pmontazemi   (*)