This is a list of all comments for HD-DEN-431-DIA-1.

Review Summary: No summary


----------------------------------------
File: firmware/App/Services/SystemCommMessages.c
Revision Comment by Sean Nash on 20 January 2020, 17:34 
https://devapps.diality.us/cru/HD-DEN-431-DIA-1#c1147

  Needs function header

  Reply by Dara Navaei on 20 January 2020, 18:33
  > Done

    Reply by Sean Nash on 21 January 2020, 08:43
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 20 January 2020, 17:34 
https://devapps.diality.us/cru/HD-DEN-431-DIA-1#c1148

  Needs function header.

  Reply by Dara Navaei on 20 January 2020, 18:33
  > Done

    Reply by Sean Nash on 21 January 2020, 08:43
    > RESOLVED in CODE WALKTHROUGH.

----------------------------------------
File: RTC.c
Revision Comment by Sean Nash on 20 January 2020, 17:38 
https://devapps.diality.us/cru/HD-DEN-431-DIA-1#c1150

  May not want to broadcast at same interval as RTC read.
  Recommend separating broadcast to its own schedule in case we
  want to broadcast epoch less often.

  Reply by Dara Navaei on 20 January 2020, 18:05
  > I thought about that before putting the function here. Sure
  > we can add more logic but I would like to make sure we
  > definitely want to broadcast time less often.

    Reply by Sean Nash on 21 January 2020, 08:44
    > Change deferred.  RESOLVED in CODE WALKTHROUGH.


---

ID: HD-DEN-431-DIA-1 https://devapps.diality.us/cru/HD-DEN-431-DIA-1

Title: HD-DEN-431_RTC Dialin Implementation
Statement of Objectives:


State: Closed

Summary: 

Author: Dara Navaei
Moderator: Dara Navaei
Reviewers: (2 active, 2 completed*)
     Sean Nash   (*)
     pmontazemi   (*)
     Behrouz NematiPour
     lbaloa