This is a list of all comments for HD-DEN-5053-1. Review Summary: No summary ---------------------------------------- File: firmware/App/Modes/ModeTreatmentParams.h Revision Comment by qnguyen on 22 September 2020, 15:46 https://devapps.diality.us/cru/HD-DEN-5053-1#c4798 Public was correct. Reverse the change. Reply by Sean Nash on 22 September 2020, 16:42 > Done. Reply by qnguyen on 23 September 2020, 10:35 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Services/SystemCommMessages.c Revision Comment by qnguyen on 15 October 2020, 10:30 https://devapps.diality.us/cru/HD-DEN-5053-1#c5541 Suggest removing extra colon between param name and description. Reply by Sean Nash on 15 October 2020, 13:41 > Done. Reply by qnguyen on 19 October 2020, 10:32 > RESOLVED in CODE WALKTHROUGH. Revision Comment by qnguyen on 15 October 2020, 10:31 https://devapps.diality.us/cru/HD-DEN-5053-1#c5542 Revert this change for doxygen comment. Reply by Sean Nash on 15 October 2020, 13:44 > Done. Reply by qnguyen on 19 October 2020, 10:33 > RESOLVED in CODE WALKTHROUGH. Revision Comment by qnguyen on 15 October 2020, 10:32 https://devapps.diality.us/cru/HD-DEN-5053-1#c5544 Function name and description are not matched. Reply by Sean Nash on 15 October 2020, 13:48 > Done. Reply by qnguyen on 19 October 2020, 10:47 > RESOLVED in CODE WALKTHROUGH. Revision Comment by qnguyen on 15 October 2020, 10:35 https://devapps.diality.us/cru/HD-DEN-5053-1#c5545 This reset is generated by the application software writing a 1 to bit 15 of System Exception Control Register (SYSECR) or a 0 to bit 14 of SYSECR. This shift will write a 1 to bit 18 and 0 to the rest. Probably still work since it still writes a 0 to bit 14, but we might as well assign 0x0 to this register. Reply by Sean Nash on 15 October 2020, 13:57 > Done. Reply by qnguyen on 19 October 2020, 10:34 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Controllers/AirTrap.c Revision Comment by qnguyen on 22 September 2020, 15:54 https://devapps.diality.us/cru/HD-DEN-5053-1#c4801 Incorrect description. Should remove this since there is another inlined doxygen comment for this define. Reply by Sean Nash on 22 September 2020, 16:39 > Done. Reply by qnguyen on 23 September 2020, 10:34 > RESOLVED in CODE WALKTHROUGH. Revision Comment by qnguyen on 22 September 2020, 15:55 https://devapps.diality.us/cru/HD-DEN-5053-1#c4802 Change Self test to Self-test for consistency. Reply by Sean Nash on 22 September 2020, 16:38 > Done. Reply by qnguyen on 23 September 2020, 10:34 > RESOLVED in CODE WALKTHROUGH. Revision Comment by qnguyen on 22 September 2020, 15:57 https://devapps.diality.us/cru/HD-DEN-5053-1#c4803 Recommend moving doxygen commend to be right above or align the comment. Reply by Sean Nash on 22 September 2020, 16:37 > Done. Reply by qnguyen on 23 September 2020, 10:34 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Dara Navaei on 23 September 2020, 08:40 https://devapps.diality.us/cru/HD-DEN-5053-1#c4819 I thought we are not going to have a space after Input/Output and ":". Reply by Dara Navaei on 30 September 2020, 10:32 > RESOLVED IN CODE WALKTRHOUGH Revision Comment by qnguyen on 22 September 2020, 15:59 https://devapps.diality.us/cru/HD-DEN-5053-1#c4804 Recommend to combine into one line and return the if condition. Reply by Sean Nash on 23 September 2020, 10:36 > I think it's more readable this way. Reply by qnguyen on 23 September 2020, 10:36 > RESOLVED in CODE WALKTHROUGH. Revision Comment by qnguyen on 22 September 2020, 16:05 https://devapps.diality.us/cru/HD-DEN-5053-1#c4805 Should be air trap data. Reply by Sean Nash on 22 September 2020, 16:35 > Done. Reply by qnguyen on 23 September 2020, 10:34 > RESOLVED in CODE WALKTHROUGH. Revision Comment by qnguyen on 22 September 2020, 16:07 https://devapps.diality.us/cru/HD-DEN-5053-1#c4806 Suggest replacing pressure and occlusion with air trap. Reply by Sean Nash on 22 September 2020, 16:34 > Done. Reply by qnguyen on 23 September 2020, 10:34 > RESOLVED in CODE WALKTHROUGH. Revision Comment by qnguyen on 22 September 2020, 16:09 https://devapps.diality.us/cru/HD-DEN-5053-1#c4807 Function name and doxygen comment not match. Reply by Sean Nash on 22 September 2020, 16:34 > Done. Reply by qnguyen on 23 September 2020, 10:33 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Controllers/AirTrap.h Revision Comment by qnguyen on 22 September 2020, 15:52 https://devapps.diality.us/cru/HD-DEN-5053-1#c4799 The description seems to be incorrect. Reply by Sean Nash on 22 September 2020, 16:41 > Done. Reply by qnguyen on 23 September 2020, 10:35 > RESOLVED in CODE WALKTHROUGH. Revision Comment by qnguyen on 22 September 2020, 15:53 https://devapps.diality.us/cru/HD-DEN-5053-1#c4800 Should it be number of air trap sensor? Reply by Sean Nash on 22 September 2020, 16:40 > Done. Reply by qnguyen on 23 September 2020, 10:35 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Controllers/PresOccl.h Revision Comment by qnguyen on 22 September 2020, 16:11 https://devapps.diality.us/cru/HD-DEN-5053-1#c4808 Expand macros. Reply by Sean Nash on 22 September 2020, 16:43 > Done. Reply by qnguyen on 23 September 2020, 10:33 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Services/AlarmMgmt.c Revision Comment by pmontazemi on 20 October 2020, 10:49 https://devapps.diality.us/cru/HD-DEN-5053-1#c5671 Space between 250 / TASK... Reply by Sean Nash on 20 October 2020, 10:55 > Done. Reply by pmontazemi on 20 October 2020, 11:05 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: PersistentAlarm.c Revision Comment by qnguyen on 25 September 2020, 09:10 https://devapps.diality.us/cru/HD-DEN-5053-1#c4915 Somehow the commands missed this. Need to add @details and remove extra space. Reply by Sean Nash on 01 October 2020, 09:13 > Done. Reply by qnguyen on 01 October 2020, 10:39 > RESOLVED in CODE WALKTHROUGH. Revision Comment by qnguyen on 25 September 2020, 09:10 https://devapps.diality.us/cru/HD-DEN-5053-1#c4914 Somehow the commands missed this. Need to add @details and remove extra space. Reply by Sean Nash on 01 October 2020, 09:14 > Done. Reply by qnguyen on 01 October 2020, 10:39 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: RTC.c Revision Comment by qnguyen on 25 September 2020, 09:13 https://devapps.diality.us/cru/HD-DEN-5053-1#c4916 Somehow the commands missed this. Need to add @details and remove extra space. Reply by Sean Nash on 01 October 2020, 09:12 > Done. Reply by qnguyen on 01 October 2020, 10:39 > RESOLVED in CODE WALKTHROUGH. --- ID: HD-DEN-5053-1 https://devapps.diality.us/cru/HD-DEN-5053-1 Title: HD-DEN-5053_HD Air Trap Statement of Objectives: State: Closed Summary: Author: Sean Nash Reviewers: (0 active, 3 completed*) qnguyen (*) Dara Navaei (*) pmontazemi (*)