This is a list of all comments for HD-DEN-5381-1.

Review Summary: No summary


----------------------------------------
File: firmware/App/Services/AlarmMgmt.c
Revision Comment by pmontazemi on 17 December 2020, 09:21 
https://devapps.diality.us/cru/HD-DEN-5381-1#c6842

  Where were these moved to?

  Reply by Sean Nash on 17 December 2020, 10:44
  > Moved to common AlarmDefs.h.

    Reply by pmontazemi on 29 December 2020, 10:39
    > RESOLVED in CODE WALKTHROUGH.

----------------------------------------
File: firmware/App/Services/SystemComm.c
Revision Comment by pmontazemi on 17 December 2020, 09:22 
https://devapps.diality.us/cru/HD-DEN-5381-1#c6843

  If commented code, either remove it or add TODO comment to
  remember to either uncomment it or delete it in the future.

  Reply by qnguyen on 17 December 2020, 13:14
  > Removed.

    Reply by pmontazemi on 29 December 2020, 10:39
    > RESOLVED in CODE WALKTHROUGH.

----------------------------------------
File: firmware/App/Modes/Prime.c
Revision Comment by Sean Nash on 17 December 2020, 10:47 
https://devapps.diality.us/cru/HD-DEN-5381-1#c6847

  I didn't see these states defined in this module.  Where is the
  enum declared?  If in common, I don't see common code in this
  code review project.

  Reply by qnguyen on 17 December 2020, 13:12
  > Added common into code review.

    Reply by Sean Nash on 29 December 2020, 10:34
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 17 December 2020, 10:48 
https://devapps.diality.us/cru/HD-DEN-5381-1#c6848

  Should be an elseif?

  Reply by qnguyen on 17 December 2020, 13:13
  > Done.

    Reply by Sean Nash on 29 December 2020, 10:35
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 17 December 2020, 10:56 
https://devapps.diality.us/cru/HD-DEN-5381-1#c6849

  I think this waiting for DG should be done in its own state.

  Reply by qnguyen on 17 December 2020, 13:26
  > Moved into its own state.

    Reply by Sean Nash on 29 December 2020, 10:34
    > RESOLVED in CODE WALKTHROUGH.

----------------------------------------
File: firmware/App/Modes/ModePreTreat.c
Revision Comment by Sean Nash on 17 December 2020, 10:38 
https://devapps.diality.us/cru/HD-DEN-5381-1#c6844

  Should reset state to start state here or we won't be able to
  do a second treatment.

  Reply by qnguyen on 17 December 2020, 13:13
  > Done.

    Reply by Sean Nash on 29 December 2020, 10:35
    > RESOLVED in CODE WALKTHROUGH.

----------------------------------------
File: firmware/App/Modes/ModeStandby.c
Revision Comment by Sean Nash on 17 December 2020, 16:17 
https://devapps.diality.us/cru/HD-DEN-5381-1#c6856

  Where did command to start reservoir 2 as active get moved to?

  Reply by qnguyen on 17 December 2020, 16:20
  > It is at the beginning of Prime sub-mode.

    Reply by Sean Nash on 29 December 2020, 10:34
    > RESOLVED in CODE WALKTHROUGH.


---

ID: HD-DEN-5381-1 https://devapps.diality.us/cru/HD-DEN-5381-1

Title: HD-DEN-5381_HD Prime Blood Side
Statement of Objectives:


State: Closed

Summary: 

Author: qnguyen
Reviewers: (1 active, 2 completed*)
     Sean Nash   (*)
     pmontazemi   (*)
     Dara Navaei