This is a list of all comments for HD-DEN-5887-1.

Review Summary: No summary


----------------------------------------
File: firmware/App/HDCommon.h
Revision Comment by Dara Navaei on 29 December 2020, 10:08 
https://devapps.diality.us/cru/HD-DEN-5887-1#c6874

  Has this been changed by manually?

  Reply by Sean Nash on 30 December 2020, 11:55
  > Yes.  My understanding is that build should be zero for dev
  > builds.  Bamboo then sets build # as appropriate after merge
  > to master.

    Reply by Dara Navaei on 30 December 2020, 14:16
    > RESOLVED in CODE WALKTRHOUGH.

----------------------------------------
File: firmware/App/Services/AlarmMgmt.c
Revision Comment by pmontazemi on 29 December 2020, 11:00 
https://devapps.diality.us/cru/HD-DEN-5887-1#c6907

  Why were these deleted?

  Reply by Sean Nash on 30 December 2020, 11:51
  > Moved to AlarmDefs.h in common.  Dara, please add common repo
  > to this code review.

    Reply by pmontazemi on 30 December 2020, 14:19
    > RESOLVED in CODE WALKTHROUGH.

----------------------------------------
File: firmware/App/Services/PIControllers.c
Revision Comment by pmontazemi on 29 December 2020, 11:00 
https://devapps.diality.us/cru/HD-DEN-5887-1#c6908

  runs instead of run

  Reply by Sean Nash on 30 December 2020, 11:54
  > Fixed.

    Reply by pmontazemi on 30 December 2020, 14:19
    > RESOLVED in CODE WALKTHROUGH.

----------------------------------------
File: firmware/App/Controllers/DGInterface.c
Revision Comment by qnguyen on 30 December 2020, 00:23 
https://devapps.diality.us/cru/HD-DEN-5887-1#c6932

  Should we associate primary load cell reading to each reservoir
  and run a for loop here?

  Reply by Sean Nash on 30 December 2020, 12:02
  > Done.

    Reply by qnguyen on 30 December 2020, 14:11
    > RESOLVED in CODE WALKTHROUGH.

----------------------------------------
File: firmware/App/Controllers/DialOutFlow.c
Revision Comment by pmontazemi on 19 February 2021, 10:28 
https://devapps.diality.us/cru/HD-DEN-5887-1#c8194

  Why reduced control frequency update?

  Reply by Sean Nash on 19 February 2021, 10:32
  > Part of tuning of UF control.  Load cells are so noisy,
  > control interval seemed too fast at 1 Hz.

    Reply by pmontazemi on 19 February 2021, 10:37
    > RESOLVED in CODE WALKTHROUGH.

----------------------------------------
File: firmware/App/Modes/Dialysis.c
Revision Comment by pmontazemi on 11 February 2021, 09:50 
https://devapps.diality.us/cru/HD-DEN-5887-1#c7886

  Is this instantaneous change or there is filtering that gets
  applied by analog or programmable logic before that?

  Reply by Sean Nash on 11 February 2021, 09:55
  > Delta is between prior reservoir weight (50 ms ago) and
  > current reservoir weight.  Both are filtered (moving avg over
  > 800 ms).  Looking for load cell interference (maybe somebody
  > bumped the table that the system is sitting on).  Want to
  > pause treatment to allow interference to resolve and prevent
  > bad load cell data from getting into ultrafiltration tracking
  > logic (e.g. if load cell jumps up significantly, UF logic
  > might wrongfully determine that we have reached our target UF
  > volume way too early).

    Reply by pmontazemi on 11 February 2021, 11:16
    > RESOLVED in CODE WALKTHROUGH.

----------------------------------------
File: firmware/App/Modes/ModeTreatment.c
Revision Comment by pmontazemi on 09 February 2021, 10:26 
https://devapps.diality.us/cru/HD-DEN-5887-1#c7845

  Why was this removed? No more end treatment requested by user
  option?

  Reply by Sean Nash on 09 February 2021, 10:33
  > User will request treatment end via the alarm system instead
  > of having a dedicated button on the main treatment screen.
  > So this function became obsolete.

    Reply by pmontazemi on 11 February 2021, 11:17
    > RESOLVED in CODE WALKTHROUGH.


---

ID: HD-DEN-5887-1 https://devapps.diality.us/cru/HD-DEN-5887-1

Title: HD-DEN-5887_HD Ultrafiltration Filtering
Statement of Objectives:


State: Closed

Summary: 

Author: Sean Nash
Reviewers: (0 active, 3 completed*)
     qnguyen   (*)
     Dara Navaei   (*)
     pmontazemi   (*)