This is a list of all comments for HD-DEN-5980-1. Review Summary: No summary ---------------------------------------- File: firmware/App/Controllers/BloodFlow.c Revision Comment by Sean Nash on 22 February 2021, 09:57 https://devapps.diality.us/cru/HD-DEN-5980-1#c8221 Why is this commented out? Reply by Dara Navaei on 22 March 2021, 22:21 > fwcommon had to be updated with latest changes. It is > un-commented. Reply by Sean Nash on 23 March 2021, 10:53 > RESOLVED in CODE WALKTHROUGH. Revision Comment by qnguyen on 21 March 2021, 16:59 https://devapps.diality.us/cru/HD-DEN-5980-1#c8419 Where is this getHDFlowSensorsCalibrationRecord function located? Is it part of fwcommon changes? If yes, please add to code review. Reply by Dara Navaei on 22 March 2021, 21:35 > Yes it is part of fwcommon. To review fwcommon, please review > DG-DEN-5980 code review. Reply by qnguyen on 23 March 2021, 10:33 > RESOLVED in CODE WALKTHROUGH. Revision Comment by qnguyen on 23 March 2021, 10:37 https://devapps.diality.us/cru/HD-DEN-5980-1#c8578 Remove extra line. Reply by Dara Navaei on 24 March 2021, 08:53 > Done. Reply by qnguyen on 24 March 2021, 10:32 > RESOLVED in CODE WALKTHROUGH. Revision Comment by qnguyen on 21 March 2021, 19:40 https://devapps.diality.us/cru/HD-DEN-5980-1#c8425 Should we check here if calibration data is valid? Reply by Dara Navaei on 22 March 2021, 21:34 > The calibration data is validated in NVDataMgmt driver. Reply by qnguyen on 23 March 2021, 10:37 > RESOLVED in CODE WALKTHROUGH. Revision Comment by qnguyen on 23 March 2021, 10:52 https://devapps.diality.us/cru/HD-DEN-5980-1#c8598 is getCalibrationData function still existed? If not, need to remove it. Reply by Dara Navaei on 29 March 2021, 21:40 > Done. Reply by qnguyen on 02 April 2021, 10:33 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Controllers/DGInterface.h Revision Comment by qnguyen on 21 March 2021, 16:57 https://devapps.diality.us/cru/HD-DEN-5980-1#c8418 Remove this typedef. It is defined in common repo. Reply by Dara Navaei on 22 March 2021, 21:36 > Done Reply by qnguyen on 23 March 2021, 10:37 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Controllers/DialInFlow.c Revision Comment by qnguyen on 23 March 2021, 10:50 https://devapps.diality.us/cru/HD-DEN-5980-1#c8594 Uncomment code. Reply by Dara Navaei on 24 March 2021, 08:47 > Done. Reply by qnguyen on 24 March 2021, 10:32 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Controllers/PresOccl.c Revision Comment by Sean Nash on 22 February 2021, 09:59 https://devapps.diality.us/cru/HD-DEN-5980-1#c8222 Why are these commented out? Reply by Dara Navaei on 22 March 2021, 22:21 > fwcommon had to be updated with latest changes. They are > un-commented. Reply by Sean Nash on 23 March 2021, 10:52 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Modes/ModeInitPOST.c Revision Comment by Sean Nash on 22 February 2021, 09:59 https://devapps.diality.us/cru/HD-DEN-5980-1#c8223 Leave this as is and just don't define SKIP_POST build switch if you want your POST to run. Reply by Dara Navaei on 22 March 2021, 22:14 > I just need to run NVDataMgmt POST and nothing else. I added > a build switch. Reply by Sean Nash on 22 March 2021, 23:06 > Are you really running this on an eval board? I removed > this build switch a while back as nobody was using it > anymore. Reply by Dara Navaei on 22 March 2021, 23:13 > It is a Diality board but it is treated as an eval board > since there is nothing attached to it. Reply by Sean Nash on 23 March 2021, 10:52 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Modes/ModePreTreat.c Revision Comment by qnguyen on 21 March 2021, 16:55 https://devapps.diality.us/cru/HD-DEN-5980-1#c8417 Remove this case. Its obsolete. Reply by Dara Navaei on 22 March 2021, 21:38 > Done Reply by qnguyen on 23 March 2021, 10:38 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 22 February 2021, 10:01 https://devapps.diality.us/cru/HD-DEN-5980-1#c8224 Why is this commented out? Reply by Dara Navaei on 22 March 2021, 22:13 > I am not sure. I un-commented it. Reply by Sean Nash on 23 March 2021, 10:51 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 24 March 2021, 14:00 https://devapps.diality.us/cru/HD-DEN-5980-1#c8733 Add TODO to commented line. Reply by Dara Navaei on 25 March 2021, 09:28 > This has been uncommented. Reply by pmontazemi on 02 April 2021, 10:41 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 24 March 2021, 14:01 https://devapps.diality.us/cru/HD-DEN-5980-1#c8734 Add TODO to commented lines. Reply by Dara Navaei on 29 March 2021, 21:55 > The above line has been removed. Reply by pmontazemi on 02 April 2021, 10:41 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 24 March 2021, 14:03 https://devapps.diality.us/cru/HD-DEN-5980-1#c8735 Add TODO. Reply by Dara Navaei on 29 March 2021, 21:39 > This function has been removed. Reply by pmontazemi on 02 April 2021, 10:41 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 24 March 2021, 14:03 https://devapps.diality.us/cru/HD-DEN-5980-1#c8736 Add TODO. Reply by Dara Navaei on 29 March 2021, 21:39 > This function has been removed. Reply by pmontazemi on 02 April 2021, 10:40 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 24 March 2021, 14:04 https://devapps.diality.us/cru/HD-DEN-5980-1#c8737 Add TODO. Reply by Dara Navaei on 29 March 2021, 21:39 > This function has been removed. Reply by pmontazemi on 02 April 2021, 10:41 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Modes/ModeTreatment.c Revision Comment by Sean Nash on 22 February 2021, 10:01 https://devapps.diality.us/cru/HD-DEN-5980-1#c8225 Just delete this case. Obsolete. Reply by Dara Navaei on 24 March 2021, 09:10 > Done. Reply by Sean Nash on 24 March 2021, 10:36 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 22 March 2021, 23:08 https://devapps.diality.us/cru/HD-DEN-5980-1#c8560 Just delete this case. Reply by Dara Navaei on 22 March 2021, 23:15 > Done Reply by Sean Nash on 23 March 2021, 10:40 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 24 March 2021, 14:05 https://devapps.diality.us/cru/HD-DEN-5980-1#c8738 Add TODO to commented lines. Reply by Dara Navaei on 26 March 2021, 10:43 > Done. Reply by pmontazemi on 26 March 2021, 10:45 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 22 February 2021, 10:02 https://devapps.diality.us/cru/HD-DEN-5980-1#c8226 Remove "_DIALYSIS" and it should compile. Do this throughout. Reply by Dara Navaei on 22 March 2021, 22:11 > Done. Reply by Sean Nash on 23 March 2021, 10:50 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 24 March 2021, 14:05 https://devapps.diality.us/cru/HD-DEN-5980-1#c8739 Add TODO to commented line. Reply by Dara Navaei on 25 March 2021, 09:17 > This line has been updated. Please look at below. Reply by pmontazemi on 26 March 2021, 10:41 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 24 March 2021, 14:05 https://devapps.diality.us/cru/HD-DEN-5980-1#c8740 Add TODO. Reply by Dara Navaei on 25 March 2021, 09:19 > This line has been removed. Reply by pmontazemi on 26 March 2021, 10:42 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Services/SystemComm.c Revision Comment by qnguyen on 23 March 2021, 10:48 https://devapps.diality.us/cru/HD-DEN-5980-1#c8591 Uncomment this. Reply by Dara Navaei on 24 March 2021, 08:48 > Done. Reply by qnguyen on 24 March 2021, 10:32 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 22 February 2021, 10:04 https://devapps.diality.us/cru/HD-DEN-5980-1#c8227 Delete this case. Obsolete. Reply by Dara Navaei on 22 March 2021, 22:05 > Done Reply by Sean Nash on 23 March 2021, 10:49 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Services/SystemCommMessages.c Revision Comment by Sean Nash on 22 February 2021, 10:06 https://devapps.diality.us/cru/HD-DEN-5980-1#c8229 Delete this function. Obsolete. Reply by Dara Navaei on 23 March 2021, 10:46 > Done. Reply by Sean Nash on 24 March 2021, 10:35 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 22 February 2021, 10:06 https://devapps.diality.us/cru/HD-DEN-5980-1#c8230 Delete this function. Obsolete. Reply by Dara Navaei on 22 March 2021, 22:02 > Done Reply by Sean Nash on 23 March 2021, 10:46 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 24 March 2021, 14:07 https://devapps.diality.us/cru/HD-DEN-5980-1#c8741 Add TODO. Reply by Dara Navaei on 25 March 2021, 09:16 > This function has been deleted. Reply by pmontazemi on 26 March 2021, 10:39 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 22 February 2021, 10:08 https://devapps.diality.us/cru/HD-DEN-5980-1#c8231 Consider creating a structure for the 3 U32s to reduce memcpys. Reply by Dara Navaei on 29 March 2021, 10:51 > It will be addressed in the future stories. Reply by Sean Nash on 29 March 2021, 10:53 > RESOLVED in CODE WALKTHROUGH. Revision Comment by qnguyen on 21 March 2021, 16:53 https://devapps.diality.us/cru/HD-DEN-5980-1#c8416 Comment's first letter needs to be capitalized. Reply by Dara Navaei on 22 March 2021, 21:39 > Done Reply by qnguyen on 23 March 2021, 10:38 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Services/SystemCommMessages.h Revision Comment by Sean Nash on 22 February 2021, 10:05 https://devapps.diality.us/cru/HD-DEN-5980-1#c8228 Delete this function. Obsolete. Reply by Dara Navaei on 22 March 2021, 22:04 > Done Reply by Sean Nash on 23 March 2021, 10:47 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Tasks/TaskBG.c Revision Comment by Sean Nash on 22 February 2021, 10:08 https://devapps.diality.us/cru/HD-DEN-5980-1#c8232 Why is this commented out? Reply by Dara Navaei on 22 March 2021, 21:53 > To be able to run the code on a board with no hardware. I > added a build switch. Reply by Sean Nash on 23 March 2021, 10:44 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Tasks/TaskGeneral.c Revision Comment by Sean Nash on 22 February 2021, 10:09 https://devapps.diality.us/cru/HD-DEN-5980-1#c8233 Why are all of these commented out? Reply by Dara Navaei on 22 March 2021, 21:50 > To be able to run the code on a board with no hardware > attached. I added a build switch. Reply by Sean Nash on 23 March 2021, 10:43 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 24 March 2021, 14:09 https://devapps.diality.us/cru/HD-DEN-5980-1#c8742 Add TODO for all commented lines below. Reply by Dara Navaei on 25 March 2021, 09:15 > I added a build switch so the functions are un-commented. Reply by pmontazemi on 26 March 2021, 10:40 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Tasks/TaskPriority.c Revision Comment by Sean Nash on 22 February 2021, 10:09 https://devapps.diality.us/cru/HD-DEN-5980-1#c8234 Why are all of these commented out? Reply by Dara Navaei on 22 March 2021, 21:46 > To be able to run the code on a board with no hardware > attached. I added a build switch. Reply by Sean Nash on 23 March 2021, 10:42 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/HDCommon.h Revision Comment by Sean Nash on 22 March 2021, 23:13 https://devapps.diality.us/cru/HD-DEN-5980-1#c8563 Rename this. This build switch for was eval board. No longer used. Reply by Dara Navaei on 22 March 2021, 23:14 > Done Reply by Sean Nash on 23 March 2021, 10:39 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 22 February 2021, 10:10 https://devapps.diality.us/cru/HD-DEN-5980-1#c8235 Move "//" to left for consistency. Reply by Dara Navaei on 22 March 2021, 21:41 > Done Reply by Sean Nash on 23 March 2021, 10:40 > RESOLVED in CODE WALKTHROUGH. --- ID: HD-DEN-5980-1 https://devapps.diality.us/cru/HD-DEN-5980-1 Title: HD-DEN-5980_Non Volatile Data Management (2 of 2) Statement of Objectives: State: Closed Summary: Author: Dara Navaei Moderator: Dara Navaei Reviewers: (0 active, 3 completed*) qnguyen (*) Sean Nash (*) pmontazemi (*)