This is a list of all comments for HD-DEN-9054-1.

Review Summary: No summary


----------------------------------------
File: firmware/App/Controllers/SyringePump.c
Revision Comment by Sean Nash on 30 July 2021, 10:46 
https://devapps.diality.us/cru/HD-DEN-9054-1#c10558

  Can we move these 2 lines of code down where the other ADC
  channels are being read and converted?

  Reply by Dara Navaei on 02 August 2021, 13:10
  > Done.

    Reply by Sean Nash on 04 August 2021, 10:30
    > RESOLVED in CODE WALKTHROUGH.

----------------------------------------
File: firmware/App/Services/SystemCommMessages.c
Revision Comment by Sean Nash on 30 July 2021, 10:50 
https://devapps.diality.us/cru/HD-DEN-9054-1#c10559

  The message parameter is not used or needed in this function.

  Reply by Dara Navaei on 30 July 2021, 14:09
  > That is right. I removed the parameter.

    Reply by Sean Nash on 02 August 2021, 10:35
    > RESOLVED in CODE WALKTHROUGH.

----------------------------------------
File: firmware/App/Tasks/TaskGeneral.c
Revision Comment by Sean Nash on 30 July 2021, 10:51 
https://devapps.diality.us/cru/HD-DEN-9054-1#c10560

  Why was this moved?

  Reply by Dara Navaei on 30 July 2021, 14:04
  > I moved it up so it will be run first with respect to the
  > other exec functions. The epoch function is used to set an
  > epoch value to the calibration records that failed but we set
  > them the benign values.

    Reply by Sean Nash on 02 August 2021, 10:38
    > RESOLVED in CODE WALKTHROUGH.

----------------------------------------
File: firmware/source/sys_main.c
Revision Comment by qnguyen on 29 July 2021, 12:36 
https://devapps.diality.us/cru/HD-DEN-9054-1#c10497

  It is both in develop branch and staging branch for fwcommon.

  Reply by Dara Navaei on 31 July 2021, 16:58
  > I merged staging and uncommented the function.

    Reply by qnguyen on 02 August 2021, 10:42
    > RESOLVED in CODE WALKTHROUGH.

----------------------------------------
File: firmware/App/Controllers/Switches.c
Revision Comment by Sean Nash on 30 July 2021, 10:42 
https://devapps.diality.us/cru/HD-DEN-9054-1#c10555

  Should initialize the other elements of the override structure
  too.  Most importantly, the override flag should be off.

  Reply by Dara Navaei on 30 July 2021, 14:14
  > Done.

    Reply by Sean Nash on 02 August 2021, 10:37
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 30 July 2021, 10:45 
https://devapps.diality.us/cru/HD-DEN-9054-1#c10557

  Do we need a debounce on the switch before changing state?

  Reply by Dara Navaei on 31 July 2021, 17:44
  > FPGA only debounces for 50ms. I added code to debounce for a
  > longer period of time.

    Reply by Sean Nash on 02 August 2021, 10:35
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 30 July 2021, 10:44 
https://devapps.diality.us/cru/HD-DEN-9054-1#c10556

  Caps?

  Reply by Dara Navaei on 31 July 2021, 17:21
  > HD does not have any caps.

    Reply by Sean Nash on 02 August 2021, 10:39
    > RESOLVED in CODE WALKTHROUGH.


---

ID: HD-DEN-9054-1 https://devapps.diality.us/cru/HD-DEN-9054-1

Title: HD-DEN-9054_DG HD Switches
Statement of Objectives:


State: Closed

Summary: 

Author: Dara Navaei
Moderator: Dara Navaei
Reviewers: (1 active, 2 completed*)
     qnguyen   (*)
     Sean Nash   (*)
     pmontazemi