This is a list of all comments for HD-DENBUG-162-1.

Review Summary: No summary


----------------------------------------
File: firmware/App/Controllers/PresOccl.c
Revision Comment by Sean Nash on 25 January 2024, 10:09 
https://devapps.diality.us/cru/HD-DENBUG-162-1#c19356

  Use u32DiffWithWrap() function in utilities.

  Reply by Vinayakam Mani on 25 January 2024, 11:48
  > Done.

    Reply by Sean Nash on 05 February 2024, 13:32
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 31 January 2024, 12:21 
https://devapps.diality.us/cru/HD-DENBUG-162-1#c19365

  Remove space before comma.

  Reply by Vinayakam Mani on 31 January 2024, 15:03
  > Done.

    Reply by Sean Nash on 02 February 2024, 09:13
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 25 January 2024, 10:09 
https://devapps.diality.us/cru/HD-DENBUG-162-1#c19357

  Add OR condition for if useShort == FALSE

  Reply by Vinayakam Mani on 25 January 2024, 11:48
  > Done.

    Reply by Sean Nash on 31 January 2024, 12:21
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 02 February 2024, 09:21 
https://devapps.diality.us/cru/HD-DENBUG-162-1#c19385

  This should just be "else".  Think about which of the 3
  possibilities should be the else - maybe the normal period.

  Reply by Vinayakam Mani on 05 February 2024, 12:11
  > Done.

    Reply by Sean Nash on 05 February 2024, 13:30
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 02 February 2024, 09:26 
https://devapps.diality.us/cru/HD-DENBUG-162-1#c19387

  Add a comment here explaining that we don't need stage 2
  stabilization for the regular 15 min adjustment.

  Reply by Vinayakam Mani on 05 February 2024, 12:11
  > Done.

    Reply by Sean Nash on 05 February 2024, 13:30
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 02 February 2024, 09:29 
https://devapps.diality.us/cru/HD-DENBUG-162-1#c19388

  You already did this in prior state.

  Reply by Vinayakam Mani on 05 February 2024, 12:12
  > Done.

    Reply by Sean Nash on 05 February 2024, 13:31
    > RESOLVED in CODE WALKTHROUGH.

----------------------------------------
File: firmware/App/Controllers/PresOccl.h
Revision Comment by Sean Nash on 02 February 2024, 09:08 
https://devapps.diality.us/cru/HD-DENBUG-162-1#c19382

  period should be plural in comment and enum names.

  Reply by Vinayakam Mani on 05 February 2024, 12:12
  > Done.

    Reply by Sean Nash on 05 February 2024, 13:28
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 02 February 2024, 09:09 
https://devapps.diality.us/cru/HD-DENBUG-162-1#c19383

  Maybe just name this stabilization 2.

  Reply by Vinayakam Mani on 05 February 2024, 12:12
  > Done.

    Reply by Sean Nash on 05 February 2024, 13:28
    > RESOLVED in CODE WALKTHROUGH.


---

ID: HD-DENBUG-162-1 https://devapps.diality.us/cru/HD-DENBUG-162-1

Title: HD-DENBUG-162_Low Venous Pressure Alarm Triggers During Normal Treatment Operation
Statement of Objectives:


State: Closed

Summary: 

Author: Vinayakam Mani
Moderator: Vinayakam Mani
Reviewers: (3 active, 2 completed*)
     Sean Nash   (*)
     Michael Garthwaite   (*)
     jpaguio
     Dara Navaei
     Darren Cox