This is a list of all comments for HD-DENBUG-163-1.

Review Summary: No summary


----------------------------------------
File: firmware/App/Controllers/AirTrap.c
Revision Comment by Sean Nash on 21 February 2024, 13:11 
https://devapps.diality.us/cru/HD-DENBUG-163-1#c19494

  Capitalize first letter of comment.

  Reply by Vinayakam Mani on 21 February 2024, 14:31
  > Done.

    Reply by Sean Nash on 21 February 2024, 14:32
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 02 February 2024, 09:02 
https://devapps.diality.us/cru/HD-DENBUG-163-1#c19379

  Just set the 2 local array variables here outside the loop so
  you don't need the switch statement inside the loop.

  Reply by Vinayakam Mani on 05 February 2024, 16:53
  > Done.

    Reply by Sean Nash on 06 February 2024, 09:42
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 02 February 2024, 08:53 
https://devapps.diality.us/cru/HD-DENBUG-163-1#c19373

  Recommend declaring this as an array here (1 for each sensor)
  so you don't need the switch statement.

  Reply by Vinayakam Mani on 05 February 2024, 16:53
  > Done.

    Reply by Sean Nash on 06 February 2024, 09:39
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 21 February 2024, 13:09 
https://devapps.diality.us/cru/HD-DENBUG-163-1#c19492

  use new get function for raw levels in this condition so that
  raw override is considered.

  Reply by Vinayakam Mani on 21 February 2024, 14:31
  > Done.

    Reply by Sean Nash on 21 February 2024, 14:33
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 02 February 2024, 09:01 
https://devapps.diality.us/cru/HD-DENBUG-163-1#c19378

  Remove space after cast.

  Reply by Vinayakam Mani on 05 February 2024, 16:54
  > Done.

    Reply by Sean Nash on 06 February 2024, 09:40
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 21 February 2024, 13:09 
https://devapps.diality.us/cru/HD-DENBUG-163-1#c19493

  use new get function for raw levels in this assignment so that
  raw override is considered.

  Reply by Vinayakam Mani on 21 February 2024, 14:31
  > Done.

    Reply by Sean Nash on 21 February 2024, 14:33
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 02 February 2024, 09:01 
https://devapps.diality.us/cru/HD-DENBUG-163-1#c19377

  Remove space after cast.

  Reply by Vinayakam Mani on 05 February 2024, 16:54
  > Done.

    Reply by Sean Nash on 06 February 2024, 09:40
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 02 February 2024, 09:00 
https://devapps.diality.us/cru/HD-DENBUG-163-1#c19375

  Should this be an AND (not OR)?

  Reply by Vinayakam Mani on 05 February 2024, 16:54
  > Done.

    Reply by Sean Nash on 06 February 2024, 09:40
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 02 February 2024, 09:00 
https://devapps.diality.us/cru/HD-DENBUG-163-1#c19376

  Do we want to start the 10 second delay when pump is turned on
  or off?

  Reply by Vinayakam Mani on 05 February 2024, 16:54
  > Done.

    Reply by Sean Nash on 06 February 2024, 09:41
    > RESOLVED in CODE WALKTHROUGH.

----------------------------------------
File: firmware/App/Controllers/PresOccl.c
Revision Comment by Sean Nash on 02 February 2024, 09:03 
https://devapps.diality.us/cru/HD-DENBUG-163-1#c19380

  I think the idea was to have a shorter persistence for the high
  venous pressure only.  Low venous pressure would stay at 1
  second as before.

  Reply by Vinayakam Mani on 05 February 2024, 16:54
  > Done.

    Reply by Sean Nash on 06 February 2024, 09:38
    > RESOLVED in CODE WALKTHROUGH.

----------------------------------------
File: firmware/App/Services/AlarmMgmtSWFaults.h
Revision Comment by Sean Nash on 02 February 2024, 09:04 
https://devapps.diality.us/cru/HD-DENBUG-163-1#c19381

  Maybe don't need this if we remove the switch statement.

  Reply by Vinayakam Mani on 05 February 2024, 16:55
  > Done.

    Reply by Sean Nash on 06 February 2024, 09:37
    > RESOLVED in CODE WALKTHROUGH.


---

ID: HD-DENBUG-163-1 https://devapps.diality.us/cru/HD-DENBUG-163-1

Title: HD-DENBUG-163_High Venous Pressure Alarm 130 Triggers During Normal Treatment Operation
Statement of Objectives:


State: Closed

Summary: 

Author: Vinayakam Mani
Moderator: Vinayakam Mani
Reviewers: (3 active, 2 completed*)
     Sean Nash   (*)
     Dara Navaei   (*)
     jpaguio
     Michael Garthwaite
     Darren Cox