This is a list of all comments for HD-DENBUG-290-1.

Review Summary: No summary


----------------------------------------
File: firmware/App/Modes/Dialysis.c
Revision Comment by Sean Nash on 22 January 2025, 09:56 
https://devapps.diality.us/cru/HD-DENBUG-290-1#c21057

  I think "dialysate" should be "dialyzer".

  Reply by Dara Navaei on 22 January 2025, 13:24
  > Done

    Reply by Sean Nash on 29 January 2025, 13:49
    > RESOLVED in CODE WALKTHROUGH.

----------------------------------------
File: firmware/App/Services/AlarmMgmt.c
Revision Comment by Sean Nash on 29 January 2025, 13:51 
https://devapps.diality.us/cru/HD-DENBUG-290-1#c21263

  Why aren't we treating blood leak recovering alarm the same as
  creating dialysate alarm?

  Reply by Dara Navaei on 29 January 2025, 15:46
  > This has been deferred for release 21.

    Reply by Sean Nash on 29 January 2025, 16:32
    > RESOLVED in CODE WALKTHROUGH.

----------------------------------------
File: firmware/App/Modes/ModeInitPOST.c
Revision Comment by Sean Nash on 29 January 2025, 17:05 
https://devapps.diality.us/cru/HD-DENBUG-290-1#c21284

  Not needed.  Remove.

  Reply by Dara Navaei on 29 January 2025, 17:10
  > Done

    Reply by Sean Nash on 29 January 2025, 17:12
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 29 January 2025, 16:30 
https://devapps.diality.us/cru/HD-DENBUG-290-1#c21278

  Why are we doing this here?  And why repeatedly every 500ms?
  Why not just once after NV POST state?

  Reply by Dara Navaei on 29 January 2025, 17:04
  > This is sent only once

    Reply by Sean Nash on 29 January 2025, 17:12
    > RESOLVED in CODE WALKTHROUGH.

----------------------------------------
File: firmware/App/Services/SystemCommMessages.c
Revision Comment by Sean Nash on 29 January 2025, 16:34 
https://devapps.diality.us/cru/HD-DENBUG-290-1#c21280

  Do we not have a serial # type already defined somewhere?  I
  don't like defining types locally within a function.

  Reply by Dara Navaei on 29 January 2025, 16:39
  > Moved it to the top.

    Reply by Sean Nash on 29 January 2025, 17:04
    > RESOLVED in CODE WALKTHROUGH.


---

ID: HD-DENBUG-290-1 https://devapps.diality.us/cru/HD-DENBUG-290-1

Title: HD-DENBUG-290_Blood Leak Alarm During Rinseback Staging
Statement of Objectives:


State: Closed

Summary: 

Author: Dara Navaei
Moderator: Dara Navaei
Reviewers: (2 active, 2 completed*)
     Sean Nash   (*)
     Vinayakam Mani   (*)
     jpaguio
     Michael Garthwaite