HD-UCOMMITS-21 HD Staging Unreviewed Commits

closed on 03 Aug 23

Author

Moderator

Reviewers

HD Staging Unreviewed Commits

Activity

Details
Objectives
General Comments 0
Unresolved
Resolved
Number of files included: 188

common 0
- File AlarmDefs.h 0 Remove
hdfirmware 0
- Folder .launches 0
  - File HD.launch 0 Remove
  - File VCAST_DEBUG.launch 0 Remove
- Folder .settings 0
  - File org.eclipse.core.resources.prefs 0 Remove
- Folder App 0
  - Folder Contollers 0
    - File AlarmLamp.c 0 Remove
    - File AlarmLamp.h 0 Remove
    - File Buttons.c 0 Remove
    - File Buttons.h 0 Remove
    - File SafetyShutdown.c 0 Remove
    - File SafetyShutdown.h 0 Remove
    - File WatchdogMgmt.c 0 Remove
    - File WatchdogMgmt.h 0 Remove
  - Folder Controllers 0
    - File AlarmLamp.c 0 Remove
    - File AlarmLamp.h 0 Remove
    - File Buttons.c 0 Remove
    - File Buttons.h 0 Remove
  - Folder Drivers 0
    - File CPLD.c 0 Remove
    - File CPLD.h 0 Remove
    - File SafetyShutdown.c 0 Remove
    - File SafetyShutdown.h 0 Remove
  - Folder Modes 0
    - File ModeFault.c 0 Remove
    - File ModeFault.h 0 Remove
    - File ModeInitPOST.c 0 Remove
    - File ModeInitPOST.h 0 Remove
    - File ModeOpParams.c 0 Remove
    - File ModeOpParams.h 0 Remove
    - File ModePostTreat.c 0 Remove
    - File ModePostTreat.h 0 Remove
    - File ModePreTreat.c 0 Remove
    - File ModePreTreat.h 0 Remove
    - File ModePrescription.c 0 Remove
    - File ModePrescription.h 0 Remove
    - File ModeService.c 0 Remove
    - File ModeService.h 0 Remove
    - File ModeStandby.c 0 Remove
    - File ModeStandby.h 0 Remove
    - File ModeTreatment.c 0 Remove
    - File ModeTreatment.h 0 Remove
    - File OperationModes.c 0 Remove
    - File OperationModes.h 0 Remove
  - Folder Services 0
    - File CommBuffers.c 0 Remove
    - File CommBuffers.h 0 Remove
    - File CommInterrupts.c 0 Remove
    - File CommInterrupts.h 0 Remove
    - File FPGA.c 0 Remove
    - File FPGA.h 0 Remove
    - File Interrupts.c 0 Remove
    - File Interrupts.h 0 Remove
    - File MsgQueues.c 0 Remove
    - File MsgQueues.h 0 Remove
    - File SafetyShutdown.c 0 Remove
    - File SafetyShutdown.h 0 Remove
    - File SystemComm.c 0 Remove
    - File SystemComm.h 0 Remove
    - File SystemCommMessages.c 0 Remove
    - File SystemCommMessages.h 0 Remove
    - File Timers.c 0 Remove
    - File Timers.h 0 Remove
    - File Utilities.c 0 Remove
    - File Utilities.h 0 Remove
    - File WatchdogMgmt.c 0 Remove
    - File WatchdogMgmt.h 0 Remove
  - Folder Tasks 0
    - File TaskBG.c 0 Remove
    - File TaskBG.h 0 Remove
    - File TaskGeneral.c 0 Remove
    - File TaskGeneral.h 0 Remove
    - File TaskPriority.c 0 Remove
    - File TaskPriority.h 0 Remove
    - File TaskTimer.c 0 Remove
    - File TaskTimer.h 0 Remove
  - File Common.h 0 Remove
  - File TestSupport.h 0 Remove
- Folder Debug 0
  - Folder App 0
    - Folder Contollers 0
      - File subdir_rules.mk 0 Remove
      - File subdir_vars.mk 0 Remove
    - Folder Drivers 0
      - File subdir_rules.mk 0 Remove
    - Folder Modes 0
      - File subdir_rules.mk 0 Remove
    - Folder Tasks 0
      - File subdir_rules.mk 0 Remove
  - Folder source 0
    - File subdir_rules.mk 0 Remove
  - File HD.map 0 Remove
  - File HD.out 0 Remove
  - File HD_linkInfo.xml 0 Remove
  - File ccsObjs.opt 0 Remove
  - File makefile 0 Remove
  - File sources.mk 0 Remove
- Folder firmware 0
  - Folder .launches 0
    - File HD.launch 0 Remove
  - Folder .settings 0
    - File org.eclipse.core.resources.prefs 0 Remove
  - Folder App 0
    - Folder Controllers 0
      - File AirTrap.c 0 Remove
      - File AirTrap.h 0 Remove
      - File AlarmLamp.c 0 Remove
      - File BloodFlow.c 0 Remove
      - File BloodLeak.c 0 Remove
      - File Bubble.c 0 Remove
      - File DGInterface.c 0 Remove
      - File DGInterface.h 0 Remove
      - File DialInFlow.c 0 Remove
      - File DialOutFlow.c 0 Remove
      - File DialOutFlow.h 0 Remove
      - File PresOccl.c 0 Remove
      - File PresOccl.c 0 Remove
      - File PresOccl.h 0 Remove
      - File SyringePump.c 0 Remove
      - File Temperatures.c 0 Remove
      - File Valves.c 0 Remove
      - File Voltages.c 0 Remove
    - Folder Drivers 0
      - File Battery.c 0 Remove
      - File InternalADC.c 0 Remove
      - File SafetyShutdown.c 0 Remove
    - Folder Modes 0
      - File Dialysis.c 0 Remove
      - File ModeFault.c 0 Remove
      - File ModeInitPOST.c 0 Remove
      - File ModePreTreat.c 0 Remove
      - File ModePreTreat.h 0 Remove
      - File ModeStandby.c 0 Remove
      - File ModeTreatment.c 0 Remove
      - File ModeTreatmentParams.c 0 Remove
      - File OperationModes.c 0 Remove
      - File OperationModes.h 0 Remove
      - File Prime.c 0 Remove
      - File Rinseback.c 0 Remove
      - File SelfTests.c 0 Remove
      - File SelfTests.c 0 Remove
      - File TreatmentRecirc.c 0 Remove
      - File TreatmentStop.c 0 Remove
    - Folder Services 0
      - File AlarmMgmt.c 0 Remove
      - File CommBuffers.c 0 Remove
      - File FPGA.c 0 Remove
      - File FPGA.h 0 Remove
      - File Interrupts.c 0 Remove
      - File SystemComm.c 0 Remove
      - File SystemComm.c 0 Remove
      - File SystemCommMessages.c 0 Remove
      - File SystemCommMessages.c 0 Remove
      - File SystemCommMessages.c 0 Remove
      - File SystemCommMessages.h 0 Remove
      - File SystemCommMessages.h 0 Remove
      - File Utilities.c 0 Remove
      - File WatchdogMgmt.c 0 Remove
    - Folder Tasks 0
      - File TaskGeneral.c 0 Remove
      - File TaskPriority.c 0 Remove
      - File TaskTimer.c 0 Remove
    - File Common.h 0 Remove
    - File HDCommon.h 0 Remove
    - File HDCommon.h 0 Remove
    - File HDCommon.h 0 Remove
    - File HDCommon.h 0 Remove
  - Folder Debug 0
    - Folder App 0
      - Folder Drivers 0
        
        File subdir_rules.mk 0 Remove
      - Folder Modes 0
        
        File subdir_rules.mk 0 Remove
      - Folder Tasks 0
        
        File subdir_rules.mk 0 Remove
    - Folder source 0
      - File subdir_rules.mk 0 Remove
  - Folder source 0
    - File sys_startup.c 0 Remove
  - File .cproject 0 Remove
  - File .cproject 0 Remove
  - File .gitignore 0 Remove
- Folder include 0
  - File can.h 0 Remove
  - File lin.h 0 Remove
  - File mibspi.h 0 Remove
  - File rti.h 0 Remove
  - File sci.h 0 Remove
  - File sys_vim.h 0 Remove
  - File system.h 0 Remove
- Folder results 0
  - File Build_Status_Report.csv 0 Remove
  - File Build_Status_Report.csv 0 Remove
  - File Build_Status_Report.csv 0 Remove
  - File StatusReport.csv 0 Remove
  - File StatusReport.csv 0 Remove
  - File VectorCAST.log 0 Remove
  - File VectorCAST.log 0 Remove
  - File VectorCAST.log 0 Remove
  - File cppcheck.log 0 Remove
  - File cppcheckError.csv 0 Remove
  - File cppcheckError.csv 0 Remove
- Folder source 0
  - File can.c 0 Remove
  - File mibspi.c 0 Remove
  - File notification.c 0 Remove
  - File rti.c 0 Remove
  - File sci.c 0 Remove
  - File sys_dma.c 0 Remove
  - File sys_intvecs.asm 0 Remove
  - File sys_main.c 0 Remove
  - File sys_startup.c 0 Remove
  - File sys_vim.c 0 Remove
  - File system.c 0 Remove
- File .cproject 0 Remove
- File .gitignore 0 Remove
- File HD.dil 0 Remove
- File HD.hcg 0 Remove
- File irqDispatch_a.asm 0 Remove
- File irqDispatch_c.c 0 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments
wbracken (deleted user)	Author & Moderator
Dara Navaei	Reviewer - Complete	11m
Sean Nash	Reviewer - Complete	20m
Behrouz NematiPour	Reviewer - 0% reviewed
Total		32m	0

#permalink

Objectives

There are no specific objectives for this review.

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

There are no general comments on this review.

Click to load diff

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: [Crucible Review CR-1\|CR-1]
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

HD-UCOMMITS-21

HD Staging Unreviewed Commits

HD-UCOMMITS-21 0

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time

HD Staging Unreviewed Commits

HD-UCOMMITS-21 0

Summarize the review outcomes (optional)

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time