This is a list of all comments for LEAHI-APPLICATION-LDT-1440-1. Review Summary: No summary General Comment by Stephen Quong on 08 October 2025, 15:57 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-1440-1#c24560 Update TreatmentAdjustmentUltrafiltrationItem to prevent showing subscreens if TreatmentHome is not visible. Reply by Stephen Quong on 09 October 2025, 17:47 > Updated. Reply by Behrouz NematiPour on 10 October 2025, 16:55 > RESOLVED General Comment by Stephen Quong on 08 October 2025, 16:02 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-1440-1#c24561 Remove Start Treatment button from home screen. Reply by Stephen Quong on 09 October 2025, 17:47 > Updated. Reply by Behrouz NematiPour on 10 October 2025, 16:55 > RESOLVED ---------------------------------------- File: sources/gui/qml/components/Slider.qml Revision Comment by Stephen Quong on 25 September 2025, 16:15 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-1440-1#c24455 Verify colors versus denali. Reply by Stephen Quong on 30 September 2025, 13:02 > Colors in denali differ from new leahi design. ---------------------------------------- File: sources/gui/qml/pages/treatment/TreatmentUltrafiltrationItem.qml Revision Comment by Stephen Quong on 06 October 2025, 17:01 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-1440-1#c24524 Add console.log message. Reply by Stephen Quong on 07 October 2025, 10:44 > Updated. Reply by Behrouz NematiPour on 10 October 2025, 16:56 > RESOLVED Revision Comment by Stephen Quong on 06 October 2025, 17:03 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-1440-1#c24525 Remove edit close. Reply by Stephen Quong on 07 October 2025, 10:53 > Updated. Reply by Behrouz NematiPour on 10 October 2025, 16:56 > RESOLVED Revision Comment by Stephen Quong on 06 October 2025, 17:05 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-1440-1#c24526 Close start on confirm to go back to main treatment. Reply by Stephen Quong on 07 October 2025, 10:53 > Updated. Reply by Behrouz NematiPour on 10 October 2025, 16:56 > RESOLVED ---------------------------------------- File: sources/gui/qml/pages/treatment/adjustments/TreatmentAdjustmentUltrafiltrationEdit.qml Revision Comment by Stephen Quong on 01 October 2025, 16:05 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-1440-1#c24507 Prevent slider from going below delivered volume in real-time (bind to value). Reply by Stephen Quong on 08 October 2025, 11:44 > This will be implemented in a subsequent story. Reply by Behrouz NematiPour on 10 October 2025, 16:29 > RESOLVED Revision Comment by Stephen Quong on 06 October 2025, 15:24 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-1440-1#c24519 This value should come from configuration. Reply by Stephen Quong on 08 October 2025, 11:44 > Updated. Reply by Behrouz NematiPour on 10 October 2025, 17:00 > RESOLVED ---------------------------------------- File: sources/gui/qml/pages/treatment/adjustments/TreatmentAdjustmentUltrafiltrationStart.qml Revision Comment by Stephen Quong on 08 October 2025, 16:04 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-1440-1#c24562 Remove pause icon. Reply by Stephen Quong on 09 October 2025, 17:46 > Updated. Reply by Behrouz NematiPour on 10 October 2025, 16:55 > RESOLVED ---------------------------------------- File: sources/gui/qml/pages/treatment/adjustments/TreatmentAdjustmentUltrafiltrationConfirm.qml Revision Comment by Stephen Quong on 06 October 2025, 15:39 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-1440-1#c24521 Use _root. for screen variables to ensure proper context. Reply by Stephen Quong on 08 October 2025, 10:07 > Updated. Reply by Behrouz NematiPour on 10 October 2025, 16:57 > RESOLVED ---------------------------------------- File: sources/model/hd/adjustment/treatment/MTreatmentAdjustRequests.h Revision Comment by Stephen Quong on 08 October 2025, 16:27 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-1440-1#c24565 Remove Box column. Reply by Stephen Quong on 09 October 2025, 09:37 > Updated. Reply by Behrouz NematiPour on 10 October 2025, 16:54 > RESOLVED ---------------------------------------- File: sources/gui/qml/components/ProgressBar.qml Revision Comment by Stephen Quong on 25 September 2025, 15:51 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-1440-1#c24452 Remove radius for progress bars with markers. Reply by Stephen Quong on 26 September 2025, 15:43 > Since radius can be set on this whole ProgressBar component > externally, it is up to the user of this component to set the > radius if there is a marker. > There is not a way internally to definitively enforce that > there is no radius on the progress bar when a marker is > present, if a radius is set manually externally. > > Also, leaving this binding to the parent radius so that the > radius of the inner fill will match the radius of the outer > progress bar. Reply by Behrouz NematiPour on 10 October 2025, 16:09 > RESOLVED ---------------------------------------- File: sources/gui/qml/components/StoppedSlider.qml Revision Comment by Stephen Quong on 25 September 2025, 16:24 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-1440-1#c24456 Check if previous UF slider can be reused. Reply by Stephen Quong on 30 September 2025, 11:54 > Previous implementation used two separate components > (ProgressBarEx and Slider) that are visually separated for > adjusting UF volume, so the previous components and > implementation cannot be used for the new design. Reply by Behrouz NematiPour on 10 October 2025, 16:23 > RESOLVED Revision Comment by Nicholas Ramirez on 29 September 2025, 16:16 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-1440-1#c24486 StoppedSlider.qml Reply by Stephen Quong on 30 September 2025, 13:01 > Fixed Reply by Nicholas Ramirez on 30 September 2025, 13:04 > RESOLVED ---------------------------------------- File: sources/gui/qml/pages/treatment/adjustments/TreatmentAdjustmentBase.qml Revision Comment by Stephen Quong on 09 October 2025, 10:53 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-1440-1#c24579 Verify image size. Reply by Stephen Quong on 09 October 2025, 10:53 > Verified image is square. Image is being used in multiple > places, so leaving image as is. Reply by Behrouz NematiPour on 10 October 2025, 16:27 > RESOLVED ---------------------------------------- File: sources/gui/qml/pages/treatment/adjustments/TreatmentAdjustmentUltrafiltrationMetrics.qml Revision Comment by Stephen Quong on 06 October 2025, 15:45 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-1440-1#c24522 Remove and hard code offset. Reply by Stephen Quong on 08 October 2025, 09:56 > Updated. Reply by Behrouz NematiPour on 10 October 2025, 16:57 > RESOLVED ---------------------------------------- File: leahi.qrc Revision Comment by Nicholas Ramirez on 29 September 2025, 16:14 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-1440-1#c24485 can you revert removing /HeaderBarPopup.qml and AlarmButtonRow.qml Reply by Stephen Quong on 30 September 2025, 14:24 > These files don't exist in my branch and these lines will be > added in when this branch is merged. Reply by Nicholas Ramirez on 30 September 2025, 14:25 > RESOLVED ---------------------------------------- File: sources/gui/qml/components/ProgressBarEx.qml Revision Comment by Stephen Quong on 25 September 2025, 15:52 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-1440-1#c24453 Remove radius for progress bars with markers. Reply by Stephen Quong on 29 September 2025, 09:54 > Keeping this binding to the radius of the outer progress bar > so that the overlay matches the style of the outer container. Reply by Behrouz NematiPour on 10 October 2025, 16:10 > RESOLVED ---------------------------------------- File: sources/gui/qml/components/RangeMarker.qml Revision Comment by Stephen Quong on 25 September 2025, 15:56 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-1440-1#c24454 Verify label position above lollipop. Reply by Stephen Quong on 08 October 2025, 11:46 > Verified that placement is correct. Reply by Behrouz NematiPour on 10 October 2025, 16:10 > RESOLVED ---------------------------------------- File: SDDs/TreatmentAdjustmentUltrafiltration.png Revision Comment by Stephen Quong on 01 October 2025, 16:07 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-1440-1#c24508 Change enums to actual value. Reply by Stephen Quong on 07 October 2025, 10:54 > Updated. Revision Comment by Stephen Quong on 01 October 2025, 16:08 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-1440-1#c24509 Change TCH: Ultrafiltration Edit Button to TCH: Ultrafiltration Section Adjustment Button. Reply by Stephen Quong on 07 October 2025, 10:54 > Updated. Revision Comment by Stephen Quong on 01 October 2025, 16:09 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-1440-1#c24510 Point ACT: Open Adjust Ultrafiltration Start back to User. Reply by Stephen Quong on 07 October 2025, 11:04 > Updated. Revision Comment by Stephen Quong on 01 October 2025, 16:10 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-1440-1#c24511 Expand alt/rejected to cover entire message path. Reply by Stephen Quong on 07 October 2025, 10:54 > Updated. Revision Comment by Stephen Quong on 01 October 2025, 16:14 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-1440-1#c24512 Ask Caryn/Nick if it is possible to leave UF adjustment with UF paused or user must resume before closing dialog. Reply by Stephen Quong on 07 October 2025, 10:54 > Verified that UF is automatically restarted when user > confirms adjusted UF volume. > Updated to close UF adjustment and return to main treatment > upon acknowledgment of successful confirm. Revision Comment by Stephen Quong on 01 October 2025, 16:16 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-1440-1#c24513 Add first section for UF adjustment dialog open. Reply by Stephen Quong on 07 October 2025, 10:56 > Updated. Revision Comment by Stephen Quong on 01 October 2025, 16:20 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-1440-1#c24514 Add mention for UF Start screen states (paused/resumed). Reply by Stephen Quong on 07 October 2025, 10:56 > Updated. Reply by Behrouz NematiPour on 10 October 2025, 17:00 > RESOLVED ---------------------------------------- File: sources/gui/qml/compounds/LabelUnitContainer.qml Revision Comment by Stephen Quong on 08 October 2025, 16:06 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-1440-1#c24563 Remove file from branch. Reply by Stephen Quong on 09 October 2025, 11:25 > Updated. Reply by Behrouz NematiPour on 10 October 2025, 16:24 > RESOLVED ---------------------------------------- File: sources/view/hd/data/VTreatmentRanges.cpp Revision Comment by Stephen Quong on 08 October 2025, 16:31 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-1440-1#c24566 Add comments for all if Def, Min, Max, or Res is intentionally missing. Reference DataList.conf. Reply by Stephen Quong on 09 October 2025, 09:27 > Updated. Reply by Behrouz NematiPour on 10 October 2025, 16:54 > RESOLVED ---------------------------------------- File: sources/view/hd/data/VTreatmentRanges.h Revision Comment by Stephen Quong on 08 October 2025, 16:34 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-1440-1#c24567 Change from READONLY to RANGESET and change ultrafiltrationVolumeRes to ultrafiltratoinVolume. Reply by Stephen Quong on 09 October 2025, 09:27 > Updated. Reply by Behrouz NematiPour on 10 October 2025, 16:54 > RESOLVED ---------------------------------------- File: sources/gui/qml/components/NotificationBarSmall.qml Revision Comment by Nicholas Ramirez on 08 October 2025, 15:37 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-1440-1#c24559 Only expose property of component, not whole component. Reply by Stephen Quong on 09 October 2025, 11:20 > Updated. Reply by Behrouz NematiPour on 10 October 2025, 16:56 > RESOLVED --- ID: LEAHI-APPLICATION-LDT-1440-1 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-1440-1 Title: LDT-1440 - Ultrafiltration - R&I [Application] Statement of Objectives: State: Closed Summary: Author: Stephen Quong Moderator: Stephen Quong Reviewers: (4 active, 2 completed*) Nicholas Ramirez (*) Behrouz NematiPour (*) Tiffany Mejia Dara Navaei Vendor - TEL - Sivvanarayana Kurapati Daniel Ho