LEAHI-APPLICATION-LDT-275-5 LEAHI-APPLICATION-LDT-275_Feature/Ldt 275 Main Treatment Screen Swfw Initial Integration

closed on 28 Apr

Author

Moderator

Reviewers

LEAHI-APPLICATION-LDT-275_Feature/Ldt 275 Main Treatment Screen Swfw Initial...

Activity

Details
Objectives
General Comments 0
Unresolved
Resolved
Number of files included: 190

leahi-application 0
- Folder etc/reports 0
  - Folder alarms 0
    - File AlarmMapping.csv 0 Remove
    - File AlarmMapping.py 0 Remove
  - Folder cppcheck 0
    - File cppcheck.err 0 Remove
    - File cppcheck.log 0 Remove
- Folder sources 0
  - Folder bluetooth 0
    - File BluetoothInterface.cpp 0 Remove
  - Folder canbus 0
    - File CanInterface.cpp 0 Remove
    - File FrameInterface.cpp 0 Remove
    - File MessageAcknowModel.cpp 0 Remove
    - File MessageBuilder.cpp 0 Remove
    - File MessageDispatcher.cpp 0 Remove
    - File MessageDispatcher.h 0 Remove
    - File MessageGlobals.h 0 Remove
    - File MessageInterpreter.cpp 0 Remove
  - Folder cloudsync 0
    - File CloudSyncController.cpp 0 Remove
  - Folder device 0
    - File DeviceController.cpp 0 Remove
  - Folder gui 0
    - Folder qml 0
      - Folder components 0
        
        File MainMenu.qml 0 Remove
      - Folder globals 0
        
        File Colors.qml 0 Remove
        
        File Variables.qml 0 Remove
      - Folder pages 0
        
        Folder settings 0
        
        File SettingsHome.qml 0 Remove
        
        File MainHome.qml 0 Remove
        
        File ManagerStack.qml 0 Remove
      - File AlarmItem.qml 0 Remove
      - File main.qml 0 Remove
    - File GuiController.cpp 0 Remove
    - File GuiController.h 0 Remove
    - File GuiGlobals.cpp 0 Remove
    - File GuiGlobals.h 0 Remove
    - File GuiView.cpp 0 Remove
    - File GuiView.h 0 Remove
  - Folder model 0
    - Folder confirm 0
      - File MDuetConfirmHDi.h 0 Remove
    - Folder dg 0
      - Folder adjustment/settings 0
        
        File MAdjustDGCleaningUsageResponse.h 0 Remove
        
        File MAdjustDGDateTimeResponse.h 0 Remove
        
        File MAdjustDGRequests.h 0 Remove
        
        File MAdjustDGSerialNumberResponse.h 0 Remove
        
        File MAdjustDGServiceDatesResponse.h 0 Remove
        
        File MAdjustDGVersionsResponse.h 0 Remove
        
        File MDuetRoWaterDG.h 0 Remove
      - Folder data 0
        
        Folder post 0
        
        File MDGPostFinalResultData.h 0 Remove
        
        File MDGPostSingleResultData.h 0 Remove
        
        Folder pretreatment 0
        
        File MDGFilterFlushData.h 0 Remove
        
        File MDGAccelerometerData.cpp 0 Remove
        
        File MDGAccelerometerData.h 0 Remove
        
        File MDGConductivityData.h 0 Remove
        
        File MDGDebugText.h 0 Remove
        
        File MDGDrainPumpData.h 0 Remove
        
        File MDGGeneralEvent.h 0 Remove
        
        File MDGHeatersData.h 0 Remove
        
        File MDGLoadCellReadingsData.h 0 Remove
        
        File MDGOperationModeData.h 0 Remove
        
        File MDGPressuresData.h 0 Remove
        
        File MDGROPumpData.h 0 Remove
        
        File MDGReservoirData.h 0 Remove
        
        File MDGTemperaturesData.h 0 Remove
        
        File MDGValvesStatesData.h 0 Remove
    - Folder hd 0
      - Folder adjustment 0
        
        Folder disinfect 0
        
        File MDisinfectAdjustModeResponse.h 0 Remove
        
        File MDisinfectAdjustStartRequests.h 0 Remove
        
        File MDisinfectAdjustStartResponse.h 0 Remove
        
        Folder posttreatment 0
        
        File MPostTreatmentAdjustDisposablesRemovalConfirmResponse.h 0 Remove
        
        File MPostTreatmentAdjustPatientDisconnectionConfirmResponse.h 0 Remove
        
        File MPostTreatmentAdjustTreatmentLogResponse.h 0 Remove
        
        Folder pretreatment 0
        
        File MPreTreatmentAdjustDisposablesConfirmResponse.h 0 Remove
        
        File MPreTreatmentAdjustDisposablesPrimeResponse.h 0 Remove
        
        File MPreTreatmentAdjustInitTreatmentResponse.h 0 Remove
        
        File MPreTreatmentAdjustParametersValidationResponse.h 0 Remove
        
        File MPreTreatmentAdjustPatientConnectionBeginResponse.h 0 Remove
        
        File MPreTreatmentAdjustPatientConnectionConfirmResponse.h 0 Remove
        
        File MPreTreatmentAdjustRequests.h 0 Remove
        
        File MPreTreatmentAdjustStartTreatmentResponse.h 0 Remove
        
        File MPreTreatmentAdjustUltrafiltrationInitResponse.h 0 Remove
        
        File MPreTreatmentAdjustWaterSampleResponse.h 0 Remove
        
        Folder settings 0
        
        File MAdjustHDAlarmVolumeResponse.h 0 Remove
        
        File MAdjustHDDateTimeResponse.h 0 Remove
        
        File MAdjustHDInstitutionalRecordResponse.h 0 Remove
        
        File MAdjustHDRequests.h 0 Remove
        
        File MAdjustHDSerialNumberResponse.h 0 Remove
        
        File MAdjustHDServiceDatesResponse.h 0 Remove
        
        File MAdjustHDServiceModeResponse.h 0 Remove
        
        File MAdjustHDVersionsRequest.h 0 Remove
        
        File MAdjustHDVersionsResponse.h 0 Remove
        
        Folder treatment 0
        
        File MTreatmentAdjustBloodDialysateResponse.h 0 Remove
        
        File MTreatmentAdjustDurationResponse.h 0 Remove
        
        File MTreatmentAdjustEndResponse.h 0 Remove
        
        File MTreatmentAdjustHeparinResponse.h 0 Remove
        
        File MTreatmentAdjustPressuresLimitsResponse.h 0 Remove
        
        File MTreatmentAdjustRecirculateResponse.h 0 Remove
        
        File MTreatmentAdjustRequests.h 0 Remove
        
        File MTreatmentAdjustRinsebackResponse.h 0 Remove
        
        File MTreatmentAdjustSalineResponse.h 0 Remove
        
        File MTreatmentAdjustUltrafiltrationStateResponse.h 0 Remove
        
        File MAdjustPowerOff.h 0 Remove
        
        File MAdjustRequestsBase.h 0 Remove
      - Folder alarm 0
        
        File MAlarmActiveList.h 0 Remove
        
        File MAlarmCleared.h 0 Remove
        
        File MAlarmClearedCondition.cpp 0 Remove
        
        File MAlarmClearedCondition.h 0 Remove
        
        File MAlarmMapping.cpp 0 Remove
        
        File MAlarmStatusData.h 0 Remove
        
        File MAlarmTriggered.h 0 Remove
      - Folder data 0
        
        Folder post 0
        
        File MHDPostFinalResultData.h 0 Remove
        
        File MHDPostSingleResultData.h 0 Remove
        
        File MHDRTCEpochData.h 0 Remove
        
        File MUIPostFinalResultHDRequest.h 0 Remove
        
        Folder posttreatment 0
        
        File MPostTreatmentStatesData.h 0 Remove
        
        Folder pretreatment 0
        
        File MPreTreatmentDisposablesPrimeData.h 0 Remove
        
        File MPreTreatmentSelfTestDryData.h 0 Remove
        
        File MPreTreatmentSelfTestNoCartridgeData.h 0 Remove
        
        File MPreTreatmentStatesData.h 0 Remove
        
        Folder treatment 0
        
        File MTreatmentBloodFlowData.h 0 Remove
        
        File MTreatmentBloodPrimeData.h 0 Remove
        
        File MTreatmentDialysateFlowData.h 0 Remove
        
        File MTreatmentHeparinData.h 0 Remove
        
        File MTreatmentOutletFlowData.h 0 Remove
        
        File MTreatmentPressureOcclusionData.h 0 Remove
        
        File MTreatmentRecirculateData.h 0 Remove
        
        File MTreatmentRinsebackData.h 0 Remove
        
        File MTreatmentSalineData.h 0 Remove
        
        File MTreatmentStatesData.h 0 Remove
        
        File MTreatmentStopData.h 0 Remove
        
        File MTreatmentTimeData.h 0 Remove
        
        Folder treatmentlog 0
        
        File MTreatmentLogAlarmData.h 0 Remove
        
        File MTreatmentLogAvrgeData.h 0 Remove
        
        File MTreatmentLogEventData.h 0 Remove
        
        File MHDAccelerometerData.cpp 0 Remove
        
        File MHDAccelerometerData.h 0 Remove
        
        File MHDAirBubbleData.h 0 Remove
        
        File MHDAirTrapData.h 0 Remove
        
        File MHDBloodLeakData.h 0 Remove
        
        File MHDDebugText.h 0 Remove
        
        File MHDGeneralEvent.h 0 Remove
        
        File MHDOperationModeData.h 0 Remove
        
        File MHDSyringePumpData.h 0 Remove
        
        File MHDUsageInfoResponse.h 0 Remove
        
        File MTreatmentRangesData.h 0 Remove
    - File MAbstract.h 0 Remove
    - File MModel.h 0 Remove
  - Folder storage 0
    - File FileHandler.cpp 0 Remove
    - File Logger.cpp 0 Remove
  - Folder view 0
    - Folder confirm 0
      - File VConfirm.h 0 Remove
    - Folder dg/data 0
      - Folder post 0
        
        File VDGPOSTData.h 0 Remove
      - File VDGAccelerometerData.cpp 0 Remove
      - File VDGAccelerometerData.h 0 Remove
    - Folder hd 0
      - Folder adjustment 0
        
        Folder common 0
        
        File VCommonAdjustmentVitals.h 0 Remove
        
        Folder posttreatment 0
        
        File VPostTreatmentAdjustDisposablesRemovalConfirm.h 0 Remove
        
        File VPostTreatmentAdjustPatientDisconnectionConfirm.h 0 Remove
        
        File VPostTreatmentAdjustTreatmentLog.h 0 Remove
        
        Folder pretreatment 0
        
        File VPreTreatmentAdjustmentConsumablesConfirm.h 0 Remove
        
        File VPreTreatmentAdjustmentDisposablesConfirm.h 0 Remove
        
        File VPreTreatmentAdjustmentDisposablesPrime.h 0 Remove
        
        File VPreTreatmentAdjustmentInitTreatment.h 0 Remove
        
        File VPreTreatmentAdjustmentPatientConnectionBegin.h 0 Remove
        
        File VPreTreatmentAdjustmentPatientConnectionConfirm.h 0 Remove
        
        File VPreTreatmentAdjustmentStartTreatment.h 0 Remove
        
        File VPreTreatmentAdjustmentUltrafiltrationInit.h 0 Remove
        
        File VPreTreatmentAdjustmentWaterSample.h 0 Remove
        
        Folder treatment 0
        
        File VTreatmentAdjustmentDuration.h 0 Remove
        
        File VTreatmentAdjustmentEnd.h 0 Remove
        
        File VTreatmentAdjustmentFlows.h 0 Remove
        
        File VTreatmentAdjustmentHeparin.h 0 Remove
        
        File VTreatmentAdjustmentRecirculate.h 0 Remove
        
        File VTreatmentAdjustmentRinseback.h 0 Remove
        
        File VTreatmentAdjustmentSaline.h 0 Remove
        
        File VTreatmentAdjustmentUltrafiltrationConfirm.h 0 Remove
        
        File VTreatmentAdjustmentUltrafiltrationEdit.h 0 Remove
        
        File VTreatmentAdjustmentUltrafiltrationState.cpp 0 Remove
        
        File VTreatmentAdjustmentUltrafiltrationState.h 0 Remove
      - Folder alarm 0
        
        File VAlarmActiveList.h 0 Remove
        
        File VAlarmStatus.cpp 0 Remove
        
        File VAlarmStatus.h 0 Remove
      - Folder data 0
        
        Folder post 0
        
        File VHDPOSTData.h 0 Remove
        
        Folder treatment 0
        
        File VHDTreatmentStatesData.cpp 0 Remove
        
        File VHDTreatmentStatesData.h 0 Remove
        
        File VTreatmentUltrafiltration.h 0 Remove
        
        File VHDAccelerometerData.cpp 0 Remove
        
        File VHDAccelerometerData.h 0 Remove
    - Folder settings 0
      - File VAdjustmentAlarmVolume.h 0 Remove
      - File VAdjustmentInstitutionalRecord.h 0 Remove
      - File VAdjustmentServiceDates.h 0 Remove
      - File VAdjustmentServiceMode.h 0 Remove
      - File VAdjustmentVersions.h 0 Remove
      - File VDateTime.cpp 0 Remove
      - File VHDUsageInfo.h 0 Remove
    - File VAdjustmentResponseBase.h 0 Remove
    - File VEventSpy.cpp 0 Remove
    - File VEventSpy.h 0 Remove
  - File ApplicationController.cpp 0 Remove
  - File ApplicationController.h 0 Remove
  - File MainTimer.cpp 0 Remove
  - File Threads.cpp 0 Remove
- File leahi.pro 0 Remove
- File leahi.pro.user 0 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments
Behrouz NematiPour	Author & Moderator	15m
Sean Nash	Reviewer - 0% reviewed
Michael Garthwaite	Reviewer - 0% reviewed
Dara Navaei	Reviewer - Complete	22m
Tiffany Mejia	Reviewer - Complete	21m
Daniel Ho	Reviewer - 0% reviewed
Vinayakam Mani	Reviewer - 0% reviewed
Total		59m	0

#permalink

Objectives

There are no specific objectives for this review.

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

There are no general comments on this review.

Click to load diff

/sources/.../alarm/MAlarmClearedCondition.cpp Deleted

Click to load diff

/sources/.../alarm/MAlarmClearedCondition.h Deleted

Click to load diff

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: [Crucible Review CR-1\|CR-1]
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

LEAHI-APPLICATION-LDT-275-5

LEAHI-APPLICATION-LDT-275_Feature/Ldt 275 Main Treatment Screen Swfw Initial...

LEAHI-APPLICATION-LDT-275-5 0

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time

LEAHI-APPLICATION-LDT-275_Feature/Ldt 275 Main Treatment Screen Swfw Initial...

LEAHI-APPLICATION-LDT-275-5 0

Summarize the review outcomes (optional)

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time