This is a list of all comments for LEAHI-APPLICATION-LDT-450-1. Review Summary: No summary ---------------------------------------- File: sources/canbus/MessageInterpreter.cpp Revision Comment by Nicholas Ramirez on 09 June 2025, 15:50 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-450-1#c22172 remove commented out line? Reply by Behrouz NematiPour on 09 June 2025, 16:09 > This code is still in the early stage of development, and the > debug codes are helpful to keep. Reply by Behrouz NematiPour on 12 June 2025, 10:52 > RESOLVED ---------------------------------------- File: sources/gui/qml/main.qml Revision Comment by Nicholas Ramirez on 09 June 2025, 15:53 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-450-1#c22174 missing id and object name properties Reply by Behrouz NematiPour on 09 June 2025, 16:05 > To ensure that specific components are not referenced > anywhere, I do not assign an ID to them. > As for the name, however, we'll ensure that it is only added > if it needs to be included in the SquishQt integration test. Reply by Behrouz NematiPour on 12 June 2025, 10:51 > RESOLVED ---------------------------------------- File: sources/gui/qml/KeyboardItem.qml Revision Comment by Nicholas Ramirez on 09 June 2025, 15:52 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-450-1#c22173 remove space after '!' Reply by Behrouz NematiPour on 09 June 2025, 16:02 > To make the ! more visible, I always try to put a space > between the ! and the surrounding text (not to be confused or > misread with i,l,|). Reply by Behrouz NematiPour on 12 June 2025, 10:51 > RESOLVED ---------------------------------------- File: sources/gui/qml/pages/settings/SettingsDeviceRegistration.qml Revision Comment by Nicholas Ramirez on 09 June 2025, 15:45 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-450-1#c22171 remove spacing after vAdjustmentVersions.. same goes for the other times vAdjustmentVersions is being called in this file Reply by Behrouz NematiPour on 09 June 2025, 16:05 > This type of spacing is used in the SW/UI to facilitate the > use of vertical selection and vertical alignment. Reply by Behrouz NematiPour on 12 June 2025, 10:51 > RESOLVED --- ID: LEAHI-APPLICATION-LDT-450-1 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-450-1 Title: Feature/LDT-450-CreateRx - Application & Dialin Statement of Objectives: State: Closed Summary: Author: Behrouz NematiPour Moderator: Behrouz NematiPour Reviewers: (6 active, 2 completed*) Nicholas Ramirez (*) Dara Navaei (*) Sean Nash Tiffany Mejia jpaguio Vinayakam Mani Michael Garthwaite Daniel Ho