LEAHI-APPLICATION-LDT-627-1 LDT-627 - Main Treatment Screen SW - Messaging Broadcast - Application & Dialin

closed on 08 Jul

Author

Moderator

Reviewers

LDT-627 - Main Treatment Screen SW - Messaging Broadcast - Application & Dialin

Activity

Details
Objectives
General Comments 0
Unresolved
Resolved
Number of files included: 234

leahi-application 0
- Folder SDDs 0
  - File MainTreatmentScreen.puml 0 Remove
- Folder etc/reports/alarms 0
  - File AlarmMapping.csv 0 Remove
  - File AlarmMapping.py 0 Remove
- Folder sources 0
  - Folder canbus 0
    - File MessageGlobals.h 3 Remove
    - File MessageInterpreter.cpp 0 Remove
  - Folder gui 0
    - Folder qml 0
      - Folder components 0
        
        File DebugDataColumn.qml 0 Remove
      - Folder dialogs 0
        
        File DiagnosticsDialog.qml 11 Remove
      - Folder globals 0
        
        File Fonts.qml 0 Remove
      - Folder pages 0
        
        Folder endtreatment 0
        
        Folder rinseback 0
        
        File EndTreatmentRinseback.qml 0 Remove
        
        File EndTreatmentEndStack.qml 0 Remove
        
        File EndTreatmentRecirculateStack.qml 0 Remove
        
        File EndTreatmentRinsebackStack.qml 0 Remove
        
        Folder settings 0
        
        File SettingsInformation.qml 0 Remove
        
        Folder treatment 0
        
        Folder adjustments 0
        
        File TreatmentAdjustmentUltrafiltrationEdit.qml 0 Remove
        
        File TreatmentAdjustmentUltrafiltrationPaused.qml 0 Remove
        
        File TreatmentAdjustmentUltrafiltrationStart.qml 0 Remove
        
        Folder sections 0
        
        File TreatmentHeparin.qml 0 Remove
        
        File TreatmentPressures.qml 0 Remove
        
        File TreatmentSaline.qml 0 Remove
        
        File TreatmentTime.qml 0 Remove
        
        File TreatmentUltrafiltration.qml 4 Remove
        
        File TreatmentBloodPrime.qml 0 Remove
        
        File TreatmentStack.qml 0 Remove
        
        File TreatmentUltrafiltrationItem.qml 0 Remove
        
        File MainStack.qml 0 Remove
      - File AlarmItem.qml 0 Remove
      - File main.qml 0 Remove
    - File GuiGlobals.cpp 0 Remove
    - File GuiGlobals.h 3 Remove
  - Folder model 0
    - Folder dd 0
      - Folder adjustment/settings 0
        
        File MAdjustDDSerialNumberResponse.cpp 0 Remove
        
        File MAdjustDDSerialNumberResponse.h 0 Remove
        
        File MAdjustDDVersionsResponse.cpp 3 Remove
        
        File MAdjustDDVersionsResponse.h 9 Remove
      - Folder data 0
        
        File MDDConductivityData.cpp 0 Remove
        
        File MDDConductivityData.h 0 Remove
        
        File MDDGenDialysateData.cpp 0 Remove
        
        File MDDGenDialysateData.h 6 Remove
    - Folder dg 0
      - Folder adjustment/settings 0
        
        File MAdjustDDSerialNumberResponse.cpp 0 Remove
        
        File MAdjustDDSerialNumberResponse.h 0 Remove
        
        File MAdjustDDVersionsResponse.cpp 0 Remove
        
        File MAdjustDDVersionsResponse.h 0 Remove
      - Folder data 0
        
        File MDDConductivityData.cpp 0 Remove
        
        File MDDConductivityData.h 0 Remove
        
        File MDDGenDialysateData.cpp 0 Remove
        
        File MDDGenDialysateData.h 0 Remove
        
        File MDGConductivityData.cpp 0 Remove
        
        File MDGConductivityData.h 0 Remove
    - Folder hd 0
      - Folder adjustment/settings 0
        
        File MAdjustTDSerialNumberResponse.cpp 0 Remove
        
        File MAdjustTDSerialNumberResponse.h 0 Remove
        
        File MAdjustTDVersionsRequest.cpp 0 Remove
        
        File MAdjustTDVersionsRequest.h 0 Remove
        
        File MAdjustTDVersionsResponse.cpp 0 Remove
        
        File MAdjustTDVersionsResponse.h 0 Remove
      - Folder alarm 0
        
        File MAlarmMapping.cpp 0 Remove
      - Folder data 0
        
        Folder treatment 0
        
        File MTreatmentBloodFlowData.cpp 0 Remove
        
        File MTreatmentBloodFlowData.h 0 Remove
        
        File MTreatmentPressureOcclusionData.cpp 0 Remove
        
        File MTreatmentPressureOcclusionData.h 0 Remove
        
        File MTreatmentSalineData.cpp 0 Remove
        
        File MTreatmentSalineData.h 0 Remove
        
        File MTreatmentSetPointData.cpp 0 Remove
        
        File MTreatmentSetPointData.h 0 Remove
        
        File MTreatmentStatesData.cpp 0 Remove
        
        File MTreatmentStatesData.h 0 Remove
        
        File MTreatmentTimeData.cpp 0 Remove
        
        File MTreatmentTimeData.h 0 Remove
        
        File MTreatmentUltrafiltrationData.cpp 0 Remove
        
        File MTreatmentUltrafiltrationData.h 0 Remove
        
        File MTDAirTrapData.cpp 0 Remove
        
        File MTDAirTrapData.h 0 Remove
        
        File MTDBatteryData.cpp 0 Remove
        
        File MTDBatteryData.h 0 Remove
        
        File MTDBloodPumpData.cpp 0 Remove
        
        File MTDBloodPumpData.h 0 Remove
        
        File MTDEjectorData.cpp 0 Remove
        
        File MTDEjectorData.h 0 Remove
        
        File MTDSwitchesData.cpp 0 Remove
        
        File MTDSwitchesData.h 0 Remove
        
        File MTDTemperatureData.cpp 0 Remove
        
        File MTDTemperatureData.h 0 Remove
        
        File MTDValvesData.cpp 0 Remove
        
        File MTDValvesData.h 0 Remove
        
        File MTDValvesDatacpp 0 Remove
        
        File MTDVoltageData.cpp 0 Remove
        
        File MTDVoltageData.h 0 Remove
    - Folder td 0
      - Folder adjustment/settings 0
        
        File MAdjustTDSerialNumberResponse.cpp 0 Remove
        
        File MAdjustTDSerialNumberResponse.h 0 Remove
        
        File MAdjustTDVersionsRequest.cpp 0 Remove
        
        File MAdjustTDVersionsRequest.h 0 Remove
        
        File MAdjustTDVersionsResponse.cpp 0 Remove
        
        File MAdjustTDVersionsResponse.h 3 Remove
      - Folder data 0
        
        Folder treatment 0
        
        File MTreatmentBloodFlowData.cpp 0 Remove
        
        File MTreatmentBloodFlowData.h 9 Remove
        
        File MTreatmentPressureOcclusionData.cpp 0 Remove
        
        File MTreatmentPressureOcclusionData.h 3 Remove
        
        File MTreatmentSalineData.cpp 0 Remove
        
        File MTreatmentSalineData.h 0 Remove
        
        File MTreatmentSetPointData.cpp 0 Remove
        
        File MTreatmentSetPointData.h 0 Remove
        
        File MTreatmentStatesData.cpp 0 Remove
        
        File MTreatmentStatesData.h 0 Remove
        
        File MTreatmentTimeData.cpp 0 Remove
        
        File MTreatmentTimeData.h 0 Remove
        
        File MTreatmentUltrafiltrationData.cpp 0 Remove
        
        File MTreatmentUltrafiltrationData.h 0 Remove
        
        File MTDAirTrapData.cpp 0 Remove
        
        File MTDAirTrapData.h 0 Remove
        
        File MTDBatteryData.cpp 3 Remove
        
        File MTDBatteryData.h 0 Remove
        
        File MTDEjectorData.cpp 0 Remove
        
        File MTDEjectorData.h 0 Remove
        
        File MTDSwitchesData.cpp 0 Remove
        
        File MTDSwitchesData.h 3 Remove
        
        File MTDTemperatureData.cpp 0 Remove
        
        File MTDTemperatureData.h 0 Remove
        
        File MTDValvesData.cpp 0 Remove
        
        File MTDValvesData.h 0 Remove
        
        File MTDVoltageData.cpp 0 Remove
        
        File MTDVoltageData.h 3 Remove
    - File MModel.h 0 Remove
  - Folder view 0
    - Folder dd/data 0
      - File VDDConductivityData.cpp 0 Remove
      - File VDDConductivityData.h 0 Remove
      - File VDDGenDialysateData.cpp 0 Remove
      - File VDDGenDialysateData.h 3 Remove
    - Folder dg/data 0
      - File VDDConductivityData.cpp 0 Remove
      - File VDDConductivityData.h 0 Remove
      - File VDDGenDialysateData.cpp 0 Remove
      - File VDDGenDialysateData.h 0 Remove
    - Folder hd/data 0
      - Folder pretreatment 0
        
        File VPreTreatmentStatesData.cpp 0 Remove
      - Folder treatment 0
        
        File VHDTreatmentStatesData.cpp 0 Remove
        
        File VHDTreatmentStatesData.h 0 Remove
        
        File VTreatmentBloodFlow.cpp 0 Remove
        
        File VTreatmentBloodFlow.h 0 Remove
        
        File VTreatmentPressureOcclusion.cpp 0 Remove
        
        File VTreatmentPressureOcclusion.h 0 Remove
        
        File VTreatmentSalineData.cpp 0 Remove
        
        File VTreatmentSalineData.h 0 Remove
        
        File VTreatmentSetPointData.cpp 0 Remove
        
        File VTreatmentSetPointData.h 0 Remove
        
        File VTreatmentTime.cpp 0 Remove
        
        File VTreatmentTime.h 0 Remove
        
        File VTreatmentUltrafiltration.cpp 0 Remove
        
        File VTreatmentUltrafiltration.h 0 Remove
        
        File VTreatmentUltrafiltrationData.cpp 0 Remove
        
        File VTreatmentUltrafiltrationData.h 0 Remove
      - File VTDAirTrapData.cpp 0 Remove
      - File VTDAirTrapData.h 0 Remove
      - File VTDBatteryData.cpp 0 Remove
      - File VTDBatteryData.h 0 Remove
      - File VTDBloodPumpData.cpp 0 Remove
      - File VTDBloodPumpData.h 0 Remove
      - File VTDEjectorData.cpp 0 Remove
      - File VTDEjectorData.h 0 Remove
      - File VTDSwitchesData.cpp 0 Remove
      - File VTDSwitchesData.h 0 Remove
      - File VTDTemperatureData.cpp 0 Remove
      - File VTDTemperatureData.h 0 Remove
      - File VTDValvesData.cpp 0 Remove
      - File VTDValvesData.h 0 Remove
      - File VTDVoltageData.cpp 0 Remove
      - File VTDVoltageData.h 0 Remove
    - Folder td/data 0
      - Folder treatment 0
        
        File VTDTreatmentStatesData.cpp 0 Remove
        
        File VTDTreatmentStatesData.h 0 Remove
        
        File VTreatmentBloodFlow.cpp 0 Remove
        
        File VTreatmentBloodFlow.h 2 Remove
        
        File VTreatmentPressureOcclusion.cpp 0 Remove
        
        File VTreatmentPressureOcclusion.h 0 Remove
        
        File VTreatmentSalineData.cpp 0 Remove
        
        File VTreatmentSalineData.h 0 Remove
        
        File VTreatmentSetPointData.cpp 0 Remove
        
        File VTreatmentSetPointData.h 0 Remove
        
        File VTreatmentTime.cpp 0 Remove
        
        File VTreatmentTime.h 0 Remove
        
        File VTreatmentUltrafiltrationData.cpp 0 Remove
        
        File VTreatmentUltrafiltrationData.h 4 Remove
      - File VTDAirTrapData.cpp 0 Remove
      - File VTDAirTrapData.h 0 Remove
      - File VTDBatteryData.cpp 3 Remove
      - File VTDBatteryData.h 0 Remove
      - File VTDEjectorData.cpp 0 Remove
      - File VTDEjectorData.h 0 Remove
      - File VTDSwitchesData.cpp 0 Remove
      - File VTDSwitchesData.h 0 Remove
      - File VTDTemperatureData.cpp 0 Remove
      - File VTDTemperatureData.h 0 Remove
      - File VTDValvesData.cpp 0 Remove
      - File VTDValvesData.h 0 Remove
      - File VTDVoltageData.cpp 0 Remove
      - File VTDVoltageData.h 0 Remove
    - File VView.h 0 Remove
- File leahi.pro 0 Remove
leahi-dialin 0
- Folder leahi_dialin 0
  - Folder common 0
    - File msg_ids.py 3 Remove
  - Folder dd 0
    - Folder modules 0
      - File concentrate_pump.py 0 Remove
      - File dialysate_pump.py 0 Remove
      - File gen_dialysate.py 0 Remove
      - File heaters.py 0 Remove
      - File post_gen_dialysate.py 0 Remove
      - File pre_gen_dialysate.py 0 Remove
      - File temperature_sensors.py 0 Remove
    - Folder proxies 0
      - File ro_proxy.py 0 Remove
      - File td_proxy.py 0 Remove
    - File dialysate_delivery.py 0 Remove
  - Folder fp 0
    - Folder modules 0
      - File boost_pump.py 0 Remove
      - File flow_sensors.py 0 Remove
      - File levels.py 0 Remove
      - File pressure_sensors.py 0 Remove
      - File temperatures.py 0 Remove
      - File water_pumps.py 0 Remove
    - File filtration_purification.py 0 Remove
  - Folder td 0
    - Folder modules 0
      - File air_pump.py 0 Remove
      - File air_trap.py 0 Remove
      - File blood_flow.py 0 Remove
      - File bubble_detector.py 0 Remove
      - File ejector.py 0 Remove
      - File pressure_sensors.py 0 Remove
      - File switches.py 0 Remove
      - File treatment.py 0 Remove
      - File valves.py 0 Remove
    - Folder proxies 0
      - File dd_proxy.py 0 Remove
      - File ro_proxy.py 0 Remove
      - File ui_proxy.py 0 Remove
    - File treatment_delivery.py 0 Remove
  - Folder ui 0
    - File common.py 5 Remove
    - File dd_messaging.py 4 Remove
    - File td_messaging.py 24 Remove
    - File td_messaging_alarms.py 0 Remove
- Folder tests/unit_tests 0
  - Folder depreciated_tests 0
    - File test_dg_temperature_sensors.py 0 Remove
    - File test_ui_proxy.py 0 Remove
  - File test_constructors.py 0 Remove
  - File test_dg_temperature_sensors.py 0 Remove
  - File test_enums.py 0 Remove
  - File test_imports.py 0 Remove
  - File test_msg_ids.py 0 Remove
  - File test_ui_proxy.py 0 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
Tiffany Mejia	Author & Moderator	1h 36m	34	discussed that config values in repo dont match PRS (252/...
Sean Nash	Reviewer - 0% reviewed
Michael Garthwaite	Reviewer - 0% reviewed
Dara Navaei	Reviewer - 0% reviewed	0m
Behrouz NematiPour	Reviewer - Complete	5h 22m	77	RESOLVED.
Daniel Ho	Reviewer - 0% reviewed
Vinayakam Mani	Reviewer - 0% reviewed
jpaguio (deleted user)	Reviewer - 0% reviewed
Nicholas Ramirez	Reviewer - Complete	9m
Total		7h 8m	111

Linked issues
- LDT-627

#permalink

Objectives

There are no specific objectives for this review.

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

There are no general comments on this review.

Click to load diff

/sources/.../settings/MAdjustDDSerialNumberResponse.cpp Deleted

Click to load diff

/sources/.../settings/MAdjustDDSerialNumberResponse.h Deleted

Click to load diff

/sources/.../settings/MAdjustDDVersionsResponse.cpp Deleted

Click to load diff

/sources/.../settings/MAdjustDDVersionsResponse.h Deleted

Click to load diff

/sources/.../data/MDDConductivityData.cpp Deleted

Click to load diff

/sources/model/.../data/MDDConductivityData.h Deleted

Click to load diff

/sources/.../data/MDDGenDialysateData.cpp Deleted

Click to load diff

/sources/model/.../data/MDDGenDialysateData.h Deleted

Click to load diff

/sources/.../settings/MAdjustTDSerialNumberResponse.cpp Deleted

Click to load diff

/sources/.../settings/MAdjustTDSerialNumberResponse.h Deleted

Click to load diff

/sources/.../settings/MAdjustTDVersionsRequest.cpp Deleted

Click to load diff

/sources/.../settings/MAdjustTDVersionsRequest.h Deleted

Click to load diff

/sources/.../settings/MAdjustTDVersionsResponse.cpp Deleted

Click to load diff

/sources/.../settings/MAdjustTDVersionsResponse.h Deleted

Click to load diff

/sources/.../treatment/MTreatmentBloodFlowData.cpp Deleted

Click to load diff

/sources/.../treatment/MTreatmentBloodFlowData.h Deleted

Click to load diff

/sources/.../treatment/MTreatmentPressureOcclusionData.cpp Deleted

Click to load diff

/sources/.../treatment/MTreatmentPressureOcclusionData.h Deleted

Click to load diff

/sources/.../treatment/MTreatmentSalineData.cpp Deleted

Click to load diff

/sources/.../treatment/MTreatmentSalineData.h Deleted

Click to load diff

/sources/.../treatment/MTreatmentSetPointData.cpp Deleted

Click to load diff

/sources/.../treatment/MTreatmentSetPointData.h Deleted

Click to load diff

/sources/.../treatment/MTreatmentStatesData.cpp Deleted

Click to load diff

/sources/.../treatment/MTreatmentStatesData.h Deleted

Click to load diff

/sources/.../treatment/MTreatmentTimeData.cpp Deleted

Click to load diff

/sources/.../treatment/MTreatmentTimeData.h Deleted

Click to load diff

/sources/.../treatment/MTreatmentUltrafiltrationData.cpp Deleted

Click to load diff

/sources/.../treatment/MTreatmentUltrafiltrationData.h Deleted

Click to load diff

/sources/model/hd/data/MTDAirTrapData.cpp Deleted

Click to load diff

/sources/model/hd/data/MTDBatteryData.cpp Deleted

Click to load diff

/sources/model/hd/data/MTDEjectorData.cpp Deleted

Click to load diff

/sources/model/hd/data/MTDSwitchesData.cpp Deleted

Click to load diff

/sources/model/hd/data/MTDSwitchesData.h Deleted

Click to load diff

/sources/model/.../data/MTDTemperatureData.cpp Deleted

Click to load diff

/sources/model/.../data/MTDTemperatureData.h Deleted

Click to load diff

/sources/model/hd/data/MTDValvesData.cpp Deleted

Click to load diff

/sources/model/hd/data/MTDVoltageData.cpp Deleted

Click to load diff

/sources/view/.../data/VDDConductivityData.cpp Deleted

Click to load diff

/sources/view/.../data/VDDConductivityData.h Deleted

Click to load diff

/sources/view/.../data/VDDGenDialysateData.cpp Deleted

Click to load diff

/sources/view/.../data/VDDGenDialysateData.h Deleted

Click to load diff

/sources/.../treatment/VHDTreatmentStatesData.cpp Deleted

Click to load diff

/sources/.../treatment/VHDTreatmentStatesData.h Deleted

Click to load diff

/sources/.../treatment/VTreatmentBloodFlow.cpp Deleted

Click to load diff

/sources/.../treatment/VTreatmentBloodFlow.h Deleted

Click to load diff

/sources/.../treatment/VTreatmentPressureOcclusion.cpp Deleted

Click to load diff

/sources/.../treatment/VTreatmentPressureOcclusion.h Deleted

Click to load diff

/sources/.../treatment/VTreatmentSalineData.cpp Deleted

Click to load diff

/sources/.../treatment/VTreatmentSalineData.h Deleted

Click to load diff

/sources/.../treatment/VTreatmentSetPointData.cpp Deleted

Click to load diff

/sources/.../treatment/VTreatmentSetPointData.h Deleted

Click to load diff

/sources/view/.../treatment/VTreatmentTime.cpp Deleted

Click to load diff

/sources/view/.../treatment/VTreatmentTime.h Deleted

Click to load diff

/sources/.../treatment/VTreatmentUltrafiltrationData.cpp Deleted

Click to load diff

/sources/.../treatment/VTreatmentUltrafiltrationData.h Deleted

Click to load diff

/sources/view/hd/data/VTDAirTrapData.cpp Deleted

Click to load diff

/sources/view/hd/data/VTDBatteryData.cpp Deleted

Click to load diff

/sources/view/hd/data/VTDEjectorData.cpp Deleted

Click to load diff

/sources/view/hd/data/VTDSwitchesData.cpp Deleted

Click to load diff

/sources/view/.../data/VTDTemperatureData.cpp Deleted

Click to load diff

/sources/view/hd/data/VTDTemperatureData.h Deleted

Click to load diff

/sources/view/hd/data/VTDVoltageData.cpp Deleted

Click to load diff

/leahi_dialin/.../modules/post_gen_dialysate.py Deleted

Click to load diff

/leahi_dialin/.../modules/pre_gen_dialysate.py Deleted

Click to load diff

/tests/.../depreciated_tests/test_dg_temperature_sensors.py Deleted

Click to load diff

/tests/.../depreciated_tests/test_ui_proxy.py Deleted

Click to load diff

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: [Crucible Review CR-1\|CR-1]
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

LEAHI-APPLICATION-LDT-627-1

LDT-627 - Main Treatment Screen SW - Messaging Broadcast - Application & Dialin

LEAHI-APPLICATION-LDT-627-1 111

Details

Linked issues

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time

LDT-627 - Main Treatment Screen SW - Messaging Broadcast - Application & Dialin

LEAHI-APPLICATION-LDT-627-1 111

Summarize the review outcomes (optional)

Details

Linked issues

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time