This is a list of all comments for LEAHI-APPLICATION-LDT-907-2. Review Summary: No summary ---------------------------------------- File: SDDs/Diagostics.puml Revision Comment by Behrouz NematiPour on 04 August 2025, 03:18 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-907-2#c23471 Please add a copy of the generated image as well. Reply by Tiffany Mejia on 04 August 2025, 10:19 > Done, added other images as well Reply by Behrouz NematiPour on 04 August 2025, 18:44 > RESOLVED ---------------------------------------- File: leahi.pro Revision Comment by Stephen Quong on 04 August 2025, 09:43 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-907-2#c23486 Add sources/model/td/data/MTDAirBubbleData.h above this line. Reply by Stephen Quong on 04 August 2025, 11:25 > RESOLVED Revision Comment by Stephen Quong on 04 August 2025, 09:44 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-907-2#c23488 Remove reference to MHDAirBubbleData.h Reply by Stephen Quong on 04 August 2025, 11:25 > RESOLVED Revision Comment by Stephen Quong on 04 August 2025, 09:13 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-907-2#c23479 Remove reference to VHDAirBubbleData.h Reply by Stephen Quong on 04 August 2025, 11:25 > RESOLVED Revision Comment by Stephen Quong on 04 August 2025, 09:44 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-907-2#c23489 Add sources/view/td/data/VTDAirBubbleData.h. Reply by Stephen Quong on 04 August 2025, 11:29 > RESOLVED Revision Comment by Stephen Quong on 04 August 2025, 09:45 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-907-2#c23490 Add sources/model/td/data/MTDAirBubbleData.cpp above this line. Reply by Stephen Quong on 04 August 2025, 11:30 > RESOLVED Revision Comment by Stephen Quong on 04 August 2025, 09:46 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-907-2#c23491 Remove reference to MHDAirBubbleData.cpp Reply by Stephen Quong on 04 August 2025, 11:30 > RESOLVED Revision Comment by Stephen Quong on 04 August 2025, 09:14 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-907-2#c23480 Remove reference to VHDAirBubbleData.cpp Reply by Stephen Quong on 04 August 2025, 11:30 > RESOLVED Revision Comment by Stephen Quong on 04 August 2025, 09:47 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-907-2#c23492 Add sources/view/td/data/VTDAirBubbleData.cpp. Reply by Stephen Quong on 04 August 2025, 11:31 > RESOLVED ---------------------------------------- File: sources/gui/GuiGlobals.cpp Revision Comment by Stephen Quong on 04 August 2025, 10:12 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-907-2#c23498 Change to #include "VTDAirBubbleData.h" Reply by Stephen Quong on 04 August 2025, 11:20 > RESOLVED ---------------------------------------- File: sources/gui/qml/dialogs/diagnostics/DiagnosticsBase.qml Revision Comment by Behrouz NematiPour on 04 August 2025, 03:16 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-907-2#c23469 please remove if not used. to easily check, remove, and see the QtCreator application output if QML has a warning or stops executing. Reply by Tiffany Mejia on 04 August 2025, 10:20 > checked and removed Reply by Behrouz NematiPour on 04 August 2025, 18:38 > RESOLVED ---------------------------------------- File: sources/gui/qml/dialogs/diagnostics/DiagnosticsDD.qml Revision Comment by Behrouz NematiPour on 04 August 2025, 03:13 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-907-2#c23468 same as http://devapps.diality.us:8060/cru/LEAHI-APPLICATION-LDT-907-2#CFR-69439 Reply by Tiffany Mejia on 04 August 2025, 10:21 > fixed! Reply by Behrouz NematiPour on 04 August 2025, 18:38 > RESOLVED ---------------------------------------- File: sources/gui/qml/dialogs/diagnostics/DiagnosticsDialog.qml Revision Comment by Behrouz NematiPour on 04 August 2025, 03:16 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-907-2#c23470 same as http://devapps.diality.us:8060/cru/LEAHI-APPLICATION-LDT-907-2#CFR-69436 Reply by Tiffany Mejia on 04 August 2025, 10:21 > fixed! Reply by Behrouz NematiPour on 04 August 2025, 18:38 > RESOLVED ---------------------------------------- File: sources/gui/qml/dialogs/diagnostics/DiagnosticsTD.qml Revision Comment by Behrouz NematiPour on 04 August 2025, 03:13 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-907-2#c23467 Put this under the //Project for the project specific imports. and one empty line after from the next block (//QML imports) Reply by Behrouz NematiPour on 04 August 2025, 18:39 > RESOLVED ---------------------------------------- File: leahi_dialin/ui/td_messaging.py Revision Comment by Behrouz NematiPour on 04 August 2025, 02:24 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-907-2#c23464 Msg ID: Reply by Behrouz NematiPour on 04 August 2025, 18:43 > RESOLVED Revision Comment by Behrouz NematiPour on 04 August 2025, 02:25 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-907-2#c23465 Update the description for this message. Reply by Behrouz NematiPour on 04 August 2025, 18:43 > RESOLVED ---------------------------------------- File: sources/model/td/data/MTDAirBubbleData.cpp Revision Comment by Stephen Quong on 04 August 2025, 10:02 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-907-2#c23494 Filename and class name (and all references to class name in file) do not match. Reply by Stephen Quong on 04 August 2025, 11:20 > RESOLVED ---------------------------------------- File: sources/model/td/data/MTDAirBubbleData.h Revision Comment by Stephen Quong on 04 August 2025, 10:02 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-907-2#c23493 Filename and class name (and all references to class name in file) do not match. sources/canbus/MessageInterpreter.cpp will need to be updated when class name changes. Reply by Stephen Quong on 04 August 2025, 11:23 > RESOLVED Revision Comment by Stephen Quong on 04 August 2025, 10:14 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-907-2#c23499 sources/model/MModel.h include for this file needs to be updated from MHDAirBubbleData.h to MTDAirBubbleData.h Reply by Stephen Quong on 04 August 2025, 11:23 > RESOLVED ---------------------------------------- File: sources/view/hd/data/VHDAirBubbleData.h Revision Comment by Stephen Quong on 04 August 2025, 09:12 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-907-2#c23478 All references to VHDAirBubbleData need to be changed (to VTDAirBubbleData?) or removed. Reply by Stephen Quong on 04 August 2025, 11:24 > RESOLVED ---------------------------------------- File: sources/view/td/data/VTDAirBubbleData.cpp Revision Comment by Stephen Quong on 04 August 2025, 08:49 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-907-2#c23474 Filename and class name (and all references to class name in file) do not match. Reply by Stephen Quong on 04 August 2025, 11:24 > RESOLVED ---------------------------------------- File: sources/view/td/data/VTDAirBubbleData.h Revision Comment by Stephen Quong on 04 August 2025, 08:49 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-907-2#c23473 Filename and class name (and all references to class name in file) do not match. Reply by Stephen Quong on 04 August 2025, 11:25 > RESOLVED --- ID: LEAHI-APPLICATION-LDT-907-2 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-907-2 Title: feature/LDT-907 - Diagnostics-Screen-DD-2 - Application Statement of Objectives: State: Closed Summary: Author: Tiffany Mejia Moderator: Tiffany Mejia Reviewers: (6 active, 3 completed*) Nicholas Ramirez (*) Behrouz NematiPour (*) Stephen Quong (*) Sean Nash jpaguio Vinayakam Mani Michael Garthwaite Dara Navaei Daniel Ho