This is a list of all comments for LEAHI-DIALIN-LDT-2300-1.

Review Summary: No summary


----------------------------------------
File: leahi_dialin/dd/modules/blood_leak.py
Revision Comment by Sean Nash on 22 September 2025, 09:38 
https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-2300-1#c24396

  Replace "hd" with "dd".

  Reply by jpaguio on 25 September 2025, 12:11
  > Done

----------------------------------------
File: leahi_dialin/dd/modules/heaters.py
Revision Comment by Sean Nash on 22 September 2025, 09:42 
https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-2300-1#c24398

  Is msg_id_dd_heaters_data really being published here?  Should
  it be?  ** This comment applies to all classes as it appears
  you've done this everywhere.
  Also, I think we typically list the timestamp last.

  Reply by jpaguio on 22 September 2025, 14:24
  > I'm not sure I really understand the question here, but I do
  > know that the DD Heaters data is being published with this
  > handler: I've organized all heater data into a nested
  > dictionary so that only one "variable" is being published.
  > The same goes for the other publish functions before each
  > handler. I will reorganize the order of the published
  > variables so that timestamp is listed last.

Revision Comment by Sean Nash on 22 September 2025, 09:45 
https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-2300-1#c24399

  I didn't see dbg variables in the publish list above.

  Reply by jpaguio on 25 September 2025, 12:12
  > Done

Revision Comment by Sean Nash on 22 September 2025, 09:41 
https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-2300-1#c24397

  Replace "dg" with "dd".

  Reply by jpaguio on 25 September 2025, 12:13
  > Done

----------------------------------------
File: leahi_dialin/fp/modules/fp_test_configs.py
Revision Comment by Sean Nash on 22 September 2025, 09:48 
https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-2300-1#c24400

  No timestamp?

  Reply by jpaguio on 25 September 2025, 12:16
  > Done - timestamps added to DD, FP, and TD


---

ID: LEAHI-DIALIN-LDT-2300-1 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-2300-1

Title: LEAHI-DIALIN-LDT-2300_Dialin: Add a way for a Dialin user to identify what broadcast message is being received
Statement of Objectives:


State: Closed

Summary: 

Author: jpaguio
Moderator: jpaguio
Reviewers: (2 active, 2 completed*)
     Sean Nash   (*)
     Dara Navaei   (*)
     Michael Garthwaite
     Behrouz NematiPour