This is a list of all comments for LEAHI-DIALIN-LDT-566-1. Review Summary: No summary ---------------------------------------- File: leahi_dialin/dd/modules/post_gen_dialysate.py Revision Comment by Sean Nash on 22 May 2025, 13:03 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-566-1#c22059 DDPostGenDialysate? Reply by Michael Garthwaite on 23 June 2025, 11:03 > fixed. Revision Comment by Sean Nash on 22 May 2025, 13:03 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-566-1#c22060 same. Reply by Michael Garthwaite on 23 June 2025, 11:03 > fixed. Revision Comment by Sean Nash on 22 May 2025, 13:03 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-566-1#c22061 Leahi? Reply by Michael Garthwaite on 23 June 2025, 11:04 > fixed Revision Comment by Sean Nash on 22 May 2025, 13:02 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-566-1#c22057 should be "post gen" Reply by Michael Garthwaite on 23 June 2025, 11:05 > fixed. Revision Comment by Sean Nash on 22 May 2025, 13:02 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-566-1#c22058 "... interval override for post gen dialysate data." Reply by Michael Garthwaite on 23 June 2025, 11:06 > fixed. ---------------------------------------- File: leahi_dialin/dd/modules/pre_gen_dialysate.py Revision Comment by Sean Nash on 22 May 2025, 13:04 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-566-1#c22062 DDPreGenDialysate? Reply by Michael Garthwaite on 23 June 2025, 11:06 > fixed. Revision Comment by Sean Nash on 22 May 2025, 13:04 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-566-1#c22063 same. Reply by Michael Garthwaite on 23 June 2025, 11:06 > fixed. Revision Comment by Sean Nash on 22 May 2025, 13:04 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-566-1#c22064 Leahi? Reply by Michael Garthwaite on 23 June 2025, 11:06 > fixed. Revision Comment by Sean Nash on 22 May 2025, 13:04 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-566-1#c22065 pre gen? Reply by Michael Garthwaite on 23 June 2025, 11:06 > fixed. Revision Comment by Sean Nash on 22 May 2025, 13:04 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-566-1#c22066 pre gen Reply by Michael Garthwaite on 23 June 2025, 11:07 > fixed. Revision Comment by Sean Nash on 22 May 2025, 13:06 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-566-1#c22067 "... interval override for pre gen dialysate data." Reply by Michael Garthwaite on 23 June 2025, 11:07 > fixed. Revision Comment by Sean Nash on 22 May 2025, 13:07 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-566-1#c22068 Is this overriding the pre gen state? Or is this a TD proxy command? Or what? Reply by Vinayakam Mani on 22 May 2025, 13:37 > This command is used to directly override the > "pendingStartDDPregenRequest" flag (which is also set when TD > proxy command executed when all pre-conditions met). Reply by Sean Nash on 23 May 2025, 12:22 > I think the proxy cmd to start pre gen should be sufficient > to support this. > We do not typically allow Dialin to set internal variables > that are not sensor readings. > Consider removing this override (and any others like it). Reply by Michael Garthwaite on 23 June 2025, 11:08 > Are we confirmed for removal? Would there be a situation > we need this override that the proxy cmd could not > satisfy? Reply by Sean Nash on 23 June 2025, 11:31 > Look to see if Vinay removed from f/w or ask Vinay if > he intends to. Reply by Vinayakam Mani on 23 June 2025, 17:31 > Just removed in firmware. Reply by Michael Garthwaite on 24 June 2025, 10:53 > override removed. Revision Comment by Sean Nash on 22 May 2025, 13:07 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-566-1#c22069 same comment. Reply by Vinayakam Mani on 22 May 2025, 13:46 > This command is used to directly override the > "pendingStoptDDPregenRequest" flag (which is also set when TD > proxy command executed when all pre-conditions met). Reply by Michael Garthwaite on 23 June 2025, 11:09 > Are we confirmed for removal? Would there be a situation we > need this override that the proxy cmd could not satisfy? Reply by Vinayakam Mani on 23 June 2025, 17:34 > Just removed in firmware Reply by Michael Garthwaite on 24 June 2025, 10:53 > override removed. ---------------------------------------- File: leahi_dialin/dd/modules/temperature_sensors.py Revision Comment by Vinayakam Mani on 22 May 2025, 15:56 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-566-1#c22077 There is an additional 'UF pump' added in the concentrate pump driver. Please add the dialin support for the same, Reply by Michael Garthwaite on 23 June 2025, 11:02 > UF pump has been labeled in the concentrate pump module. Does > it have a temp sensor as well? Reply by Vinayakam Mani on 23 June 2025, 12:07 > UF pump doesn't have any temp sensor and nothing to do with > this module. I just placed the comment here to add > additional UF pump. ---------------------------------------- File: leahi_dialin/td/proxies/dd_proxy.py Revision Comment by Sean Nash on 22 May 2025, 13:27 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-566-1#c22071 Michael, are you sure you want to organize the proxies this way (i.e. putting TD proxy commands in the TD class instead of the DD class)? Downside for me is that, as a tester, I have to create a TD class to get TD proxy functionality when I may only want to work with DD class to test the DD. What is the upside to doing it this way? Reply by Michael Garthwaite on 23 June 2025, 10:48 > agreed. We should only need one class. removed > td_send_dd_gen_dialysate_request from td_proxy. ---------------------------------------- File: leahi_dialin/common/msg_ids.py Revision Comment by Sean Nash on 25 June 2025, 09:46 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-566-1#c22300 Are these temporary test messages? If not, start these at 0x51 (not 0xF1). Reply by Michael Garthwaite on 25 June 2025, 10:16 > I believe the DD piston pump is temporary for Vinay. The > others are temporary as i know the are being implemented but > i dont know what ID they are. They needed some value since > they are coded in the ui modules and are breaking unit tests ---------------------------------------- File: leahi_dialin/dd/proxies/td_proxy.py Revision Comment by Sean Nash on 22 May 2025, 13:10 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-566-1#c22070 I believe pre-gen command has something like 4 parameters. Msg ID name should change (talk w/ Vinay). Not requesting data. It's a start/stop command. ---------------------------------------- File: leahi_dialin/dd/modules/gen_dialysate.py Revision Comment by Vinayakam Mani on 22 May 2025, 15:46 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-566-1#c22076 There is one more dialin command needs to be supported (MSG_ID_DD_GEND_EXEC_STATE_OVERRIDE_REQUEST). This command is used to change the state of Gen dialysate execution ( to help system team to move/jump into desired state by not executing in order fashion) Reply by Michael Garthwaite on 23 June 2025, 10:46 > that is cmd_dialysate_delivery_set_state_override(). Line 237 ---------------------------------------- File: leahi_dialin/dd/modules/dialysate_pump.py Revision Comment by Vinayakam Mani on 22 May 2025, 15:41 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-566-1#c22075 Please add control as param (1: open loop, 0: Close loop) Reply by Michael Garthwaite on 23 June 2025, 10:46 > fixed. ---------------------------------------- File: leahi_dialin/td/modules/ejector.py Revision Comment by Sean Nash on 23 May 2025, 12:25 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-566-1#c22080 Not air pump. Change to ejector. Revision Comment by Sean Nash on 23 June 2025, 11:41 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-566-1#c22226 Restore this override function. I added msg 8034 for this. Reply by Michael Garthwaite on 24 June 2025, 10:48 > added Revision Comment by Sean Nash on 23 May 2025, 12:26 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-566-1#c22081 Wrong message ID. Reply by Michael Garthwaite on 24 June 2025, 10:49 > fixed. Revision Comment by Sean Nash on 23 May 2025, 12:42 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-566-1#c22082 Remove "NUM_OF..." enum from header. Revision Comment by Sean Nash on 23 May 2025, 12:43 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-566-1#c22083 I would describe the cmd param as ID of an ejector operation that is being requested. Revision Comment by Sean Nash on 23 May 2025, 12:45 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-566-1#c22084 Mention the units (RPM) and that a negative speed = reverse (retract) direction. ---------------------------------------- File: leahi_dialin/td/modules/treatment.py Revision Comment by Sean Nash on 23 May 2025, 12:49 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-566-1#c22085 Some of these are floats, so should be 'f'. Reply by Michael Garthwaite on 23 June 2025, 10:55 > fixed. thanks! Revision Comment by Sean Nash on 23 May 2025, 12:50 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-566-1#c22087 Recommend swapping order of parameters (ID first, then value). Reply by Michael Garthwaite on 23 June 2025, 10:55 > fixed. thanks! Revision Comment by Sean Nash on 23 May 2025, 12:50 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-566-1#c22086 Missing function description in header. Reply by Michael Garthwaite on 23 June 2025, 10:55 > fixed. thanks! ---------------------------------------- File: leahi_dialin/td/modules/blood_flow.py Revision Comment by Sean Nash on 25 June 2025, 09:53 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-566-1#c22304 Wrong msg ID. Reply by Michael Garthwaite on 25 June 2025, 10:20 > fixed. thanks ---------------------------------------- File: leahi_dialin/td/modules/bubble_detector.py Revision Comment by Sean Nash on 23 June 2025, 11:34 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-566-1#c22225 b18? ---------------------------------------- File: leahi_dialin/td/modules/air_trap.py Revision Comment by Sean Nash on 25 June 2025, 09:52 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-566-1#c22302 Should we be logging anything? Reply by Michael Garthwaite on 25 June 2025, 10:20 > added logging statement Revision Comment by Sean Nash on 25 June 2025, 09:50 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-566-1#c22301 Not valve. Should be control (0=stop, 1=start). Reply by Michael Garthwaite on 25 June 2025, 10:20 > fixed. thanks Revision Comment by Sean Nash on 25 June 2025, 09:52 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-566-1#c22303 Should we be logging anything? Reply by Michael Garthwaite on 25 June 2025, 10:20 > added logging statement --- ID: LEAHI-DIALIN-LDT-566-1 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-566-1 Title: LEAHI-DIALIN-LDT-566_Water Treatment And Degassing FP Statement of Objectives: State: Closed Summary: Author: Michael Garthwaite Moderator: Michael Garthwaite Reviewers: (6 active, 1 completed*) Sean Nash (*) Tiffany Mejia jpaguio Vinayakam Mani Dara Navaei Behrouz NematiPour Daniel Ho