This is a list of all comments for LEAHI-DIALIN-LEAH-136-2.

Review Summary: No summary


----------------------------------------
File: leahi-dialin/common/alarm_defs.py
Revision Comment by Sean Nash on 04 November 2024, 10:30 
https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-136-2#c20785

  This is Denali alarm list.  Align w/ Leahi alarm list.

----------------------------------------
File: leahi-dialin/common/dg_defs.py
Revision Comment by Sean Nash on 04 November 2024, 10:31 
https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-136-2#c20786

  dd_defs.

Revision Comment by Sean Nash on 04 November 2024, 10:31 
https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-136-2#c20787

  Match DD op modes for Leahi.

Revision Comment by Sean Nash on 04 November 2024, 10:32 
https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-136-2#c20788

  I don't think we have any DD POST tests defined yet.

----------------------------------------
File: leahi-dialin/common/hd_defs.py
Revision Comment by Sean Nash on 04 November 2024, 10:32 
https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-136-2#c20789

  td_defs.

----------------------------------------
File: leahi-dialin/common/msg_ids.py
Revision Comment by Sean Nash on 04 November 2024, 10:33 
https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-136-2#c20790

  Align to Leahi message list.

----------------------------------------
File: leahi-dialin/dg/__init__.py
Revision Comment by Sean Nash on 04 November 2024, 10:34 
https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-136-2#c20792

  No DG in Leahi.  Change to DD.

----------------------------------------
File: leahi-dialin/dg/accelerometer.py
Revision Comment by Sean Nash on 04 November 2024, 10:34 
https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-136-2#c20791

  Leahi will have no accelerometers.

----------------------------------------
File: leahi-dialin/hd/__init__.py
Revision Comment by Sean Nash on 04 November 2024, 10:44 
https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-136-2#c20796

  No HD in Leahi.  Change to TD.

----------------------------------------
File: leahi-dialin/hd/accelerometer.py
Revision Comment by Sean Nash on 04 November 2024, 10:45 
https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-136-2#c20797

  No accelerometer in Leahi.

----------------------------------------
File: leahi_dialin/common/alarm_defs.py
Revision Comment by Sean Nash on 22 January 2025, 13:41 
https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-136-2#c21078

  Catch up with latest f/w.

----------------------------------------
File: leahi_dialin/common/dd_defs.py
Revision Comment by Sean Nash on 22 January 2025, 13:45 
https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-136-2#c21088

  Match DD op modes in f/w.

Revision Comment by Sean Nash on 22 January 2025, 13:45 
https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-136-2#c21087

  DG to DD.

Revision Comment by Sean Nash on 22 January 2025, 13:44 
https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-136-2#c21085

  Remove.

Revision Comment by Sean Nash on 22 January 2025, 13:44 
https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-136-2#c21084

  Remove.

Revision Comment by Sean Nash on 22 January 2025, 13:44 
https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-136-2#c21083

  Remove.

Revision Comment by Sean Nash on 22 January 2025, 13:44 
https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-136-2#c21082

  Remove.

Revision Comment by Sean Nash on 22 January 2025, 13:45 
https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-136-2#c21086

  Remove.

Revision Comment by Sean Nash on 22 January 2025, 13:43 
https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-136-2#c21081

  Remove chem disinfect.  Leahi not currently slated to have a
  chem disinfect.

Revision Comment by Sean Nash on 22 January 2025, 13:43 
https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-136-2#c21080

  Remove - we don't have this in Leahi yet.

Revision Comment by Sean Nash on 22 January 2025, 13:42 
https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-136-2#c21079

  DG to DD.

----------------------------------------
File: leahi_dialin/ro/reverse_osmosis.py
Revision Comment by Sean Nash on 22 January 2025, 13:48 
https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-136-2#c21089

  File is reverse_osmosis.py.  I actually don't like the file
  name.  Prefer something like filtration_purification.py.  Still
  ok with RO for folders and class names I think - though Jenna
  uses IOFP.


---

ID: LEAHI-DIALIN-LEAH-136-2 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-136-2

Title: LEAHI-DIALIN-LEAH-136_Dial RO Base Object
Statement of Objectives:


State: Closed

Summary: 

Author: Michael Garthwaite
Moderator: Michael Garthwaite
Reviewers: (6 active, 0 completed*)
     Sean Nash
     Tiffany Mejia
     jpaguio
     Vinayakam Mani
     Dara Navaei
     Behrouz NematiPour