LEAHI-DIALIN-LEAH-136-3 LEAH-136-dial-ro-base-object

closed on 10 Feb

Author

Moderator

Reviewers

LEAH-136-dial-ro-base-object

Activity

Details
Objectives
General Comments 0
Unresolved
Resolved
Number of files included: 17

leahi-dialin 0
- Folder leahi-dialin 0
  - Folder common 0
    - File msg_ids.py 0 Remove
  - Folder ro/modules 0
    - File boost_pump.py 0 Remove
    - File levels.py 0 Remove
    - File pressure_sensors.py 0 Remove
    - File valves.py 0 Remove
- Folder leahi_dialin 0
  - Folder common 0
    - File msg_ids.py 0 Remove
  - Folder ro 0
    - Folder modules 0
      - File __init__.py 0 Remove
      - File boost_pump.py 7 Remove
      - File conductivity.py 0 Remove
      - File conductivity_sensors.py 36 Remove
      - File constants.py 0 Remove
      - File flow_sensors.py 5 Remove
      - File levels.py 4 Remove
      - File pressure_sensors.py 20 Remove
      - File valves.py 10 Remove
    - File constants.py 0 Remove
    - File reverse_osmosis.py 4 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
Michael Garthwaite	Author & Moderator	18m	42	my bad. Now its fixed! I'll probably change the whole RO ...
Sean Nash	Reviewer - Complete	1h 7m	44	Do you disagree with name change?
jpaguio (deleted user)	Reviewer - 0% reviewed	3m
Tiffany Mejia	Reviewer - Complete	5m
Vinayakam Mani	Reviewer - 73% reviewed	4m
Dara Navaei	Reviewer - 0% reviewed
Behrouz NematiPour	Reviewer - 0% reviewed
Total		1h 39m	86

Linked issues
- LEAH-136

#permalink

Objectives

Merge branch 'LEAH-142-dial-td-base-object' into LEAH-136-dial-ro-base-object
WIP on LEAH-136-dial-ro-base-object
RO override modules
Merge branch 'LEAH-142-dial-td-base-object' into LEAH-136-dial-ro-base-object
Moving modules to folder
updated naming and handlers
moved constants folder. Updated Ro valves
updated pathing for imports
Merge branch 'LEAH-142-dial-td-base-object' into develop
fixed RO login message
WIP on develop
fixed ro values override msg id
WIP on develop
fixed ro boost pump overrides
fixed override.
WIP on develop
fixed set pwm to not be an override
WIP on develop
fixed boost pump pwm
WIP on develop
fixed set pwm
WIP on develop
documentation fixes
fixed boost pump import. fixed valve doc string
WIP on develop
added init file for build script
updated boost pump documentation
Added flow sensor module. minor updates across other modules
added RO conductivity module.
fixed ro flow sensor registering an unknown method
updated RO valves with SPP valve.
fixed ro valve positioning
WIP on develop
added flow sensors and conductivity to ro main module
Merge branch 'staging' into LEAH-136-dial-ro-base-object

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

There are no general comments on this review.

Click to load diff

/leahi-dialin/.../modules/pressure_sensors.py Deleted

Click to load diff

/leahi_dialin/ro/modules/conductivity.py Deleted

Click to load diff

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: [Crucible Review CR-1\|CR-1]
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

LEAHI-DIALIN-LEAH-136-3

LEAH-136-dial-ro-base-object

LEAHI-DIALIN-LEAH-136-3 86

Details

Linked issues

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time

LEAH-136-dial-ro-base-object

LEAHI-DIALIN-LEAH-136-3 86

Summarize the review outcomes (optional)

Details

Linked issues

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time