This is a list of all comments for LEAHI-DIALIN-LEAH-139-2. Review Summary: No summary ---------------------------------------- File: leahi-dialin/common/__init__.py Revision Comment by Behrouz NematiPour on 26 November 2024, 11:09 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-139-2#c21023 I am strongly against the idea of including/importing everything. This is against all the modularity idea. Imagine someone includes all the libraries in the main.cpp in a C code, does that sound a right thing to do??? Every part of the code needs that should import that. ---------------------------------------- File: leahi-dialin/common/dd_defs.py Revision Comment by Vinayakam Mani on 19 November 2024, 11:46 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-139-2#c20942 Please replace all DG references to DD. Revision Comment by Vinayakam Mani on 19 November 2024, 11:44 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-139-2#c20941 There are some clean up done to init states ( removal of RTC, UV reactors, thermistors, load cell etc..) , Please refer the latest code. Revision Comment by Vinayakam Mani on 19 November 2024, 11:48 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-139-2#c20943 Please refer latest DD_defs.h for updates/clean up. ---------------------------------------- File: leahi-dialin/common/msg_defs.py Revision Comment by Behrouz NematiPour on 26 November 2024, 11:13 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-139-2#c21024 Please get rid of this approach for leahi, and use the utility functions that have been implemented and tested to get and correctly convert payload parameters. this is not safe and/or fast for development or even maintainable. ---------------------------------------- File: leahi-dialin/protocols/CAN.py Revision Comment by Vinayakam Mani on 19 November 2024, 12:00 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-139-2#c20944 Do we need to update these channels naming/id per leahi changes? ---------------------------------------- File: leahi-dialin/dd/modules/conductivity_sensors.py Revision Comment by Vinayakam Mani on 21 November 2024, 14:44 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-139-2#c20980 Read counter is integer type (not float). Revision Comment by Vinayakam Mani on 21 November 2024, 14:45 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-139-2#c20981 Error counter -> Integer type. ---------------------------------------- File: leahi-dialin/dd/modules/pressure_sensors.py Revision Comment by Vinayakam Mani on 21 November 2024, 15:10 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-139-2#c20990 No Drain pump pressure sensor. Revision Comment by Vinayakam Mani on 21 November 2024, 15:13 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-139-2#c20991 These pressure sensors ID needs to be updated (repeated in entire file) Revision Comment by Vinayakam Mani on 21 November 2024, 15:14 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-139-2#c20992 read counter -> integer type Revision Comment by Vinayakam Mani on 21 November 2024, 15:16 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-139-2#c20995 Needs to be updated as integer - pressure sensor. Revision Comment by Vinayakam Mani on 21 November 2024, 15:15 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-139-2#c20993 Conductivity -> Pressure Revision Comment by Vinayakam Mani on 21 November 2024, 15:17 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-139-2#c20996 Error counter: float to Integer type. ---------------------------------------- File: leahi-dialin/dd/modules/valves.py Revision Comment by Vinayakam Mani on 21 November 2024, 15:21 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-139-2#c20997 Looks the valve names, states and entire file needs to be revisited per leahi updates. ---------------------------------------- File: leahi-dialin/dd/modules/concentrate_pump.py Revision Comment by Vinayakam Mani on 21 November 2024, 14:14 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-139-2#c20977 Could you please check the order of bytes against the concentrate pump data structure declaration? I see the 3rd parameter in structure is CP2 current set speed. Revision Comment by Vinayakam Mani on 21 November 2024, 14:24 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-139-2#c20978 DG to DD in entire file. Revision Comment by Vinayakam Mani on 21 November 2024, 14:33 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-139-2#c20979 There is one more test routine added later in the source code (MSG_ID_DD_CONCENTRATE_PUMPS_START_STOP_OVERRIDE_REQUEST). Please add the dialin support. ---------------------------------------- File: leahi-dialin/dd/modules/dialysate_pump.py Revision Comment by Vinayakam Mani on 21 November 2024, 14:46 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-139-2#c20982 Change to Dialysate pumps (few more places referenced as Concentrate pump as well in this file) Revision Comment by Vinayakam Mani on 21 November 2024, 14:55 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-139-2#c20983 Please add the support for "MSG_ID_DD_DIALYSATE_PUMPS_START_STOP_OVERRIDE_REQUEST". ---------------------------------------- File: leahi-dialin/dd/modules/heaters.py Revision Comment by Vinayakam Mani on 21 November 2024, 14:57 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-139-2#c20984 The latest source file has updated heaters exec state. please update accordingly. Revision Comment by Vinayakam Mani on 21 November 2024, 14:59 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-139-2#c20985 float type for both primary and trimmer duty cycle. Revision Comment by Vinayakam Mani on 21 November 2024, 15:04 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-139-2#c20986 Did we consider temperature as additional parameters as part of the payload? ---------------------------------------- File: leahi-dialin/dd/modules/levels.py Revision Comment by Vinayakam Mani on 21 November 2024, 15:07 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-139-2#c20988 Its priority interval (not general task ) Revision Comment by Vinayakam Mani on 21 November 2024, 15:08 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-139-2#c20989 heater -> Level ---------------------------------------- File: leahi-dialin/dd/modules/temperature_sensors.py Revision Comment by Vinayakam Mani on 25 November 2024, 13:10 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-139-2#c20999 It's under priority task. Revision Comment by Vinayakam Mani on 25 November 2024, 13:13 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-139-2#c21000 read counter type: Integer (not float) Revision Comment by Vinayakam Mani on 25 November 2024, 13:15 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-139-2#c21001 Same here, baro sensor read counter as well Integer type. Revision Comment by Vinayakam Mani on 25 November 2024, 13:15 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-139-2#c21002 baro sensor CRC -> Integer type. --- ID: LEAHI-DIALIN-LEAH-139-2 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-139-2 Title: LEAHI-DIALIN-LEAH-139_Dial DD Base Object Statement of Objectives: State: Closed Summary: Author: Michael Garthwaite Moderator: Michael Garthwaite Reviewers: (6 active, 0 completed*) Sean Nash Tiffany Mejia jpaguio Vinayakam Mani Dara Navaei Behrouz NematiPour