This is a list of all comments for LEAHI-DIALIN-LEAH-139-3. Review Summary: No summary ---------------------------------------- File: leahi_dialin/dd/modules/piston_pump.py Revision Comment by Sean Nash on 10 February 2025, 12:54 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-139-3#c21400 File name is not plural like it is here. I think it should be, but either way, they should match. Reply by Michael Garthwaite on 12 February 2025, 12:49 > Fixed. Thanks! Revision Comment by Sean Nash on 10 February 2025, 12:55 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-139-3#c21402 Should there be an enum for the list of piston pump names? Reply by Michael Garthwaite on 12 February 2025, 12:49 > Added. Thanks! Revision Comment by Sean Nash on 10 February 2025, 12:55 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-139-3#c21401 Refactor to f/w naming. Reply by Michael Garthwaite on 11 February 2025, 11:58 > The piston pumps dont seem to have naming ID's in the FW. Do > you have a doc i can reference? Reply by Sean Nash on 11 February 2025, 12:49 > Maybe because piston pump is seen as temporary - just there > to test a possible concentrate pump replacement for now. Revision Comment by Sean Nash on 10 February 2025, 12:56 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-139-3#c21403 I can see that the override cmd function is named per the override message it sends (from f/w code), but the name doesn't seem to match what it does exactly. This is not an on/off or start/stop cmd. It is a set piston pump target flow rate command. Work with Vinay and consider renaming here and in f/w. Revision Comment by Sean Nash on 10 February 2025, 12:59 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-139-3#c21404 This looks more like a flow rate (mL/min) than a speed (RPM). ---------------------------------------- File: leahi_dialin/dd/modules/valves.py Revision Comment by Sean Nash on 10 February 2025, 14:25 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-139-3#c21421 Refactor per f/w naming. Reply by Michael Garthwaite on 11 February 2025, 11:20 > Fixed. Thanks! Reply by Sean Nash on 11 February 2025, 12:54 > The naming has the new codes now, but still does not match > the f/w. Firmware has _VALV suffix, not old code. Reply by Michael Garthwaite on 12 February 2025, 11:26 > Fixed. Thanks! Revision Comment by Sean Nash on 10 February 2025, 14:25 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-139-3#c21422 Refactor per f/w naming. Reply by Michael Garthwaite on 11 February 2025, 11:20 > Fixed. Thanks! Revision Comment by Sean Nash on 11 February 2025, 08:59 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-139-3#c21426 DG should be DD. Reply by Michael Garthwaite on 11 February 2025, 11:20 > Fixed. Thanks! Revision Comment by Sean Nash on 11 February 2025, 08:59 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-139-3#c21427 DG should be DD. Reply by Michael Garthwaite on 11 February 2025, 11:20 > Fixed. Thanks! Revision Comment by Vinayakam Mani on 10 February 2025, 17:25 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-139-3#c21425 DD. replace DG to DD across file. Reply by Michael Garthwaite on 11 February 2025, 11:20 > Fixed. Thanks! Revision Comment by Sean Nash on 11 February 2025, 09:00 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-139-3#c21428 DG should be DD. Reply by Michael Garthwaite on 11 February 2025, 11:20 > Fixed. Thanks! Reply by Sean Nash on 11 February 2025, 12:56 > I do not see fix. Reply by Michael Garthwaite on 12 February 2025, 11:26 > Fixed. Thanks! ---------------------------------------- File: leahi_dialin/dd/proxies/td_proxy.py Revision Comment by Sean Nash on 11 February 2025, 09:02 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-139-3#c21431 Not buttons.py Revision Comment by Sean Nash on 11 February 2025, 09:00 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-139-3#c21429 Needs function header Reply by Michael Garthwaite on 11 February 2025, 11:21 > Fixed. Thanks! ---------------------------------------- File: leahi_dialin/dd/modules/heaters.py Revision Comment by Vinayakam Mani on 10 February 2025, 12:38 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-139-3#c21390 Leahi heaters states modified from denali, please update the states per DD firmware. Reply by Michael Garthwaite on 12 February 2025, 12:51 > Fixed. Thanks! Revision Comment by Sean Nash on 10 February 2025, 11:20 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-139-3#c21378 Refactor per f/w naming. Reply by Michael Garthwaite on 12 February 2025, 12:51 > Fixed. Thanks! Revision Comment by Sean Nash on 10 February 2025, 11:20 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-139-3#c21379 Rename variables per f/w naming. Reply by Michael Garthwaite on 12 February 2025, 12:51 > Fixed. Thanks! Revision Comment by Sean Nash on 10 February 2025, 11:21 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-139-3#c21380 DG should be DD. Reply by Michael Garthwaite on 12 February 2025, 12:51 > Fixed. Thanks! Revision Comment by Sean Nash on 10 February 2025, 11:24 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-139-3#c21383 Should heater param be a Heater_Names enum instead of an int? (comment applies to all override cmds in all classes) Reply by Michael Garthwaite on 12 February 2025, 12:51 > I dont want limit the methods to the enums like that. > > - it allows the method to work while the enum may be out of > sync. ( good for debugging purposes ) > - it allows us to test the method by sending out of range > paramaters to the FW and get the correct rejection(s). Revision Comment by Sean Nash on 10 February 2025, 11:22 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-139-3#c21381 DG should be DD. Reply by Michael Garthwaite on 12 February 2025, 12:51 > Fixed. Thanks! Revision Comment by Sean Nash on 10 February 2025, 11:22 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-139-3#c21382 FMP/FMD are DG names. Reply by Michael Garthwaite on 12 February 2025, 12:51 > Fixed. Thanks! ---------------------------------------- File: leahi_dialin/dd/modules/concentrate_pump.py Revision Comment by Sean Nash on 29 January 2025, 13:57 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-139-3#c21265 Refactor per f/w changes. Reply by Michael Garthwaite on 06 February 2025, 10:04 > Fixed. Thanks! Revision Comment by Vinayakam Mani on 10 February 2025, 10:40 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-139-3#c21373 The naming convention to be followed in general ( as agreed upon with the system team and others): 1) PUMP should be D10_PUMP, D11_PUMP, D12_PUMP 2) VALV should be D3_VALV, D65_VALV .... Reply by Michael Garthwaite on 12 February 2025, 12:59 > Fixed. Thanks! Revision Comment by Sean Nash on 29 January 2025, 13:57 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-139-3#c21266 Refactor names per f/w changes. Reply by Michael Garthwaite on 06 February 2025, 10:04 > Fixed. Thanks! Revision Comment by Vinayakam Mani on 10 February 2025, 10:52 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-139-3#c21374 It should be U32. Reply by Michael Garthwaite on 12 February 2025, 12:59 > Fixed. Thanks! Revision Comment by Vinayakam Mani on 10 February 2025, 10:52 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-139-3#c21375 It should be U32. Reply by Michael Garthwaite on 12 February 2025, 12:59 > Fixed. Thanks! Revision Comment by Vinayakam Mani on 10 February 2025, 10:53 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-139-3#c21376 Rev count should be U32. please fix all below rev counts ( target and measured rev counts for d10 and d11) Reply by Michael Garthwaite on 12 February 2025, 12:59 > Fixed. Thanks! Revision Comment by Sean Nash on 29 January 2025, 13:58 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-139-3#c21267 Should be DD. Reply by Michael Garthwaite on 06 February 2025, 10:03 > Fixed. Thanks! Revision Comment by Sean Nash on 29 January 2025, 13:58 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-139-3#c21268 Should be DD. Reply by Michael Garthwaite on 06 February 2025, 10:03 > Fixed. Thanks! Revision Comment by Sean Nash on 29 January 2025, 13:58 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-139-3#c21269 "override concentrate pump target speed:" Reply by Michael Garthwaite on 06 February 2025, 10:03 > Fixed. Thanks! Revision Comment by Sean Nash on 29 January 2025, 13:59 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-139-3#c21270 "..measured concentrate pump speed: " Reply by Michael Garthwaite on 06 February 2025, 10:03 > Fixed. Thanks! Revision Comment by Sean Nash on 29 January 2025, 14:00 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-139-3#c21271 ".. concentrate pump parked status ..". Reply by Michael Garthwaite on 06 February 2025, 10:03 > Fixed. Thanks! Revision Comment by Sean Nash on 29 January 2025, 14:00 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-139-3#c21272 ".. concentrate pump park fault .." Reply by Michael Garthwaite on 06 February 2025, 10:02 > Fixed. Thanks! Revision Comment by Sean Nash on 29 January 2025, 14:01 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-139-3#c21273 Refactor names. Reply by Michael Garthwaite on 06 February 2025, 10:01 > Fixed. Thanks! Revision Comment by Sean Nash on 29 January 2025, 14:01 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-139-3#c21274 " - for concentrate pump: " Reply by Michael Garthwaite on 06 February 2025, 10:01 > Fixed. Thanks! ---------------------------------------- File: leahi_dialin/dd/modules/dialysate_pump.py Revision Comment by Vinayakam Mani on 10 February 2025, 12:25 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-139-3#c21388 change filename to 'dilaysate_pump'. Revision Comment by Sean Nash on 10 February 2025, 10:25 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-139-3#c21367 Refactor per f/w naming. Revision Comment by Sean Nash on 10 February 2025, 10:26 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-139-3#c21368 Refactor per f/w naming. Revision Comment by Vinayakam Mani on 10 February 2025, 12:27 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-139-3#c21389 dialysate_pumps_sync? also the comments underneath to remove concentrate pumps. Reply by Michael Garthwaite on 12 February 2025, 12:57 > Fixed. Thanks! Revision Comment by Sean Nash on 10 February 2025, 10:26 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-139-3#c21369 DG should be DD. ---------------------------------------- File: leahi_dialin/dd/modules/pressure_sensors.py Revision Comment by Sean Nash on 10 February 2025, 13:37 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-139-3#c21405 pressure_sensors.py Reply by Michael Garthwaite on 13 February 2025, 08:27 > Fixed. Thanks! Revision Comment by Sean Nash on 10 February 2025, 13:38 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-139-3#c21406 Refactor per f/w naming. Revision Comment by Sean Nash on 10 February 2025, 13:38 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-139-3#c21407 Refactor per f/w naming. Revision Comment by Sean Nash on 10 February 2025, 13:38 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-139-3#c21408 DG should be DD. Reply by Michael Garthwaite on 12 February 2025, 11:28 > Fixed. Thanks! Revision Comment by Sean Nash on 10 February 2025, 13:39 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-139-3#c21409 DG should be DD. Reply by Michael Garthwaite on 12 February 2025, 11:28 > Fixed. Thanks! Revision Comment by Sean Nash on 10 February 2025, 13:39 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-139-3#c21410 DG should be DD. Reply by Michael Garthwaite on 12 February 2025, 11:28 > Fixed. Thanks! Revision Comment by Sean Nash on 10 February 2025, 13:39 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-139-3#c21411 Not conductivity. Reply by Michael Garthwaite on 12 February 2025, 11:27 > Fixed. Thanks! Revision Comment by Sean Nash on 10 February 2025, 13:40 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-139-3#c21412 Not conductivity. Reply by Michael Garthwaite on 12 February 2025, 11:27 > Fixed. Thanks! Revision Comment by Sean Nash on 10 February 2025, 13:40 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-139-3#c21414 Filtered pressure Reply by Michael Garthwaite on 12 February 2025, 11:27 > Fixed. Thanks! Revision Comment by Sean Nash on 10 February 2025, 13:40 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-139-3#c21413 DG should be DD. Reply by Michael Garthwaite on 12 February 2025, 11:27 > Fixed. Thanks! Revision Comment by Sean Nash on 10 February 2025, 13:41 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-139-3#c21416 Not pressure. Filtered temperature. Also, ask Vinay if this should be moved to temperature_sensors class. Reply by Vinayakam Mani on 10 February 2025, 17:20 > I guess Eliza mentioned not to move it to temperature > class/module unless otherwise it has own Part ID in flow path > (like conductivity sensor temperature). Reply by Michael Garthwaite on 11 February 2025, 11:35 > is this resolved? ---------------------------------------- File: leahi_dialin/dd/modules/balancing_chamber.py Revision Comment by Sean Nash on 29 January 2025, 13:55 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-139-3#c21264 ".. the balancing chamber switch ...". Reply by Michael Garthwaite on 06 February 2025, 10:02 > Fixed. Thanks! Revision Comment by Vinayakam Mani on 10 February 2025, 10:13 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-139-3#c21366 There is additional dialin command that needs to be supported for message ID: MSG_ID_DD_BC_SWITCH_ONLY_START_STOP_OVERRIDE_REQUEST. Reply by Michael Garthwaite on 12 February 2025, 12:59 > Fixed. Thanks! ---------------------------------------- File: leahi_dialin/dd/modules/gen_dialysate.py Revision Comment by Sean Nash on 10 February 2025, 10:33 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-139-3#c21371 Should be MSG_ID_DD_GEN_DIALYSATE_MODE_DATA. Revision Comment by Sean Nash on 10 February 2025, 10:29 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-139-3#c21370 Refactor per f/w naming. Revision Comment by Sean Nash on 10 February 2025, 10:34 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-139-3#c21372 Not balancing chamber. This is Gen Dialysate broadcast handler. Reply by Sean Nash on 12 February 2025, 11:31 > Function name should change as well. Reply by Michael Garthwaite on 12 February 2025, 12:56 > Fixed. Thanks! Revision Comment by Sean Nash on 10 February 2025, 11:19 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-139-3#c21377 Does this belong in this class? Should be in temperature_sensors? Or is this a target temperature from TD? Work with Vinay to sort out. Reply by Michael Garthwaite on 12 February 2025, 11:20 > This is the target temperature from the TD. Reply by Sean Nash on 12 February 2025, 11:32 > Maybe add the word "target" in function name and > description to clarify for Dialin users. Reply by Michael Garthwaite on 12 February 2025, 12:57 > Fixed. Thanks! ---------------------------------------- File: leahi_dialin/dd/modules/conductivity_sensors.py Revision Comment by Vinayakam Mani on 10 February 2025, 12:23 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-139-3#c21387 Update the header copy right year and author name as yours (also last and original date) across all files. Reply by Michael Garthwaite on 12 February 2025, 11:21 > both the original and last will be automatically updated once > we have automated builds running. Revision Comment by Sean Nash on 10 February 2025, 09:20 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-139-3#c21360 Refactor per f/w naming. Reply by Michael Garthwaite on 12 February 2025, 12:57 > Fixed. Thanks! Revision Comment by Sean Nash on 10 February 2025, 09:20 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-139-3#c21361 DG should be DD. Reply by Michael Garthwaite on 12 February 2025, 12:57 > Fixed. Thanks! Revision Comment by Sean Nash on 10 February 2025, 09:20 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-139-3#c21362 Refactor per f/w naming. Reply by Michael Garthwaite on 12 February 2025, 12:57 > Fixed. Thanks! Revision Comment by Sean Nash on 10 February 2025, 09:21 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-139-3#c21363 Specify DD throughout DD classes in function headers and console output text to make it clear we are talking about DD component. DD and RO share a lot of components so we want to be specific to remove ambiguity. e.g. ".. DD conductivity sensor data messages.". Reply by Michael Garthwaite on 12 February 2025, 12:59 > Fixed. Thanks! Revision Comment by Sean Nash on 10 February 2025, 09:24 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-139-3#c21364 DG should be DD. Reply by Michael Garthwaite on 12 February 2025, 12:59 > Fixed. Thanks! Revision Comment by Vinayakam Mani on 10 February 2025, 12:20 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-139-3#c21386 Message ID should be MSG_ID_DD_CONDUCTIVITY_SENSOR_TEMPERATURE_OVERRIDE_REQUEST Reply by Michael Garthwaite on 12 February 2025, 12:59 > Fixed. Thanks! ---------------------------------------- File: leahi_dialin/dd/modules/levels.py Revision Comment by Sean Nash on 10 February 2025, 12:47 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-139-3#c21391 levels.py Reply by Michael Garthwaite on 12 February 2025, 12:50 > Fixed. Thanks! Revision Comment by Sean Nash on 10 February 2025, 12:48 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-139-3#c21392 Refactor variable names per f/w naming. Reply by Michael Garthwaite on 12 February 2025, 12:50 > Fixed. Thanks! Revision Comment by Sean Nash on 10 February 2025, 12:49 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-139-3#c21393 levels_sync? Reply by Michael Garthwaite on 12 February 2025, 12:50 > Fixed. Thanks! Revision Comment by Sean Nash on 10 February 2025, 12:49 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-139-3#c21394 Not heaters. Levels. Reply by Michael Garthwaite on 12 February 2025, 12:50 > Fixed. Thanks! Revision Comment by Sean Nash on 10 February 2025, 12:50 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-139-3#c21396 DD levels broadcast interval override. Reply by Michael Garthwaite on 12 February 2025, 12:50 > Fixed. Thanks! Revision Comment by Sean Nash on 10 February 2025, 12:50 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-139-3#c21395 DG should be DD. Reply by Michael Garthwaite on 12 February 2025, 12:50 > Fixed. Thanks! Revision Comment by Sean Nash on 10 February 2025, 12:51 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-139-3#c21397 Not heaters. DD Levels. Reply by Michael Garthwaite on 12 February 2025, 12:50 > Fixed. Thanks! Revision Comment by Sean Nash on 10 February 2025, 12:53 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-139-3#c21399 Not heater duty cycle. DD Level sensor override. Reply by Michael Garthwaite on 12 February 2025, 12:50 > Fixed. Thanks! Revision Comment by Sean Nash on 10 February 2025, 12:53 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-139-3#c21398 DG should be DD. Reply by Michael Garthwaite on 12 February 2025, 12:50 > Fixed. Thanks! ---------------------------------------- File: leahi_dialin/dd/modules/temperature_sensors.py Revision Comment by Sean Nash on 10 February 2025, 13:42 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-139-3#c21417 Refactor per f/w naming. Reply by Michael Garthwaite on 11 February 2025, 11:20 > Fixed. Thanks! Revision Comment by Vinayakam Mani on 10 February 2025, 17:23 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-139-3#c21424 Need to conductivity sensor temperatures. Reply by Michael Garthwaite on 11 February 2025, 11:20 > Fixed. Thanks! Revision Comment by Sean Nash on 10 February 2025, 14:22 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-139-3#c21418 Temperature sensor read counter value. And is there also an override for error counter? Reply by Michael Garthwaite on 11 February 2025, 11:08 > There is currently no FW implementation of an error counter > override nor a MSG_ID defined. Reply by Sean Nash on 11 February 2025, 12:51 > Ok, but still need to resolve first part of my comment. > This is not an override for temperature value. It is > override for the fpga read counter of the temperature > sensor. Reply by Michael Garthwaite on 12 February 2025, 11:26 > Fixed. Thanks! Revision Comment by Sean Nash on 10 February 2025, 14:23 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-139-3#c21419 Barometer sensor read counter value. Reply by Michael Garthwaite on 11 February 2025, 11:20 > Fixed. Thanks! Revision Comment by Sean Nash on 11 February 2025, 12:52 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-139-3#c21454 Not conductivity. Reply by Michael Garthwaite on 12 February 2025, 11:26 > Fixed. Thanks! Revision Comment by Sean Nash on 10 February 2025, 14:24 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-139-3#c21420 Barometer sensor CRC value. Reply by Michael Garthwaite on 11 February 2025, 11:20 > Fixed. Thanks! ---------------------------------------- File: leahi_dialin/dd/proxies/ro_proxy.py Revision Comment by Sean Nash on 11 February 2025, 09:02 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-139-3#c21430 Not buttons.py. Reply by Michael Garthwaite on 11 February 2025, 11:21 > Fixed. Thanks! Revision Comment by Sean Nash on 11 February 2025, 09:03 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-139-3#c21432 HD buttons? Reply by Michael Garthwaite on 11 February 2025, 11:21 > Fixed. Thanks! Revision Comment by Sean Nash on 11 February 2025, 09:03 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-139-3#c21433 Correct function details. Reply by Michael Garthwaite on 11 February 2025, 11:21 > Fixed. Thanks! --- ID: LEAHI-DIALIN-LEAH-139-3 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-139-3 Title: LEAH-139-dial-dd-base-object Statement of Objectives: * Merge branch 'LEAH-142-dial-td-base-object' into LEAH-139-dial-dd-base-object * Added directories for dd modules * WIP on LEAH-139-dial-dd-base-object * DD temp and valves. updated CAN channels * Merge branch 'LEAH-142-dial-td-base-object' into LEAH-139-dial-dd-base-object * Updated folder naming. Fixed pathing. Fixed relative importing DD class should now create. * Updated DD valves * fixed dd levels and pressure sensors. * WIP on develop added dialysate start stop override cmd * updated levels handler. Fixed pressure sensor counter overrides from floats to ints. * commented out interval checkin until FW implementation. * updated proxy commands for demo. Updated message IDs * fixed circular import reference * WIP on develop fixed various issues in dd modules * WIP on develop fixed dd set start stop cmds * fixed concentrate pump handler to be in the correct order. * Balancing chamber module and gen dialysate overrides * moved cmd_td_send_dd_gen_dialysate_request to dd.td_proxy instead of td.dd_proxy * added balancing chamber and gen dialysate classes to base DD object * fixed valve state all not updating * fixed missing valve bits in all valve states * fixed valve all states in dd handler * Updated DD concentrate handler. Updated pressure handler. Updated valve positions * updated dd documentation. * WIP on develop updated dd valve positioning * WIP on develop fixed concentrate pump handler * fixed concentrate pump handler * updated start stop to include volume parameter * heaters target temperature override * Updated latest dd changes to branch. Implemented Piston Pumps module. * DD integration * Merge branch 'staging' into LEAH-139-dial-dd-base-object State: Closed Summary: Author: Michael Garthwaite Moderator: Michael Garthwaite Reviewers: (4 active, 2 completed*) Sean Nash (*) Tiffany Mejia (*) jpaguio Vinayakam Mani Dara Navaei Behrouz NematiPour