This is a list of all comments for LEAHI-DIALIN-LEAH-142-2.

Review Summary: No summary


----------------------------------------
File: leahi-dialin/common/alarm_defs.py
Revision Comment by Sean Nash on 12 November 2024, 09:23 
https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-142-2#c20891

  Update to latest in staging branch.

  Reply by Michael Garthwaite on 18 November 2024, 13:34
  > Fixed. Thanks!

----------------------------------------
File: leahi-dialin/common/msg_ids.py
Revision Comment by Sean Nash on 12 November 2024, 09:22 
https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-142-2#c20890

  Update to latest in staging branch.

  Reply by Michael Garthwaite on 18 November 2024, 13:34
  > Fixed. Thanks!

----------------------------------------
File: leahi-dialin/common/td_defs.py
Revision Comment by Sean Nash on 12 November 2024, 09:20 
https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-142-2#c20886

  HD s/b TD.  States not really defined yet - ok to leave as is
  for now.

  Reply by Michael Garthwaite on 18 November 2024, 13:34
  > Fixed. Thanks!

Revision Comment by Sean Nash on 12 November 2024, 09:20 
https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-142-2#c20887

  HD s/b TD.

  Reply by Michael Garthwaite on 18 November 2024, 13:34
  > Fixed. Thanks!

Revision Comment by Sean Nash on 12 November 2024, 09:20 
https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-142-2#c20888

  HD s/b TD.

  Reply by Michael Garthwaite on 18 November 2024, 13:34
  > Fixed. Thanks!

Revision Comment by Sean Nash on 12 November 2024, 09:21 
https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-142-2#c20889

  HD s/b TD.

  Reply by Michael Garthwaite on 18 November 2024, 13:34
  > Fixed. Thanks!

----------------------------------------
File: leahi-dialin/td/pressure_sensors.py
Revision Comment by Sean Nash on 12 November 2024, 09:26 
https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-142-2#c20894

  Update to match current broadcast payload.

  Reply by Michael Garthwaite on 18 November 2024, 13:33
  > Fixed. Thanks!

Revision Comment by Sean Nash on 12 November 2024, 09:27 
https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-142-2#c20895

  For this class (I would just name the class pressure instead of
  pressure_sensors) you need to look at the PressureSensors
  driver and the Pressures monitor f/w units.  The monitor unit
  has an override for broadcast interval.  
  FYI - this type of thing will be common in Leahi where we split
  f/w into two units: 1) low level driver and 2) higher level
  controller or monitor.  So keep any eye out for this when
  matching functionality to what f/w is supporting.

  Reply by Michael Garthwaite on 18 November 2024, 13:33
  > Fixed. Thanks!

----------------------------------------
File: leahi_dialin/common/alarm_defs.py
Revision Comment by Sean Nash on 10 December 2024, 13:04 
https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-142-2#c21025

  Remove blank line.

  Reply by Michael Garthwaite on 16 December 2024, 13:42
  > Fixed. Thanks!

----------------------------------------
File: leahi_dialin/common/msg_ids.py
Revision Comment by Sean Nash on 10 December 2024, 13:06 
https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-142-2#c21026

  Missing RO Dialin messages.

  Reply by Michael Garthwaite on 16 December 2024, 13:41
  > RO messages are in the RO branch

----------------------------------------
File: leahi_dialin/common/ui_defs.py
Revision Comment by Sean Nash on 10 December 2024, 13:09 
https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-142-2#c21027

  No such thing as UF off or completed state.  Remove 3 and 4.

  Reply by Michael Garthwaite on 16 December 2024, 13:43
  > Fixed. Thanks!

----------------------------------------
File: leahi_dialin/td/modules/air_trap.py
Revision Comment by Sean Nash on 10 December 2024, 13:16 
https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-142-2#c21028

  _hd_ should be _td_ OR just removed - no need to say TD since
  there is only one air trap in the system which belongs to the
  TD.

  Reply by Michael Garthwaite on 16 December 2024, 13:43
  > Fixed. Thanks!

----------------------------------------
File: leahi_dialin/td/modules/switches.py
Revision Comment by Sean Nash on 10 December 2024, 13:31 
https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-142-2#c21029

  Should status array be index by .value instead of .name?

  Reply by Michael Garthwaite on 16 December 2024, 13:37
  > This is a dictionary, so its by name.

----------------------------------------
File: leahi_dialin/td/modules/valves.py
Revision Comment by Sean Nash on 10 December 2024, 13:32 
https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-142-2#c21030

  Should be Treatment Delivery (TD).

  Reply by Michael Garthwaite on 16 December 2024, 13:43
  > Fixed. Thanks!

Revision Comment by Sean Nash on 10 December 2024, 13:33 
https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-142-2#c21031

  Typically, handlers are positioned above command functions.

  Reply by Michael Garthwaite on 16 December 2024, 13:42
  > Fixed. Thanks!

Revision Comment by Sean Nash on 10 December 2024, 13:35 
https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-142-2#c21032

  vlv_name should be vlv_id?

  Reply by Michael Garthwaite on 16 December 2024, 13:38
  > This is a dictionary so the key is by name


---

ID: LEAHI-DIALIN-LEAH-142-2 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-142-2

Title: LEAHI-DIALIN-LEAH-142_Dial TD Base Object
Statement of Objectives:


State: Closed

Summary: 

Author: Michael Garthwaite
Moderator: Michael Garthwaite
Reviewers: (4 active, 2 completed*)
     Sean Nash   (*)
     Tiffany Mejia   (*)
     jpaguio
     Vinayakam Mani
     Dara Navaei
     Behrouz NematiPour