This is a list of all comments for LEAHI-FWCOMMON-LDT-2116-1.

Review Summary: No summary


----------------------------------------
File: PIControllers.c
Revision Comment by Sean Nash on 21 November 2025, 08:49 
https://devapps.diality.us/cru/LEAHI-FWCOMMON-LDT-2116-1#c25211

  Consider increasing even more.  May 50 or even 100.

  Reply by Michael Garthwaite on 18 December 2025, 11:00
  > increasing it to 50 would cause instability in our testing.
  > 25 seems to keep it stable at the moment

    Reply by Sean Nash on 18 December 2025, 15:01
    > That suggests that our coefficient(s) are too aggressive
    > (in situations where it looks unstable).  Not directly due
    > to max step size, so we shouldn't reduce it for this
    > reason.  I believe 25 will negatively impact our
    > responsiveness in situations where our error is larger than
    > 25 mL/min.
    > So instability could be due to:
    > 1) coefficient(s) are too strong or
    > 2) may need more than one set of coefficients (e.g.
    > coefficients need to change according to Qd or state or ...
    > because the relationship between output and feedback
    > changes)


---

ID: LEAHI-FWCOMMON-LDT-2116-1 https://devapps.diality.us/cru/LEAHI-FWCOMMON-LDT-2116-1

Title: LEAHI-FWCOMMON-LDT-2116_IOFP - Evaluate closing P39 during tank full state
Statement of Objectives:


State: Closed

Summary: 

Author: Michael Garthwaite
Moderator: Michael Garthwaite
Reviewers: (6 active, 1 completed*)
     Sean Nash   (*)
     Nicholas Ramirez
     jpaguio
     Vinayakam Mani
     Dara Navaei
     Behrouz NematiPour
     Stephen Quong