This is a list of all comments for LEAHI-TESTSUITES-LDT-1057-1. Review Summary: No summary General Comment by Nicholas Ramirez on 20 October 2025, 09:08 https://devapps.diality.us/cru/LEAHI-TESTSUITES-LDT-1057-1#c24733 The test suite is missing an update to the suite.conf file that adds your test case to the test suite. Please push the file with the addition of your test case ---------------------------------------- File: suite_leahi/shared/scripts/names.py Revision Comment by Nicholas Ramirez on 16 October 2025, 10:46 https://devapps.diality.us/cru/LEAHI-TESTSUITES-LDT-1057-1#c24684 remove if not being used Revision Comment by Behrouz NematiPour on 27 October 2025, 12:38 https://devapps.diality.us/cru/LEAHI-TESTSUITES-LDT-1057-1#c24861 Could you remind me what the difference is between this one, "exportLogsText", and the one in line 29, "settingsHomeExportLogs". Reply by Vendor - TEL - Sivvanarayana Kurapati on 29 October 2025, 11:54 > The Objects have been updated for clarity: > > exportLogsText → o_ExportLogsPageTitleText (refers to the > Export Log page title) > > settingsHomeExportLogs → o_DeviceSettingsTitleText (refers to > the Export Log text on the Device Settings page) Revision Comment by Behrouz NematiPour on 27 October 2025, 12:34 https://devapps.diality.us/cru/LEAHI-TESTSUITES-LDT-1057-1#c24859 Please use more meaningful names. The combobox is too general. Reply by Vendor - TEL - Sivvanarayana Kurapati on 29 October 2025, 11:58 > updated combobox to o_LogTypeComboBox. Revision Comment by Behrouz NematiPour on 27 October 2025, 12:35 https://devapps.diality.us/cru/LEAHI-TESTSUITES-LDT-1057-1#c24860 Same here. And all the other same instances. - Please add the container/use case in the name if the object is not generally unique. - Add the type at the end if it is not redundant. Example: - o_SettigsExportLogs_ProgressRect Reply by Vendor - TEL - Sivvanarayana Kurapati on 29 October 2025, 12:05 > Updated the object names as suggested. Reply by Behrouz NematiPour on 30 October 2025, 14:18 > It is ok for now, but from lines 11 to 19, there are still > some object names that need to be refactored. > Will be mentioned in later reviews, Revision Comment by Behrouz NematiPour on 27 October 2025, 12:42 https://devapps.diality.us/cru/LEAHI-TESTSUITES-LDT-1057-1#c24862 Do not use "text" to identify the object; once translated, it cannot be found anymore. Reply by Vendor - TEL - Sivvanarayana Kurapati on 29 October 2025, 12:07 > removed the "text" as suggested. Revision Comment by Nicholas Ramirez on 16 October 2025, 10:49 https://devapps.diality.us/cru/LEAHI-TESTSUITES-LDT-1057-1#c24686 align "unamed" to others Revision Comment by Behrouz NematiPour on 27 October 2025, 12:31 https://devapps.diality.us/cru/LEAHI-TESTSUITES-LDT-1057-1#c24858 All the object names shall start with '_'. Please update when fixed on the SW. [~nramirez], as we talked, that should be updated when we have a chance, thanks. It is fine if we address this later. Reply by Vendor - TEL - Sivvanarayana Kurapati on 29 October 2025, 12:08 > updated all objects names started with o_. Revision Comment by Behrouz NematiPour on 27 October 2025, 12:29 https://devapps.diality.us/cru/LEAHI-TESTSUITES-LDT-1057-1#c24857 Please use consistent object names, all starting with o_, to make them easier to identify in the code and debug messages. Reply by Vendor - TEL - Sivvanarayana Kurapati on 29 October 2025, 12:08 > updated all objects names started with o_. Revision Comment by Nicholas Ramirez on 29 October 2025, 16:27 https://devapps.diality.us/cru/LEAHI-TESTSUITES-LDT-1057-1#c24929 lets try and avoid using the occurrence property and instead get the parent object which should be a TouchGrid qml component then find the children and find the object in the grid by testing theText property of the child object "Export Logs" Reply by Vendor - TEL - Sivvanarayana Kurapati on 03 November 2025, 10:21 > Updated as suggested. ---------------------------------------- File: suite_leahi/tst_service_export_logs/test.py Revision Comment by Nicholas Ramirez on 24 October 2025, 11:40 https://devapps.diality.us/cru/LEAHI-TESTSUITES-LDT-1057-1#c24799 1. Please add the comment block as discussed 2. Upload the test results onto https://diality.atlassian.net/browse/LDT-1059 Reply by Vendor - TEL - Sivvanarayana Kurapati on 03 November 2025, 10:20 > Added comment block and uploaded test report onto Jira. Revision Comment by Nicholas Ramirez on 14 October 2025, 09:12 https://devapps.diality.us/cru/LEAHI-TESTSUITES-LDT-1057-1#c24635 if this is added by us please add and push in the test suite. My test suite can not run Reply by Nicholas Ramirez on 15 October 2025, 08:04 > The configuration is from Denali. Please lets port in what we > are using into a new one as part of this test suite Reply by Vendor - TEL - Sivvanarayana Kurapati on 16 October 2025, 10:05 > Updated. Revision Comment by Behrouz NematiPour on 27 October 2025, 13:05 https://devapps.diality.us/cru/LEAHI-TESTSUITES-LDT-1057-1#c24868 I would move these navigations into a py file like navigation.py to ve used in other places. Reply by Vendor - TEL - Sivvanarayana Kurapati on 29 October 2025, 12:12 > We're using this method specifically in this file, so for now > it will remain in test.py Reply by Behrouz NematiPour on 30 October 2025, 14:09 > That is fine for now, but please think ahead and move it as > soon as you have used it elsewhere. > Also, by moving it to a more general place, others will > notice and use it, instead of duplicating. Revision Comment by Nicholas Ramirez on 20 October 2025, 09:13 https://devapps.diality.us/cru/LEAHI-TESTSUITES-LDT-1057-1#c24734 This need a wait to find the object.. , timeout_ms=1000 Revision Comment by Nicholas Ramirez on 16 October 2025, 11:02 https://devapps.diality.us/cru/LEAHI-TESTSUITES-LDT-1057-1#c24687 Please remove all waits as they are not needed. If the object is not being found use the timeout instead. {code}     export_log_text = utility.get_object_from_names(names.exportLogsText, error_message = "export log text object missing", timeout_ms=1000){code} Revision Comment by Nicholas Ramirez on 20 October 2025, 09:16 https://devapps.diality.us/cru/LEAHI-TESTSUITES-LDT-1057-1#c24735 after the mouse click and before the exporty_log_status line is the only place we need utils.waitForGUI(1) as we need to wait for the progress message to appear Revision Comment by Behrouz NematiPour on 27 October 2025, 12:59 https://devapps.diality.us/cru/LEAHI-TESTSUITES-LDT-1057-1#c24866 why is this line here? Reply by Vendor - TEL - Sivvanarayana Kurapati on 29 October 2025, 12:13 > removed the line "app_context = None". Revision Comment by Behrouz NematiPour on 27 October 2025, 12:57 https://devapps.diality.us/cru/LEAHI-TESTSUITES-LDT-1057-1#c24865 1) Always call this like in the def main() function, to make it obvious. 2) Please do not use the "-l" option, which is only for debugging and should not be used as a reliable option; it can be removed at any point in time. Reply by Vendor - TEL - Sivvanarayana Kurapati on 29 October 2025, 12:15 > - startApplication method is moved to def main() function. > - '-l' is removed and added '-q' Revision Comment by Behrouz NematiPour on 27 October 2025, 13:07 https://devapps.diality.us/cru/LEAHI-TESTSUITES-LDT-1057-1#c24869 I would move this in the application_init.py Reply by Vendor - TEL - Sivvanarayana Kurapati on 29 October 2025, 12:19 > removed the method def_stop_application(), because not using > it in test script. Revision Comment by Behrouz NematiPour on 27 October 2025, 13:02 https://devapps.diality.us/cru/LEAHI-TESTSUITES-LDT-1057-1#c24867 Shouldn't it be better defined in utility.py, or application_init.py? Reply by Vendor - TEL - Sivvanarayana Kurapati on 29 October 2025, 12:21 > moved to application_init.py Revision Comment by Nicholas Ramirez on 23 October 2025, 16:15 https://devapps.diality.us/cru/LEAHI-TESTSUITES-LDT-1057-1#c24794 Please update to add in the real way to get to the settings screen 1. Start up application 2. Change opmode to standby 3. Select Settings 4. Select Export logs. Please Update on every time applications opens Reply by Vendor - TEL - Sivvanarayana Kurapati on 29 October 2025, 12:21 > Updated as suggested. Reply by Vendor - TEL - Sivvanarayana Kurapati on 03 November 2025, 10:17 > Updated as per the suggestion. --- ID: LEAHI-TESTSUITES-LDT-1057-1 https://devapps.diality.us/cru/LEAHI-TESTSUITES-LDT-1057-1 Title: LEAHI-TESTSUITES-LDT-1057_Device Settings - SW - 02 - Export Log - Q&R Statement of Objectives: State: Closed Summary: Author: Vendor - TEL - Sivvanarayana Kurapati Moderator: Behrouz NematiPour Reviewers: (8 active, 1 completed*) Nicholas Ramirez (*) Sean Nash jpaguio Tiffany Mejia Michael Garthwaite Dara Navaei Vendor - TEL - Shivaprasad Basavaraju Stephen Quong Vendor - TEL - Divya Sree Nidamamidi