This is a list of all comments for LEAHI-TESTSUITES-LDT-1454-1.

Review Summary: No summary

General Comment by Nicholas Ramirez on 05 December 2025, 14:48 
https://devapps.diality.us/cru/LEAHI-TESTSUITES-LDT-1454-1#c25598

  Please add the test case to the suite.conf

General Comment by Vendor - TEL - Divya Sree Nidamamidi on 09 December 2025, 03:11 
https://devapps.diality.us/cru/LEAHI-TESTSUITES-LDT-1454-1#c25651

  Added the test case in suite.conf


----------------------------------------
File: suite_leahi/tst_ultrafiltration/test.py
Revision Comment by Nicholas Ramirez on 16 December 2025, 10:33 
https://devapps.diality.us/cru/LEAHI-TESTSUITES-LDT-1454-1#c25829

  The test steps should reflect and match  the sections on the
  generated report https://diality.atlassian.net/browse/LDT-1456.
  Please Update to align test outline with the sections to report
  and please upload a new report.

Revision Comment by Nicholas Ramirez on 03 December 2025, 10:36 
https://devapps.diality.us/cru/LEAHI-TESTSUITES-LDT-1454-1#c25483

  can we make this a more general method and put in a shared file
  and update throughout.. update to something like
  
  {code}def setObjectText(obj, text):
      obj["text"] = text
      return obj:{code}

  Reply by Vendor - TEL - Divya Sree Nidamamidi on 09 December 2025, 03:39
  > Renamed the function set_Object_Text

    Reply by Nicholas Ramirez on 10 December 2025, 13:55
    > in staging the function name is setObjectText() please be
    > consistant

      Reply by Vendor - TEL - Divya Sree Nidamamidi on 11 December 2025, 05:00
      > Renamed the function has setObjectText

  Reply by Vendor - TEL - Divya Sree Nidamamidi on 11 December 2025, 05:01
  > Removed the function and using setObjectText

Revision Comment by Nicholas Ramirez on 03 December 2025, 10:11 
https://devapps.diality.us/cru/LEAHI-TESTSUITES-LDT-1454-1#c25473

  ive noticed  this common method being used in other test cases.
  If its a general method that is used throughout please move
  outside in a shared file and call from there. Please update
  other repositories that use this as well.

  Reply by Vendor - TEL - Divya Sree Nidamamidi on 09 December 2025, 03:40
  > Moved this file into utilty.py file

Revision Comment by Nicholas Ramirez on 03 December 2025, 10:11 
https://devapps.diality.us/cru/LEAHI-TESTSUITES-LDT-1454-1#c25474

  this is a common method as well please move outside and update
  other respositories

  Reply by Vendor - TEL - Divya Sree Nidamamidi on 09 December 2025, 03:40
  > Moved this into utility.py file

----------------------------------------
File: suite_leahi/shared/scripts/configuration/utility.py
Revision Comment by Nicholas Ramirez on 16 December 2025, 10:29 
https://devapps.diality.us/cru/LEAHI-TESTSUITES-LDT-1454-1#c25828

  the method name we have been using is setObjectText.. please
  update for consistancy. Test is failing due to this. please
  test first before committing code

  Reply by Vendor - TEL - Divya Sree Nidamamidi on 16 December 2025, 21:03
  > method name is updated has setObjectText()


---

ID: LEAHI-TESTSUITES-LDT-1454-1 https://devapps.diality.us/cru/LEAHI-TESTSUITES-LDT-1454-1

Title: LEAHI-TESTSUITES-LDT-1454_Ultrafiltration - SW  - 02 - Q&R
Statement of Objectives:


State: Review

Author: Vendor - TEL - Divya Sree Nidamamidi
Moderator: Nicholas Ramirez
Reviewers: (6 active, 0 completed*)
     Tiffany Mejia
     Dara Navaei
     Vendor - TEL - Sivvanarayana Kurapati
     Vendor - TEL - Shivaprasad Basavaraju
     Daniel Ho
     Stephen Quong