RO-LDT-1242-1 RO-LDT-1242_Iofp Finalize Permeate Tank

closed on 05 Sep

Author

Moderator

Reviewers

RO-LDT-1242_Iofp Finalize Permeate Tank

Activity

Details
Objectives
General Comments 0
Unresolved
Resolved
Number of files included: 20

leahi-common 0
- File AlarmDefs.h 7 Remove
- File FPDefs.h 0 Remove
- File MsgDefs.h 0 Remove
leahi-fwcommon 0
- File PIControllers.c 0 Remove
ro-firmware 0
- Folder firmware/App 0
  - Folder Controllers 0
    - File PermeateTank.c 6 Remove
    - File ROPump.c 9 Remove
    - File Valves.c 0 Remove
    - File Valves.h 0 Remove
  - Folder Drivers 0
    - File PressureSensor.c 0 Remove
  - Folder Modes 0
    - File FPModeFault.c 0 Remove
    - File FPOperationModes.c 0 Remove
    - File FlushConcentrate.c 0 Remove
    - File FlushPermeate.c 2 Remove
    - File InletPressureCheck.c 0 Remove
    - File ModeGenPermeateDefeatured.c 0 Remove
    - File ModePreGenPermeate.c 2 Remove
    - File ModePreGenPermeateDefeatured.c 0 Remove
  - Folder Services 0
    - File AlarmMgmtFP.c 0 Remove
    - File DDInterface.c 0 Remove
    - File SystemCommFP.c 0 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
Michael Garthwaite	Author & Moderator	54m	12	reverted commit. Back to 110 ranking and changed properti...
Sean Nash	Reviewer - Complete	37m	13	Or maybe 110 was correct and fault property should be FAL...
Dara Navaei	Reviewer - 0% reviewed	0m
Behrouz NematiPour	Reviewer - 0% reviewed
Tiffany Mejia	Reviewer - 0% reviewed
Daniel Ho	Reviewer - 0% reviewed
Vinayakam Mani	Reviewer - 0% reviewed
Nicholas Ramirez	Reviewer - 0% reviewed
Raghu Kallala	Reviewer - Complete	35m	1	fault -> FALSE
Total		2h 7m	26

#permalink

Objectives

There are no specific objectives for this review.

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

There are no general comments on this review.

Click to load diff

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: [Crucible Review CR-1\|CR-1]
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

RO-LDT-1242-1

RO-LDT-1242_Iofp Finalize Permeate Tank

RO-LDT-1242-1 26

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time

RO-LDT-1242_Iofp Finalize Permeate Tank

RO-LDT-1242-1 26

Summarize the review outcomes (optional)

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time