This is a list of all comments for RO-LDT-1928-3.

Review Summary: No summary


----------------------------------------
File: firmware/App/Modes/InletPressureCheck.c
Revision Comment by Michael Garthwaite on 18 August 2025, 09:04 
https://devapps.diality.us/cru/RO-LDT-1928-3#c23794

  Please remove unnecessary #include's like ROPump, PermeateTank,
  Conductivity, etc.

  Reply by Raghu Kallala on 19 August 2025, 10:23
  > Removed.

Revision Comment by Sean Nash on 19 August 2025, 13:33 
https://devapps.diality.us/cru/RO-LDT-1928-3#c23836

  Align comments.

  Reply by Raghu Kallala on 20 August 2025, 10:00
  > Done.

Revision Comment by Sean Nash on 19 August 2025, 14:05 
https://devapps.diality.us/cru/RO-LDT-1928-3#c23838

  If check completed, are we stuck in this state forever?

  Reply by Raghu Kallala on 20 August 2025, 09:57
  > Yes, will be in paused state, until we do the PreGen mode
  > again.

    Reply by Sean Nash on 21 August 2025, 09:20
    > If in paused state due to alarm, if alarm is recoverable we
    > would need a way to go back to in progress state when user
    > clears alarm.

      Reply by Michael Garthwaite on 25 August 2025, 15:05
      > Current builds of the FP are not triggering alarms.
      > Alarms and recovery states ( ex: paused states ) will be
      > implemented and covered in
      > https://diality.atlassian.net/browse/LDT-828 once
      > requirement draft is finalized.

Revision Comment by Sean Nash on 19 August 2025, 14:03 
https://devapps.diality.us/cru/RO-LDT-1928-3#c23837

  Is this assignment needed?  Seems like it would already have to
  be FALSE to get into the if.

  Reply by Raghu Kallala on 20 August 2025, 09:58
  > Yeah, I agree.
  > We can remove it

    Reply by Sean Nash on 26 August 2025, 13:38
    > Looks like it's still here.

      Reply by Raghu Kallala on 27 August 2025, 08:14
      > Pushed the commit

Revision Comment by Michael Garthwaite on 18 August 2025, 09:05 
https://devapps.diality.us/cru/RO-LDT-1928-3#c23795

  Dont think we will need to control the permeate tank in this
  state

  Reply by Raghu Kallala on 19 August 2025, 10:23
  > Removed.

----------------------------------------
File: firmware/App/Modes/InletPressureCheck.h
Revision Comment by Sean Nash on 19 August 2025, 13:32 
https://devapps.diality.us/cru/RO-LDT-1928-3#c23834

  Align comments or remove them (not necessary for function
  prototypes).

  Reply by Raghu Kallala on 27 August 2025, 08:12
  > Done

Revision Comment by Michael Garthwaite on 18 August 2025, 09:02 
https://devapps.diality.us/cru/RO-LDT-1928-3#c23793

  Remove commented function header.

  Reply by Raghu Kallala on 19 August 2025, 10:23
  > Removed.

Revision Comment by Sean Nash on 19 August 2025, 13:33 
https://devapps.diality.us/cru/RO-LDT-1928-3#c23835

  Add a blank line before group end marker.

  Reply by Raghu Kallala on 27 August 2025, 08:12
  > Done

----------------------------------------
File: firmware/App/Modes/ModePreGenPermeate.c
Revision Comment by Sean Nash on 27 August 2025, 13:54 
https://devapps.diality.us/cru/RO-LDT-1928-3#c23908

  Follow up with Eliza on TODO question.

  Reply by Raghu Kallala on 28 August 2025, 13:40
  > Calling it regardless of hardware

Revision Comment by Michael Garthwaite on 18 August 2025, 09:01 
https://devapps.diality.us/cru/RO-LDT-1928-3#c23792

  Similar to how we have the if statement above, please assign
  the state to FP_PRE_GENP_FILTER_FLUSH once we complete the
  pressure check.

  Reply by Raghu Kallala on 19 August 2025, 10:23
  > Updated, thanks.


---

ID: RO-LDT-1928-3 https://devapps.diality.us/cru/RO-LDT-1928-3

Title: RO-LDT-1928_Inlet Pressure Check ST
Statement of Objectives:


State: Closed

Summary: 

Author: Raghu Kallala
Moderator: Raghu Kallala
Reviewers: (6 active, 2 completed*)
     Sean Nash   (*)
     Michael Garthwaite   (*)
     Nicholas Ramirez
     Tiffany Mejia
     Vinayakam Mani
     Dara Navaei
     Behrouz NematiPour
     Daniel Ho