This is a list of all comments for RO-LDT-566-1. Review Summary: No summary ---------------------------------------- File: firmware/App/Drivers/PressureSensor.c Revision Comment by Sean Nash on 25 June 2025, 15:30 https://devapps.diality.us/cru/RO-LDT-566-1#c22426 Looks like no longer needed/used. Remove? Reply by Michael Garthwaite on 30 June 2025, 13:46 > im unsure. I thought they would be needed later for an alarm > ( at least for error count ). Id like to keep them until we > know they are no longer needed Reply by Sean Nash on 30 June 2025, 14:30 > Why did we remove the code that deals with read/error > counters if we're unsure? Reply by Michael Garthwaite on 30 June 2025, 17:33 > my mistake. The error count is no longer in the hdd. > Error count functions have been removed Revision Comment by Sean Nash on 21 May 2025, 10:40 https://devapps.diality.us/cru/RO-LDT-566-1#c22053 Remove extra blank line. Reply by Michael Garthwaite on 23 June 2025, 10:14 > fixed. thanks! ---------------------------------------- File: firmware/App/Monitors/Pressure.c Revision Comment by Sean Nash on 21 May 2025, 10:43 https://devapps.diality.us/cru/RO-LDT-566-1#c22054 Update message list spreadsheet to include new fields. Reply by Michael Garthwaite on 23 June 2025, 10:10 > fixed. Thanks! ---------------------------------------- File: firmware/App/Modes/ModeWaterGen.c Revision Comment by Sean Nash on 27 June 2025, 15:01 https://devapps.diality.us/cru/RO-LDT-566-1#c22485 Remove extra blank line. Reply by Michael Garthwaite on 30 June 2025, 14:02 > fixed. thanks! ---------------------------------------- File: firmware/App/Controllers/Heaters.c Revision Comment by Sean Nash on 25 June 2025, 10:48 https://devapps.diality.us/cru/RO-LDT-566-1#c22345 Put back in proper place and use "" instead of <>. Reply by Michael Garthwaite on 25 June 2025, 11:04 > fixed. Revision Comment by Sean Nash on 25 June 2025, 11:06 https://devapps.diality.us/cru/RO-LDT-566-1#c22395 Remove extra blank line. Reply by Michael Garthwaite on 25 June 2025, 11:12 > fixed ---------------------------------------- File: firmware/App/Drivers/ConductivitySensor.c Revision Comment by Sean Nash on 25 June 2025, 15:12 https://devapps.diality.us/cru/RO-LDT-566-1#c22414 Remove extra blank line. Revision Comment by Sean Nash on 25 June 2025, 15:14 https://devapps.diality.us/cru/RO-LDT-566-1#c22415 Remove extra spaces before ]. ---------------------------------------- File: firmware/App/Drivers/FlowSensor.c Revision Comment by Sean Nash on 25 June 2025, 15:18 https://devapps.diality.us/cru/RO-LDT-566-1#c22416 Why are these flow rates floats if FPGA is giving us integers? Reply by Michael Garthwaite on 30 June 2025, 14:11 > reverted it back to S32. Added S32 overrides as well. ---------------------------------------- File: firmware/App/Drivers/SafetyShutdown.h Revision Comment by Sean Nash on 25 June 2025, 15:31 https://devapps.diality.us/cru/RO-LDT-566-1#c22427 Remove extra blank lines. Reply by Michael Garthwaite on 30 June 2025, 14:08 > fixed. thanks! ---------------------------------------- File: firmware/App/Drivers/TemperatureSensor.c Revision Comment by Sean Nash on 25 June 2025, 15:35 https://devapps.diality.us/cru/RO-LDT-566-1#c22430 No longer plural. Reply by Michael Garthwaite on 30 June 2025, 14:07 > fixed. thanks! Revision Comment by Sean Nash on 25 June 2025, 15:42 https://devapps.diality.us/cru/RO-LDT-566-1#c22433 Add blank line between declarations and code. Reply by Michael Garthwaite on 30 June 2025, 14:04 > fixed. thanks! ---------------------------------------- File: firmware/App/Drivers/TemperatureSensor.h Revision Comment by Sean Nash on 25 June 2025, 15:35 https://devapps.diality.us/cru/RO-LDT-566-1#c22429 No longer plural. Reply by Michael Garthwaite on 30 June 2025, 17:33 > fixed. thanks! Revision Comment by Sean Nash on 25 June 2025, 15:33 https://devapps.diality.us/cru/RO-LDT-566-1#c22428 enum name is too generic. Add TEMP to name or remove (I don't think enum name is needed if it's a typedef). Reply by Michael Garthwaite on 30 June 2025, 13:45 > renamed to TemperatureSensors ---------------------------------------- File: firmware/App/Modes/FilterFlush.c Revision Comment by Sean Nash on 27 June 2025, 14:57 https://devapps.diality.us/cru/RO-LDT-566-1#c22479 Remove extra blank line. Reply by Michael Garthwaite on 30 June 2025, 14:03 > fixed. thanks! Revision Comment by Sean Nash on 27 June 2025, 14:57 https://devapps.diality.us/cru/RO-LDT-566-1#c22480 Remove extra blank line. Reply by Michael Garthwaite on 30 June 2025, 14:03 > fixed. thanks! Revision Comment by Sean Nash on 27 June 2025, 14:58 https://devapps.diality.us/cru/RO-LDT-566-1#c22481 Remove blank line. Reply by Michael Garthwaite on 30 June 2025, 14:02 > fixed. thanks! Revision Comment by Sean Nash on 27 June 2025, 14:58 https://devapps.diality.us/cru/RO-LDT-566-1#c22482 2 blank lines for test support banner. Reply by Michael Garthwaite on 30 June 2025, 14:02 > fixed. thanks! ---------------------------------------- File: firmware/App/Modes/ModeFault.h Revision Comment by Sean Nash on 27 June 2025, 14:59 https://devapps.diality.us/cru/RO-LDT-566-1#c22483 Should we update group names (RO to FP)? Reply by Michael Garthwaite on 30 June 2025, 13:42 > newer files and groups have FP. Those that have RO will be > refactored in next branch ---------------------------------------- File: firmware/App/Modes/ModeStandby.c Revision Comment by Sean Nash on 27 June 2025, 15:00 https://devapps.diality.us/cru/RO-LDT-566-1#c22484 Blank line between includes and group. ---------------------------------------- File: firmware/App/Modes/ModeWaterPreGen.c Revision Comment by Sean Nash on 27 June 2025, 15:03 https://devapps.diality.us/cru/RO-LDT-566-1#c22486 Blank line between functions. Reply by Michael Garthwaite on 30 June 2025, 17:33 > fixed. thanks! Revision Comment by Sean Nash on 27 June 2025, 15:03 https://devapps.diality.us/cru/RO-LDT-566-1#c22487 Blank line between functions. Reply by Michael Garthwaite on 30 June 2025, 14:02 > fixed. thanks! ---------------------------------------- File: firmware/App/Modes/OperationModes.c Revision Comment by Sean Nash on 27 June 2025, 15:04 https://devapps.diality.us/cru/RO-LDT-566-1#c22489 Remove extra blank line. Reply by Michael Garthwaite on 30 June 2025, 14:01 > fixed. thanks! Revision Comment by Sean Nash on 27 June 2025, 15:05 https://devapps.diality.us/cru/RO-LDT-566-1#c22490 Align all comments in same column. Reply by Michael Garthwaite on 30 June 2025, 14:01 > fixed. thanks! Revision Comment by Sean Nash on 27 June 2025, 15:06 https://devapps.diality.us/cru/RO-LDT-566-1#c22491 Remove extra blank line. Reply by Michael Garthwaite on 30 June 2025, 14:01 > fixed. thanks! ---------------------------------------- File: firmware/App/Modes/OperationModes.h Revision Comment by Sean Nash on 27 June 2025, 15:04 https://devapps.diality.us/cru/RO-LDT-566-1#c22488 Remove extra blank line. Reply by Michael Garthwaite on 30 June 2025, 14:02 > fixed. thanks! ---------------------------------------- File: firmware/App/Monitors/Temperature.c Revision Comment by Sean Nash on 27 June 2025, 15:10 https://devapps.diality.us/cru/RO-LDT-566-1#c22492 Remove extra blank line. Reply by Michael Garthwaite on 30 June 2025, 14:00 > fixed. thanks! ---------------------------------------- File: firmware/App/Services/AlarmMgmtRO.c Revision Comment by Vinayakam Mani on 23 June 2025, 16:53 https://devapps.diality.us/cru/RO-LDT-566-1#c22241 Do you want to update the filename as well to FP? if so, please update files with RO ( FpgaRO, SystemCommRO etc.,) Reply by Michael Garthwaite on 24 June 2025, 10:36 > That'll be in the next branch. Trying to keep the changes > controlled for now ---------------------------------------- File: firmware/App/Services/DDInterface.c Revision Comment by Sean Nash on 27 June 2025, 15:11 https://devapps.diality.us/cru/RO-LDT-566-1#c22494 Remove extra blank line. Reply by Michael Garthwaite on 30 June 2025, 14:00 > fixed. thanks! ---------------------------------------- File: firmware/App/Services/DDInterface.h Revision Comment by Sean Nash on 27 June 2025, 15:11 https://devapps.diality.us/cru/RO-LDT-566-1#c22493 Remove extra blank line. Reply by Michael Garthwaite on 30 June 2025, 14:00 > fixed. thanks! ---------------------------------------- File: firmware/App/Controllers/BoostPump.c Revision Comment by Sean Nash on 25 June 2025, 10:19 https://devapps.diality.us/cru/RO-LDT-566-1#c22312 Remove 2 extra blank lines. Reply by Michael Garthwaite on 25 June 2025, 11:02 > fixed Reply by Sean Nash on 25 June 2025, 15:04 > I don't see fix. Revision Comment by Sean Nash on 25 June 2025, 10:20 https://devapps.diality.us/cru/RO-LDT-566-1#c22314 Add blank line before banner. Revision Comment by Vinayakam Mani on 23 June 2025, 16:34 https://devapps.diality.us/cru/RO-LDT-566-1#c22238 Remove extra line Reply by Michael Garthwaite on 25 June 2025, 10:57 > fixed Revision Comment by Vinayakam Mani on 23 June 2025, 16:33 https://devapps.diality.us/cru/RO-LDT-566-1#c22237 Remove extra line Reply by Michael Garthwaite on 25 June 2025, 10:28 > fixed Revision Comment by Sean Nash on 25 June 2025, 10:21 https://devapps.diality.us/cru/RO-LDT-566-1#c22318 These are floats. Initialize to 0.0F. Reply by Michael Garthwaite on 25 June 2025, 10:28 > fixed Reply by Sean Nash on 25 June 2025, 10:43 > Should be 0.0F (with F suffix). Revision Comment by Sean Nash on 25 June 2025, 10:21 https://devapps.diality.us/cru/RO-LDT-566-1#c22319 Remove blank line. Reply by Michael Garthwaite on 25 June 2025, 10:28 > fixed. Revision Comment by Vinayakam Mani on 23 June 2025, 16:42 https://devapps.diality.us/cru/RO-LDT-566-1#c22239 Please follow the formats for Input and output (across the file/s) Reply by Michael Garthwaite on 25 June 2025, 10:23 > I believe these are in the correct format. is there something > missing? Reply by Sean Nash on 25 June 2025, 10:44 > I assume Vinay is talking about which variables you are > specifying for Inputs and Outputs. > e.g. boostPumpControlMode is an input, but not in list. Reply by Michael Garthwaite on 25 June 2025, 11:02 > got it. fixed. Reply by Vinayakam Mani on 25 June 2025, 11:12 > I mean, for Inputs, outputs, Alarms and Message, use \b > in front of it. > * @details \b Inputs: > * @details \b Outputs: > * @details \b Message \b Sent: > * @details \b Alarms: Reply by Michael Garthwaite on 25 June 2025, 11:25 > got it. fixed Revision Comment by Sean Nash on 25 June 2025, 10:22 https://devapps.diality.us/cru/RO-LDT-566-1#c22320 Remove blank line. Reply by Michael Garthwaite on 25 June 2025, 10:28 > fixed Revision Comment by Sean Nash on 25 June 2025, 10:35 https://devapps.diality.us/cru/RO-LDT-566-1#c22331 function names don't match. Reply by Michael Garthwaite on 25 June 2025, 11:01 > fixed Revision Comment by Sean Nash on 25 June 2025, 10:22 https://devapps.diality.us/cru/RO-LDT-566-1#c22321 Remove blank line. Reply by Michael Garthwaite on 25 June 2025, 10:28 > fixed Revision Comment by Sean Nash on 25 June 2025, 10:36 https://devapps.diality.us/cru/RO-LDT-566-1#c22332 Function names don't match. Reply by Michael Garthwaite on 25 June 2025, 11:01 > fixed Revision Comment by Sean Nash on 25 June 2025, 10:47 https://devapps.diality.us/cru/RO-LDT-566-1#c22344 0.0F. Reply by Michael Garthwaite on 25 June 2025, 11:01 > fixed Revision Comment by Sean Nash on 25 June 2025, 10:37 https://devapps.diality.us/cru/RO-LDT-566-1#c22333 Use 0.0F for floats. Reply by Michael Garthwaite on 25 June 2025, 11:01 > fixed Revision Comment by Sean Nash on 25 June 2025, 10:37 https://devapps.diality.us/cru/RO-LDT-566-1#c22334 Use 0.0F for floats. Reply by Michael Garthwaite on 25 June 2025, 11:01 > fixed Revision Comment by Sean Nash on 25 June 2025, 10:37 https://devapps.diality.us/cru/RO-LDT-566-1#c22335 Remove blank line. Reply by Michael Garthwaite on 25 June 2025, 11:01 > fixed Revision Comment by Sean Nash on 25 June 2025, 10:38 https://devapps.diality.us/cru/RO-LDT-566-1#c22336 Add "F" suffix to 0.0. Reply by Michael Garthwaite on 25 June 2025, 11:01 > fixed Revision Comment by Sean Nash on 25 June 2025, 10:38 https://devapps.diality.us/cru/RO-LDT-566-1#c22337 Inputs should be none. Reply by Michael Garthwaite on 25 June 2025, 11:01 > fixed Revision Comment by Sean Nash on 25 June 2025, 10:39 https://devapps.diality.us/cru/RO-LDT-566-1#c22338 Add blank line before next function. Reply by Michael Garthwaite on 25 June 2025, 11:01 > fixed Revision Comment by Sean Nash on 25 June 2025, 10:39 https://devapps.diality.us/cru/RO-LDT-566-1#c22339 Function names don't match. Reply by Michael Garthwaite on 25 June 2025, 11:01 > fixed Revision Comment by Sean Nash on 25 June 2025, 10:40 https://devapps.diality.us/cru/RO-LDT-566-1#c22340 Copy/paste - update header. Reply by Michael Garthwaite on 25 June 2025, 11:01 > fixed Revision Comment by Sean Nash on 25 June 2025, 10:41 https://devapps.diality.us/cru/RO-LDT-566-1#c22341 Copy/paste - update header. Reply by Michael Garthwaite on 25 June 2025, 11:01 > fixed Revision Comment by Sean Nash on 25 June 2025, 10:18 https://devapps.diality.us/cru/RO-LDT-566-1#c22309 Remove extra blank line. Reply by Michael Garthwaite on 25 June 2025, 10:28 > fixed ---------------------------------------- File: firmware/App/Controllers/BoostPump.h Revision Comment by Sean Nash on 25 June 2025, 10:18 https://devapps.diality.us/cru/RO-LDT-566-1#c22310 Remove extra blank line. Reply by Michael Garthwaite on 25 June 2025, 10:28 > fixed Revision Comment by Sean Nash on 25 June 2025, 10:19 https://devapps.diality.us/cru/RO-LDT-566-1#c22311 Remove 2 extra blank lines. Reply by Michael Garthwaite on 25 June 2025, 10:28 > fixed ---------------------------------------- File: firmware/App/Controllers/ROPump.c Revision Comment by Vinayakam Mani on 23 June 2025, 16:44 https://devapps.diality.us/cru/RO-LDT-566-1#c22240 Remove extra line Reply by Michael Garthwaite on 25 June 2025, 11:04 > fixed. Revision Comment by Sean Nash on 25 June 2025, 10:49 https://devapps.diality.us/cru/RO-LDT-566-1#c22346 Add blank line before banner. Revision Comment by Sean Nash on 25 June 2025, 10:49 https://devapps.diality.us/cru/RO-LDT-566-1#c22347 Remove extra blank line. Revision Comment by Sean Nash on 25 June 2025, 10:50 https://devapps.diality.us/cru/RO-LDT-566-1#c22348 Remove extra blank line. Reply by Michael Garthwaite on 25 June 2025, 11:15 > fixed Revision Comment by Sean Nash on 25 June 2025, 10:50 https://devapps.diality.us/cru/RO-LDT-566-1#c22349 Remove blank line. Reply by Michael Garthwaite on 25 June 2025, 11:14 > fixed Revision Comment by Sean Nash on 25 June 2025, 10:51 https://devapps.diality.us/cru/RO-LDT-566-1#c22350 Add blank line before return. Reply by Michael Garthwaite on 25 June 2025, 11:14 > fixed Revision Comment by Sean Nash on 25 June 2025, 10:51 https://devapps.diality.us/cru/RO-LDT-566-1#c22351 Remove extra space(s) before = or align with = above. Reply by Michael Garthwaite on 25 June 2025, 11:14 > fixed Revision Comment by Sean Nash on 25 June 2025, 10:52 https://devapps.diality.us/cru/RO-LDT-566-1#c22352 Remove blank line. Revision Comment by Sean Nash on 25 June 2025, 10:53 https://devapps.diality.us/cru/RO-LDT-566-1#c22353 Function names don't match. Reply by Michael Garthwaite on 25 June 2025, 11:14 > fixed Revision Comment by Sean Nash on 25 June 2025, 10:53 https://devapps.diality.us/cru/RO-LDT-566-1#c22354 Remove blank line. Revision Comment by Sean Nash on 25 June 2025, 10:53 https://devapps.diality.us/cru/RO-LDT-566-1#c22355 Function names don't match. Reply by Michael Garthwaite on 25 June 2025, 11:14 > fixed Revision Comment by Sean Nash on 25 June 2025, 10:54 https://devapps.diality.us/cru/RO-LDT-566-1#c22356 Use 0.0F for floats. Reply by Sean Nash on 25 June 2025, 11:00 > Remove extra ";". Reply by Michael Garthwaite on 25 June 2025, 11:12 > fixed Revision Comment by Sean Nash on 25 June 2025, 10:55 https://devapps.diality.us/cru/RO-LDT-566-1#c22362 Use 0.0F for floats. Reply by Sean Nash on 25 June 2025, 11:00 > Remove extra ";". Revision Comment by Sean Nash on 25 June 2025, 10:56 https://devapps.diality.us/cru/RO-LDT-566-1#c22363 Use 0.0F for floats. Reply by Sean Nash on 25 June 2025, 11:01 > Remove extra ";". Revision Comment by Sean Nash on 25 June 2025, 10:57 https://devapps.diality.us/cru/RO-LDT-566-1#c22365 Remove blank line. Reply by Michael Garthwaite on 25 June 2025, 11:13 > fixed Revision Comment by Sean Nash on 25 June 2025, 10:57 https://devapps.diality.us/cru/RO-LDT-566-1#c22366 Use "F" suffix for floats. Reply by Sean Nash on 25 June 2025, 11:01 > Remove extra ";". Reply by Michael Garthwaite on 25 June 2025, 11:13 > fixed Revision Comment by Sean Nash on 25 June 2025, 10:57 https://devapps.diality.us/cru/RO-LDT-566-1#c22367 No inputs in this function. Revision Comment by Sean Nash on 25 June 2025, 10:58 https://devapps.diality.us/cru/RO-LDT-566-1#c22368 Copy/paste - update header. Revision Comment by Sean Nash on 25 June 2025, 10:58 https://devapps.diality.us/cru/RO-LDT-566-1#c22369 Copy/paste - update header. ---------------------------------------- File: firmware/App/Controllers/ROPump.h Revision Comment by Sean Nash on 25 June 2025, 10:58 https://devapps.diality.us/cru/RO-LDT-566-1#c22370 Remove blank line. Reply by Michael Garthwaite on 25 June 2025, 11:03 > fixed Revision Comment by Sean Nash on 25 June 2025, 10:59 https://devapps.diality.us/cru/RO-LDT-566-1#c22371 Remove extra blank line. Reply by Michael Garthwaite on 25 June 2025, 11:03 > fixed. ---------------------------------------- File: firmware/App/Drivers/FluidPump.c Revision Comment by Sean Nash on 25 June 2025, 15:22 https://devapps.diality.us/cru/RO-LDT-566-1#c22423 Align comments. Reply by Michael Garthwaite on 30 June 2025, 14:08 > fixed. thanks! Reply by Sean Nash on 30 June 2025, 14:27 > Align ALL comments. Revision Comment by Sean Nash on 25 June 2025, 15:25 https://devapps.diality.us/cru/RO-LDT-566-1#c22424 fluider pump = boost pump? Revision Comment by Sean Nash on 25 June 2025, 15:26 https://devapps.diality.us/cru/RO-LDT-566-1#c22425 Add blank line between declarations and code. Reply by Michael Garthwaite on 30 June 2025, 14:08 > fixed. thanks! ---------------------------------------- File: firmware/App/Drivers/FluidPump.h Revision Comment by Sean Nash on 25 June 2025, 15:20 https://devapps.diality.us/cru/RO-LDT-566-1#c22417 FluidPump.h Reply by Michael Garthwaite on 30 June 2025, 14:09 > fixed. thanks! Revision Comment by Sean Nash on 25 June 2025, 15:20 https://devapps.diality.us/cru/RO-LDT-566-1#c22418 __FLUID_PUMP_H__ Reply by Michael Garthwaite on 30 June 2025, 14:09 > fixed. thanks! Revision Comment by Sean Nash on 25 June 2025, 15:21 https://devapps.diality.us/cru/RO-LDT-566-1#c22419 Fix all copy/paste issues. Reply by Michael Garthwaite on 30 June 2025, 14:09 > fixed. thanks! Revision Comment by Sean Nash on 25 June 2025, 15:21 https://devapps.diality.us/cru/RO-LDT-566-1#c22420 Align values Reply by Michael Garthwaite on 30 June 2025, 14:09 > fixed. thanks! Revision Comment by Sean Nash on 25 June 2025, 15:21 https://devapps.diality.us/cru/RO-LDT-566-1#c22421 Add blank line before a /// comment. I don't think doxygen handles correctly w/o blank line above. Reply by Michael Garthwaite on 30 June 2025, 14:09 > fixed. thanks! Revision Comment by Sean Nash on 25 June 2025, 15:22 https://devapps.diality.us/cru/RO-LDT-566-1#c22422 Remove extra blank line. Reply by Michael Garthwaite on 30 June 2025, 14:11 > fixed. thanks! ---------------------------------------- File: firmware/source/sys_main.c Revision Comment by Sean Nash on 27 June 2025, 15:16 https://devapps.diality.us/cru/RO-LDT-566-1#c22495 Remove blank line. Reply by Michael Garthwaite on 30 June 2025, 14:00 > fixed. thanks! ---------------------------------------- File: AlarmDefs.h Revision Comment by Sean Nash on 23 June 2025, 12:58 https://devapps.diality.us/cru/RO-LDT-566-1#c22228 Add comments to left and remove available comments for last few. Reply by Michael Garthwaite on 23 June 2025, 15:26 > fixed thanks! Revision Comment by Sean Nash on 23 June 2025, 13:00 https://devapps.diality.us/cru/RO-LDT-566-1#c22229 Are all of these really low priority? Check properties. Should probably resemble DG faults in Denali. Reply by Michael Garthwaite on 23 June 2025, 15:25 > updated all the alarms of this story to have their respective > ranks and properties Revision Comment by Sean Nash on 23 June 2025, 15:02 https://devapps.diality.us/cru/RO-LDT-566-1#c22231 Right brackets are all over the place. Please align. Reply by Michael Garthwaite on 24 June 2025, 09:17 > Alarms in their respective rank Revision Comment by Sean Nash on 23 June 2025, 15:03 https://devapps.diality.us/cru/RO-LDT-566-1#c22232 Where are the new FP alarms that should be here? Reply by Michael Garthwaite on 24 June 2025, 10:54 > added ---------------------------------------- File: MsgDefs.h Revision Comment by Tiffany Mejia on 01 July 2025, 14:26 https://devapps.diality.us/cru/RO-LDT-566-1#c22678 align comments Reply by Michael Garthwaite on 01 July 2025, 15:10 > fixed. thanks! Reply by Tiffany Mejia on 01 July 2025, 15:12 > RESOLVED Revision Comment by Sean Nash on 25 June 2025, 10:04 https://devapps.diality.us/cru/RO-LDT-566-1#c22305 Dialin had some new message IDs for serial # and such. I don't see them here. Reply by Michael Garthwaite on 25 June 2025, 10:11 > Dont see them in the excel sheet or in the common repo. Reply by Sean Nash on 25 June 2025, 10:13 > Then why are they added to Dialin? Reply by Michael Garthwaite on 25 June 2025, 11:08 > See Dialin comment ---------------------------------------- File: RODefs.h Revision Comment by Sean Nash on 25 June 2025, 15:08 https://devapps.diality.us/cru/RO-LDT-566-1#c22412 Need comments for each enum Reply by Michael Garthwaite on 30 June 2025, 14:13 > fixed. thanks! Revision Comment by Sean Nash on 25 June 2025, 15:09 https://devapps.diality.us/cru/RO-LDT-566-1#c22413 Align comments. Reply by Michael Garthwaite on 30 June 2025, 14:12 > fixed. thanks! Revision Comment by Vinayakam Mani on 23 June 2025, 16:14 https://devapps.diality.us/cru/RO-LDT-566-1#c22235 Remove extra line. Reply by Michael Garthwaite on 30 June 2025, 14:00 > fixed. thanks! ---------------------------------------- File: CommBuffers.h Revision Comment by Vinayakam Mani on 23 June 2025, 16:24 https://devapps.diality.us/cru/RO-LDT-566-1#c22236 Please update the filename (seems CCS auto updates when changing file name) Reply by Michael Garthwaite on 24 June 2025, 10:32 > It doesnt consider our include settings when it does the > update. good eye and fixed. --- ID: RO-LDT-566-1 https://devapps.diality.us/cru/RO-LDT-566-1 Title: RO-LDT-566_Water Treatment And Degassing FP Statement of Objectives: State: Closed Summary: Author: Michael Garthwaite Moderator: Michael Garthwaite Reviewers: (4 active, 2 completed*) Sean Nash (*) Tiffany Mejia (*) Vinayakam Mani Dara Navaei Behrouz NematiPour Daniel Ho