This is a list of all comments for RO-LEAH-1972-1.

Review Summary: No summary


----------------------------------------
File: firmware/App/Drivers/PressureSensor.c
Revision Comment by Vinayakam Mani on 22 January 2025, 09:48 
https://devapps.diality.us/cru/RO-LEAH-1972-1#c21055

  This need to be cleaned up for RO.

  Reply by Sean Nash on 22 January 2025, 10:58
  > Done.

----------------------------------------
File: firmware/App/Monitors/Pressure.c
Revision Comment by Vinayakam Mani on 22 January 2025, 10:01 
https://devapps.diality.us/cru/RO-LEAH-1972-1#c21060

  Needs to be cleaned up for RO.

  Reply by Sean Nash on 22 January 2025, 10:43
  > Done.

Revision Comment by Vinayakam Mani on 22 January 2025, 10:04 
https://devapps.diality.us/cru/RO-LEAH-1972-1#c21062

  Please update the component ID first, followed by sensor name
  (for both temperature and pressure).

  Reply by Sean Nash on 22 January 2025, 10:37
  > Done.

Revision Comment by Vinayakam Mani on 22 January 2025, 10:07 
https://devapps.diality.us/cru/RO-LEAH-1972-1#c21063

  Do we need to move this to temperature.c (like you moved it for
  flow sensor).  We have temperature for Pressure and
  conductivity sensors. do we all need to move to one location?

  Reply by Sean Nash on 22 January 2025, 10:31
  > Pressure sensor temps to stay with pressure as these temps do
  > not have their own component designator on the flow path.

----------------------------------------
File: firmware/App/Drivers/TemperatureSensors.c
Revision Comment by Vinayakam Mani on 22 January 2025, 09:54 
https://devapps.diality.us/cru/RO-LEAH-1972-1#c21056

  Index needs to be updated per latest changes.

  Reply by Sean Nash on 22 January 2025, 10:56
  > Fixed.

----------------------------------------
File: firmware/App/Monitors/Flow.c
Revision Comment by Vinayakam Mani on 22 January 2025, 09:57 
https://devapps.diality.us/cru/RO-LEAH-1972-1#c21058

  Just to be consistent, can we change it to p7Flow (instead of
  FlowP7)? same for P16flow.

  Reply by Sean Nash on 22 January 2025, 10:53
  > Done.

----------------------------------------
File: firmware/App/Monitors/Temperature.c
Revision Comment by Vinayakam Mani on 22 January 2025, 10:10 
https://devapps.diality.us/cru/RO-LEAH-1972-1#c21064

  Please update the naming order.

  Reply by Sean Nash on 22 January 2025, 10:30
  > Done.

----------------------------------------
File: firmware/App/Controllers/Heaters.c
Revision Comment by Vinayakam Mani on 16 January 2025, 13:22 
https://devapps.diality.us/cru/RO-LEAH-1972-1#c21047

  Disinfect or Descaling?

  Reply by Sean Nash on 16 January 2025, 14:34
  > Not clear to me yet.  I suspect descaling will be part of a
  > heat disinfect.  Not sure if there will be other disinfection
  > modes.

----------------------------------------
File: firmware/App/Controllers/Heaters.h
Revision Comment by Vinayakam Mani on 16 January 2025, 13:19 
https://devapps.diality.us/cru/RO-LEAH-1972-1#c21046

  please remove trimmer heater references.

  Reply by Sean Nash on 16 January 2025, 14:33
  > Fixed.

----------------------------------------
File: firmware/App/Controllers/ROPump.c
Revision Comment by Vinayakam Mani on 22 January 2025, 09:34 
https://devapps.diality.us/cru/RO-LEAH-1972-1#c21052

  Please update 'ropump' as 'P12Pump' and 'bstPump' as 'P40Pump'.

  Reply by Sean Nash on 22 January 2025, 10:03
  > Fixed.

----------------------------------------
File: firmware/App/Drivers/ConductivitySensors.c
Revision Comment by Vinayakam Mani on 22 January 2025, 09:39 
https://devapps.diality.us/cru/RO-LEAH-1972-1#c21053

  CPI, CPO to be referred as P9 and P18?  when the code is
  uncommented, there is a possibility of leaving CPI/CPO as it
  is.

  Reply by Sean Nash on 22 January 2025, 11:01
  > Fixed.

Revision Comment by Vinayakam Mani on 22 January 2025, 09:42 
https://devapps.diality.us/cru/RO-LEAH-1972-1#c21054

  I guess this need to be cleaned up for RO.

  Reply by Sean Nash on 22 January 2025, 11:00
  > Done.

----------------------------------------
File: firmware/App/Monitors/Level.h
Revision Comment by Vinayakam Mani on 22 January 2025, 09:59 
https://devapps.diality.us/cru/RO-LEAH-1972-1#c21059

  RO floater

  Reply by Sean Nash on 22 January 2025, 10:44
  > Fixed.


---

ID: RO-LEAH-1972-1 https://devapps.diality.us/cru/RO-LEAH-1972-1

Title: RO-LEAH-1972_RO Integration Changes
Statement of Objectives:


State: Closed

Summary: 

Author: Sean Nash
Moderator: Sean Nash
Reviewers: (3 active, 2 completed*)
     Vinayakam Mani   (*)
     Michael Garthwaite   (*)
     Tiffany Mejia
     Dara Navaei
     Behrouz NematiPour