This is a list of all comments for RO-LEAH-250-1. Review Summary: No summary ---------------------------------------- File: firmware/App/Controllers/Valves.c Revision Comment by Vinayakam Mani on 19 November 2024, 15:23 https://devapps.diality.us/cru/RO-LEAH-250-1#c20953 RO valves Reply by Sean Nash on 19 November 2024, 16:40 > Fixed. Reply by Vinayakam Mani on 20 November 2024, 10:39 > RESOLVED IN CODE WALKTHROUGH ---------------------------------------- File: firmware/App/Monitors/Level.c Revision Comment by Vinayakam Mani on 19 November 2024, 15:47 https://devapps.diality.us/cru/RO-LEAH-250-1#c20957 priorRawLevel ( small p) Reply by Sean Nash on 19 November 2024, 17:01 > Fixed. ---------------------------------------- File: firmware/App/Services/FpgaRO.c Revision Comment by Vinayakam Mani on 19 November 2024, 14:27 https://devapps.diality.us/cru/RO-LEAH-250-1#c20945 Replace to RO_FPGA_COMPATIBILITY_REV. check the below commented alarm as well. Reply by Sean Nash on 19 November 2024, 17:12 > Fixed. Revision Comment by Vinayakam Mani on 19 November 2024, 14:32 https://devapps.diality.us/cru/RO-LEAH-250-1#c20946 Comment says the PWM duty cycle ( 0..500). But here we check MAX_RO_PUMP_PWM as 100. Please update as needed. Reply by Sean Nash on 19 November 2024, 17:15 > Removed check. Caller checks prior to calling this function. Revision Comment by Vinayakam Mani on 19 November 2024, 14:35 https://devapps.diality.us/cru/RO-LEAH-250-1#c20947 Can we add the headers for all these below functions. Reply by Sean Nash on 19 November 2024, 17:15 > Added. ---------------------------------------- File: firmware/App/Drivers/PressureSensor.c Revision Comment by Vinayakam Mani on 19 November 2024, 15:35 https://devapps.diality.us/cru/RO-LEAH-250-1#c20954 Can be deleted for now, or update RO alarms and comment it for later use. the commented code appears to be DD alarms. Reply by Sean Nash on 19 November 2024, 16:54 > Fixed. ---------------------------------------- File: firmware/App/Drivers/TemperatureSensors.c Revision Comment by Vinayakam Mani on 19 November 2024, 15:37 https://devapps.diality.us/cru/RO-LEAH-250-1#c20955 RO cal records ( just change DD ->RO name for now, can be defined later) Reply by Sean Nash on 19 November 2024, 16:55 > Fixed. ---------------------------------------- File: firmware/App/Drivers/TemperatureSensors.h Revision Comment by Vinayakam Mani on 19 November 2024, 15:41 https://devapps.diality.us/cru/RO-LEAH-250-1#c20956 I guess, these needs to be defined for RO. Reply by Sean Nash on 19 November 2024, 16:56 > I haven't done this unit yet - just brought it over from DD. > I'll comment out for now. ---------------------------------------- File: firmware/App/Controllers/ROPump.c Revision Comment by Vinayakam Mani on 19 November 2024, 15:03 https://devapps.diality.us/cru/RO-LEAH-250-1#c20952 None? Reply by Sean Nash on 19 November 2024, 16:39 > Fixed. ---------------------------------------- File: firmware/App/Drivers/BoostPump.c Revision Comment by Vinayakam Mani on 19 November 2024, 14:40 https://devapps.diality.us/cru/RO-LEAH-250-1#c20948 can we elaborate the function name as readBoostPumpSpeed or MeasuredSpeed ? Reply by Sean Nash on 19 November 2024, 16:41 > It is more general than that. We will be reading all > feedback registers that FPGA provides. In this case, a > read-back of the PWM and the measured speed for both the RO > and the optional booster pump. Revision Comment by Vinayakam Mani on 19 November 2024, 14:49 https://devapps.diality.us/cru/RO-LEAH-250-1#c20949 Update outputs and params Reply by Sean Nash on 19 November 2024, 16:50 > Fixed. Reply by Vinayakam Mani on 20 November 2024, 10:41 > Looks param still mentioning valves. Reply by Sean Nash on 20 November 2024, 13:29 > Fixed. ---------------------------------------- File: firmware/App/Drivers/BoostPump.h Revision Comment by Vinayakam Mani on 19 November 2024, 14:57 https://devapps.diality.us/cru/RO-LEAH-250-1#c20951 This duty cycle is for actual RO pump. correct (MAX_RO_PUMP_PWM_DUTY_CYCLE)? if the Boost pump has same or different duty cycle, that can be called with another macro - MAX_BOOST_PUMP_PWM_DUTY_CYCLE. Reply by Sean Nash on 19 November 2024, 16:51 > True. For now I am assuming both pumps will have the same > max and so I have a common #define. Revision Comment by Vinayakam Mani on 19 November 2024, 14:53 https://devapps.diality.us/cru/RO-LEAH-250-1#c20950 Do we want to say NUM_OF_RO_PUMPS instead of Boost pumps (since there is only one optional boost pump)? Reply by Sean Nash on 19 November 2024, 16:52 > I am calling both pumps a "boost" pump as a type of pump that > both are. And then we have the RO pump is one boost pump and > the optional booster pump is another boost pump. A little > confusing I realize. ---------------------------------------- File: firmware/App/Modes/ModeInitPOST.c Revision Comment by Vinayakam Mani on 20 November 2024, 10:48 https://devapps.diality.us/cru/RO-LEAH-250-1#c20974 In RODefs.h -> please change RO_POST_STATES enum members to RO_POST_STATE_START.. etc., ( instead of POST_STATE_START). seeing conflict with TDDefs.h post states. Reply by Sean Nash on 20 November 2024, 13:32 > Fixed. --- ID: RO-LEAH-250-1 https://devapps.diality.us/cru/RO-LEAH-250-1 Title: RO-LEAH-250_FW RO System Messages Statement of Objectives: State: Closed Summary: Author: Sean Nash Moderator: Sean Nash Reviewers: (3 active, 2 completed*) Vinayakam Mani (*) Michael Garthwaite (*) Tiffany Mejia Dara Navaei Behrouz NematiPour