This is a list of all comments for RO-LEAH-262-1.

Review Summary: No summary


----------------------------------------
File: firmware/App/Drivers/FlowSensor.c
Revision Comment by Vinayakam Mani on 25 November 2024, 14:09 
https://devapps.diality.us/cru/RO-LEAH-262-1#c21007

  pressure -> flowrate

  Reply by Sean Nash on 25 November 2024, 14:27
  > Fixed.

    Reply by Vinayakam Mani on 25 November 2024, 14:41
    > please update flow rate unit and change pressure sensor to
    > flow sensor.

      Reply by Sean Nash on 25 November 2024, 14:52
      > Done.

----------------------------------------
File: firmware/App/Monitors/Flow.c
Revision Comment by Vinayakam Mani on 25 November 2024, 14:22 
https://devapps.diality.us/cru/RO-LEAH-262-1#c21008

  Please align the comments.

  Reply by Sean Nash on 25 November 2024, 14:28
  > Done.

Revision Comment by Vinayakam Mani on 25 November 2024, 14:25 
https://devapps.diality.us/cru/RO-LEAH-262-1#c21009

  pressure -> flow

  Reply by Sean Nash on 25 November 2024, 14:29
  > Done.

Revision Comment by Vinayakam Mani on 25 November 2024, 14:28 
https://devapps.diality.us/cru/RO-LEAH-262-1#c21013

  pressure -> flow

  Reply by Sean Nash on 25 November 2024, 14:30
  > Done.

    Reply by Vinayakam Mani on 25 November 2024, 14:45
    > function body still mentioning pressure.

      Reply by Sean Nash on 25 November 2024, 14:54
      > Fixed.

Revision Comment by Vinayakam Mani on 25 November 2024, 14:31 
https://devapps.diality.us/cru/RO-LEAH-262-1#c21017

  Remove spaces before  =0;

  Reply by Sean Nash on 25 November 2024, 14:32
  > Done.

----------------------------------------
File: firmware/App/Drivers/ConductivitySensors.c
Revision Comment by Vinayakam Mani on 25 November 2024, 13:36 
https://devapps.diality.us/cru/RO-LEAH-262-1#c21003

  Typo in conductivity.

  Reply by Sean Nash on 25 November 2024, 13:43
  > Fixed.

Revision Comment by Vinayakam Mani on 25 November 2024, 14:03 
https://devapps.diality.us/cru/RO-LEAH-262-1#c21005

  Do you want to update these alarms later? The commented code
  still referencing DD alarms.

  Reply by Sean Nash on 25 November 2024, 14:26
  > Fixed.

----------------------------------------
File: firmware/App/Drivers/ConductivitySensors.h
Revision Comment by Vinayakam Mani on 25 November 2024, 14:04 
https://devapps.diality.us/cru/RO-LEAH-262-1#c21006

  Please update as required for RO.

  Reply by Sean Nash on 25 November 2024, 14:27
  > Done.


---

ID: RO-LEAH-262-1 https://devapps.diality.us/cru/RO-LEAH-262-1

Title: RO-LEAH-262_FW RO Flow Monitor
Statement of Objectives:


State: Closed

Summary: 

Author: Sean Nash
Moderator: Sean Nash
Reviewers: (5 active, 0 completed*)
     Tiffany Mejia
     Vinayakam Mani
     Michael Garthwaite
     Dara Navaei
     Behrouz NematiPour