This is a list of all comments for TD-LDT-736-1.

Review Summary: No summary


----------------------------------------
File: firmware/App/Services/AlarmMgmtTD.c
Revision Comment by Sean Nash on 17 July 2025, 13:27 
https://devapps.diality.us/cru/TD-LDT-736-1#c22976

  Restore bulk of this function for now.

----------------------------------------
File: firmware/App/Controllers/AirTrap.c
Revision Comment by Vinayakam Mani on 28 July 2025, 15:04 
https://devapps.diality.us/cru/TD-LDT-736-1#c23216

  space needed in sizeof( BOOL ). Follow the same for line no :
  526.

  Reply by Sean Nash on 29 July 2025, 14:12
  > Fixed.

----------------------------------------
File: firmware/App/Controllers/AirPump.c
Revision Comment by Vinayakam Mani on 28 July 2025, 14:33 
https://devapps.diality.us/cru/TD-LDT-736-1#c23211

  Is it just on/off control or variable speed control?

  Reply by Sean Nash on 29 July 2025, 14:11
  > You're right.  Old comment from Denali.  Fixed.

----------------------------------------
File: firmware/App/Controllers/BloodFlow.c
Revision Comment by Vinayakam Mani on 28 July 2025, 14:38 
https://devapps.diality.us/cru/TD-LDT-736-1#c23212

  just 0.0F would work?

  Reply by Sean Nash on 29 July 2025, 14:13
  > When Systems gives me Leahi terms, they will be very small
  > fractions.

Revision Comment by Sean Nash on 28 July 2025, 09:02 
https://devapps.diality.us/cru/TD-LDT-736-1#c23179

  Why?

Revision Comment by Sean Nash on 17 July 2025, 12:46 
https://devapps.diality.us/cru/TD-LDT-736-1#c22973

  I am.  Didn't want to wait (up to 50ms) for pump to stop if
  hard stop is requested.  So forcing to off immediately.  Not
  how I would ordinarily want to handle this, but in this case I
  am.

Revision Comment by Vinayakam Mani on 28 July 2025, 14:54 
https://devapps.diality.us/cru/TD-LDT-736-1#c23214

  Add alarm.

  Reply by Sean Nash on 29 July 2025, 14:14
  > Fixed.

Revision Comment by Sean Nash on 17 July 2025, 12:44 
https://devapps.diality.us/cru/TD-LDT-736-1#c22972

  Why is this necessary?  I would think state machine would
  already handle this.

----------------------------------------
File: firmware/App/Controllers/Ejector.c
Revision Comment by Vinayakam Mani on 28 July 2025, 14:52 
https://devapps.diality.us/cru/TD-LDT-736-1#c23213

  Please add param.

  Reply by Sean Nash on 29 July 2025, 14:16
  > Fixed.

----------------------------------------
File: firmware/App/Drivers/EjectorMotor.c
Revision Comment by Vinayakam Mani on 28 July 2025, 15:00 
https://devapps.diality.us/cru/TD-LDT-736-1#c23215

  Please update I/O.

  Reply by Sean Nash on 29 July 2025, 14:17
  > Fixed.

----------------------------------------
File: AlarmDefs.h
Revision Comment by Vinayakam Mani on 28 July 2025, 14:25 
https://devapps.diality.us/cru/TD-LDT-736-1#c23209

  Alarm descriptions and trigger conditions calls out "more than
  4 minutes" and Instructions says, "nearly 5 minutes". is this
  intended to display this way?

  Reply by Sean Nash on 28 July 2025, 16:57
  > Came from Denali, so I believe this is what they wanted.  The
  > nearly 5 minutes is the one the user sees.


---

ID: TD-LDT-736-1 https://devapps.diality.us/cru/TD-LDT-736-1

Title: TD-LDT-736_General Alarm Requirements TD
Statement of Objectives:


State: Closed

Summary: 

Author: Sean Nash
Moderator: Sean Nash
Reviewers: (3 active, 2 completed*)
     Vinayakam Mani   (*)
     Dara Navaei   (*)
     jpaguio
     Michael Garthwaite
     Daniel Ho