This is a list of all comments for TD-LEAH-1970-1.

Review Summary: No summary


----------------------------------------
File: PressureCommon.c
Revision Comment by Vinayakam Mani on 16 January 2025, 09:56 
https://devapps.diality.us/cru/TD-LEAH-1970-1#c21045

  We may need to keep generic name of variable as 'pressure'
  instead of 'pressure_bar' (since it's no more converting into
  bar unit).

  Reply by Sean Nash on 16 January 2025, 14:32
  > Good point.  Fixed.

----------------------------------------
File: Compatible.h
Revision Comment by Vinayakam Mani on 16 January 2025, 09:50 
https://devapps.diality.us/cru/TD-LEAH-1970-1#c21044

  Do you want to update the TD and RO FPGA compatiable rev as
  zero?  looks currently FPGA returning them as zero and will
  fail in init mode - FPGA self test.

  Reply by Sean Nash on 16 January 2025, 14:33
  > Fixed.

----------------------------------------
File: firmware/App/Monitors/Bubbles.h
Revision Comment by Vinayakam Mani on 22 January 2025, 10:31 
https://devapps.diality.us/cru/TD-LEAH-1970-1#c21066

  h18Status - naming order to be changed. same for H18state as
  well.

  Reply by Sean Nash on 22 January 2025, 11:07
  > Fixed.


---

ID: TD-LEAH-1970-1 https://devapps.diality.us/cru/TD-LEAH-1970-1

Title: TD-LEAH-1970_TD Integration Changes
Statement of Objectives:


State: Closed

Summary: 

Author: Sean Nash
Moderator: Sean Nash
Reviewers: (2 active, 2 completed*)
     Vinayakam Mani   (*)
     Michael Garthwaite   (*)
     jpaguio
     Dara Navaei