This is a list of all comments for TD-LEAH-41-1.

Review Summary: No summary


----------------------------------------
File: firmware/App/Monitors/Bubbles.c
Revision Comment by Vinayakam Mani on 16 September 2024, 15:16 
https://devapps.diality.us/cru/TD-LEAH-41-1#c20220

  unit instead of module.

  Reply by Sean Nash on 16 September 2024, 16:03
  > Fixed.

Revision Comment by Vinayakam Mani on 16 September 2024, 14:23 
https://devapps.diality.us/cru/TD-LEAH-41-1#c20216

  Need to add Alarm details.

  Reply by Sean Nash on 16 September 2024, 16:15
  > Fixed.

Revision Comment by Vinayakam Mani on 16 September 2024, 14:29 
https://devapps.diality.us/cru/TD-LEAH-41-1#c20217

  Do we need to uncomment this line and change alarm name as TD?

  Reply by Sean Nash on 16 September 2024, 16:14
  > Added new alarm and uncommented.

Revision Comment by Vinayakam Mani on 16 September 2024, 15:13 
https://devapps.diality.us/cru/TD-LEAH-41-1#c20219

  looks exec bubble called in priority task. need to update
  priority task interval.

  Reply by Sean Nash on 16 September 2024, 16:05
  > Fixed.

----------------------------------------
File: firmware/App/Services/AlarmMgmtSWFaults.h
Revision Comment by Vinayakam Mani on 16 September 2024, 15:47 
https://devapps.diality.us/cru/TD-LEAH-41-1#c20222

  85

  Reply by Sean Nash on 16 September 2024, 16:00
  > Fixed.

----------------------------------------
File: firmware/App/Monitors/Voltages.c
Revision Comment by Vinayakam Mani on 16 September 2024, 15:44 
https://devapps.diality.us/cru/TD-LEAH-41-1#c20221

  HD/DG update to TD/DD.

  Reply by Sean Nash on 16 September 2024, 16:02
  > Fixed.

----------------------------------------
File: firmware/App/Drivers/PressureSensor.c
Revision Comment by Vinayakam Mani on 16 September 2024, 16:27 
https://devapps.diality.us/cru/TD-LEAH-41-1#c20231

  I have changed this common routine to take 16 bit as an input,
  per latest changes on DD- HDD pressure sensors. please update
  as required.

  Reply by Sean Nash on 16 September 2024, 17:18
  > Noe has not updated TD HDD so I can't update my side yet.

Revision Comment by Vinayakam Mani on 16 September 2024, 16:24 
https://devapps.diality.us/cru/TD-LEAH-41-1#c20230

  U08 to U32.

  Reply by Sean Nash on 16 September 2024, 17:27
  > Fixed.

Revision Comment by Vinayakam Mani on 16 September 2024, 16:23 
https://devapps.diality.us/cru/TD-LEAH-41-1#c20229

  U08 to U32.

  Reply by Sean Nash on 16 September 2024, 17:27
  > Fixed.


---

ID: TD-LEAH-41-1 https://devapps.diality.us/cru/TD-LEAH-41-1

Title: TD-LEAH-41_FW TD Internal Adc Driver
Statement of Objectives:


State: Closed

Summary: 

Author: Sean Nash
Moderator: Sean Nash
Reviewers: (2 active, 2 completed*)
     Vinayakam Mani   (*)
     Dara Navaei   (*)
     jpaguio
     Michael Garthwaite