This is a list of all comments for TD-LEAH-47-1.

Review Summary: No summary


----------------------------------------
File: firmware/App/Monitors/Pressures.c
Revision Comment by Vinayakam Mani on 25 September 2024, 16:25 
https://devapps.diality.us/cru/TD-LEAH-47-1#c20285

  extra blank line

  Reply by Sean Nash on 26 September 2024, 09:44
  > Removed.

----------------------------------------
File: firmware/App/Controllers/AirPump.c
Revision Comment by Vinayakam Mani on 25 September 2024, 15:11 
https://devapps.diality.us/cru/TD-LEAH-47-1#c20282

  initilalizes the Airpump driver? Also, the outputs to mention
  unit variables initialized instead detailed list.

  Reply by Sean Nash on 26 September 2024, 09:38
  > Fixed.

----------------------------------------
File: firmware/App/Drivers/BubbleDetector.c
Revision Comment by Vinayakam Mani on 25 September 2024, 15:41 
https://devapps.diality.us/cru/TD-LEAH-47-1#c20283

  can we modify the routine to take index, max variables as it is
  ( without subtracting -1) and adjust the conditions inside the
  routine ( by removing = in the <= )?

  Reply by Sean Nash on 26 September 2024, 09:39
  > I thought about that but decided to keep the common functions
  > simple by calling the param a maximum.

----------------------------------------
File: firmware/App/Drivers/GLXferPump.c
Revision Comment by Vinayakam Mani on 25 September 2024, 15:47 
https://devapps.diality.us/cru/TD-LEAH-47-1#c20284

  Needs to be updated per latest testsupport routine?

  Reply by Sean Nash on 26 September 2024, 09:41
  > This one is different.  Not using standard override payload
  > as it is not an override - it's a set command.

----------------------------------------
File: firmware/App/Monitors/Buttons.c
Revision Comment by Vinayakam Mani on 25 September 2024, 16:43 
https://devapps.diality.us/cru/TD-LEAH-47-1#c20286

  are we not publishing the buttons state?

  Reply by Sean Nash on 26 September 2024, 09:43
  > No.  Button press/release events will be sent as asynchronous
  > events.

----------------------------------------
File: TestSupport.c
Revision Comment by Vinayakam Mani on 25 September 2024, 15:06 
https://devapps.diality.us/cru/TD-LEAH-47-1#c20281

  I guess this code is common for all stacks. can we remove TD
  reference across the functions?

  Reply by Sean Nash on 26 September 2024, 09:36
  > Fixed.


---

ID: TD-LEAH-47-1 https://devapps.diality.us/cru/TD-LEAH-47-1

Title: TD-LEAH-47_FW TD Buttons Monitor
Statement of Objectives:


State: Closed

Summary: 

Author: Sean Nash
Moderator: Sean Nash
Reviewers: (2 active, 2 completed*)
     Vinayakam Mani   (*)
     Michael Garthwaite   (*)
     jpaguio
     Dara Navaei