This is a list of all comments for TD-LEAH-51-1.

Review Summary: No summary


----------------------------------------
File: firmware/App/Controllers/BloodFlow.c
Revision Comment by Vinayakam Mani on 01 November 2024, 15:59 
https://devapps.diality.us/cru/TD-LEAH-51-1#c20735

  There is another macro " MAX_SETTABLE_BLOOD_FLOW_RATE" defining
  700.. are they similar or different one?  may need to change
  macro name or add comment for clarification.

  Reply by Sean Nash on 04 November 2024, 11:53
  > Per comment, 1320 is maximum "measured" flow rate.  700 is
  > maximum "settable" flow rate.  500 is maximum prescribed flow
  > rate.

Revision Comment by Vinayakam Mani on 01 November 2024, 16:23 
https://devapps.diality.us/cru/TD-LEAH-51-1#c20736

  Please add \b style formatting for inputs, outputs and alarms
  (entire file). Also add alarm details where needed.

----------------------------------------
File: firmware/App/Controllers/BloodFlow.h
Revision Comment by Vinayakam Mani on 01 November 2024, 16:27 
https://devapps.diality.us/cru/TD-LEAH-51-1#c20737

  Please comment comparing the previous macros in .c file.

----------------------------------------
File: firmware/App/Controllers/Valves.c
Revision Comment by Vinayakam Mani on 25 October 2024, 16:25 
https://devapps.diality.us/cru/TD-LEAH-51-1#c20614

  Valve ( V caps)?

  Reply by Sean Nash on 28 October 2024, 09:37
  > Fixed.

Revision Comment by Vinayakam Mani on 25 October 2024, 16:50 
https://devapps.diality.us/cru/TD-LEAH-51-1#c20615

  Please align the comments to fit in same column, comparing the
  top comments.

  Reply by Sean Nash on 28 October 2024, 09:37
  > Fixed.

Revision Comment by Vinayakam Mani on 25 October 2024, 17:01 
https://devapps.diality.us/cru/TD-LEAH-51-1#c20616

  Valves broadcast

  Reply by Sean Nash on 28 October 2024, 09:37
  > Fixed.

----------------------------------------
File: firmware/App/Drivers/LevelSensors.c
Revision Comment by Vinayakam Mani on 28 October 2024, 09:26 
https://devapps.diality.us/cru/TD-LEAH-51-1#c20621

  Do we need this timeout to be changed as task interval counter
  as we were seeing additional 100ms debounce time at times
  (hence adjusted the requirement)?

  Reply by Sean Nash on 28 October 2024, 10:07
  > Yes.  Changed to task interval based debounce timing.

----------------------------------------
File: firmware/App/Drivers/PeristalticPump.c
Revision Comment by Vinayakam Mani on 28 October 2024, 09:42 
https://devapps.diality.us/cru/TD-LEAH-51-1#c20627

  unit variables initialized.

  Reply by Sean Nash on 28 October 2024, 10:10
  > Fixed.

Revision Comment by Vinayakam Mani on 28 October 2024, 09:45 
https://devapps.diality.us/cru/TD-LEAH-51-1#c20628

  looks the same function name used in FpgaTD and BloodFlow.C
  files. Do we want to differentiate between these two-function
  naming?

  Reply by Sean Nash on 28 October 2024, 10:15
  > Fixed.

Revision Comment by Vinayakam Mani on 28 October 2024, 09:52 
https://devapps.diality.us/cru/TD-LEAH-51-1#c20629

  Message payload length check to be considered.

  Reply by Sean Nash on 28 October 2024, 10:24
  > Fixed.

----------------------------------------
File: firmware/App/Drivers/RotaryValve.c
Revision Comment by Vinayakam Mani on 28 October 2024, 10:10 
https://devapps.diality.us/cru/TD-LEAH-51-1#c20631

  Please align the comments into same column.

  Reply by Sean Nash on 29 October 2024, 09:07
  > Fixed.

Revision Comment by Vinayakam Mani on 28 October 2024, 10:20 
https://devapps.diality.us/cru/TD-LEAH-51-1#c20634

  payload length check to be considered.

  Reply by Sean Nash on 28 October 2024, 10:24
  > Fixed.

----------------------------------------
File: firmware/App/Drivers/Valve2Way.c
Revision Comment by Vinayakam Mani on 28 October 2024, 10:23 
https://devapps.diality.us/cru/TD-LEAH-51-1#c20635

  unit variables initialized.

  Reply by Sean Nash on 29 October 2024, 09:05
  > Fixed.

----------------------------------------
File: firmware/App/Drivers/Valve2Way.h
Revision Comment by Vinayakam Mani on 28 October 2024, 10:26 
https://devapps.diality.us/cru/TD-LEAH-51-1#c20638

  Remove 'a'.

  Reply by Sean Nash on 28 October 2024, 10:27
  > Fixed.

----------------------------------------
File: firmware/App/Services/AlarmMgmtTD.c
Revision Comment by Vinayakam Mani on 28 October 2024, 10:31 
https://devapps.diality.us/cru/TD-LEAH-51-1#c20640

  payload length check.

  Reply by Sean Nash on 29 October 2024, 09:04
  > Fixed.


---

ID: TD-LEAH-51-1 https://devapps.diality.us/cru/TD-LEAH-51-1

Title: TD-LEAH-51_FW TD Blood Pump Controller Moni
Statement of Objectives:


State: Closed

Summary: 

Author: Sean Nash
Moderator: Sean Nash
Reviewers: (2 active, 2 completed*)
     Vinayakam Mani   (*)
     Michael Garthwaite   (*)
     jpaguio
     Dara Navaei