This is a list of all comments for TD-LEAH-838-1.

Review Summary: No summary


----------------------------------------
File: firmware/App/Controllers/AirPump.c
Revision Comment by Vinayakam Mani on 20 February 2025, 14:07 
https://devapps.diality.us/cru/TD-LEAH-838-1#c21506

  Please add in outputs: currentAirPumpMotorPowerLevel

  Reply by Sean Nash on 21 February 2025, 14:00
  > Done.

----------------------------------------
File: firmware/App/Controllers/AirTrap.c
Revision Comment by Vinayakam Mani on 20 February 2025, 15:00 
https://devapps.diality.us/cru/TD-LEAH-838-1#c21511

  I remember there was a change done in Denali to extend the
  timeout value. Do we need to adjust the timeout value for
  LEAHI?

  Reply by Sean Nash on 21 February 2025, 14:09
  > Change has not happened yet in Denali.  I will follow up with
  > Dara after change is made.

Revision Comment by Vinayakam Mani on 20 February 2025, 14:47 
https://devapps.diality.us/cru/TD-LEAH-838-1#c21507

  Do we want to remove the initialization (FALSE), as it is
  getting initialized as part of the init process.

  Reply by Sean Nash on 21 February 2025, 14:10
  > Yes.  Done.

Revision Comment by Vinayakam Mani on 20 February 2025, 14:51 
https://devapps.diality.us/cru/TD-LEAH-838-1#c21508

  Remove events message.

  Reply by Sean Nash on 21 February 2025, 14:11
  > Done.

Revision Comment by Vinayakam Mani on 20 February 2025, 14:55 
https://devapps.diality.us/cru/TD-LEAH-838-1#c21509

  Do we need to rename LevelSensors to AirTrapLevelSensors to get
  right context?

  Reply by Sean Nash on 21 February 2025, 14:13
  > Done.

Revision Comment by Vinayakam Mani on 20 February 2025, 14:58 
https://devapps.diality.us/cru/TD-LEAH-838-1#c21510

  Remove additional space

  Reply by Sean Nash on 21 February 2025, 14:14
  > Done.

Revision Comment by Vinayakam Mani on 20 February 2025, 15:20 
https://devapps.diality.us/cru/TD-LEAH-838-1#c21513

  #define the 1 and 0.

  Reply by Sean Nash on 21 February 2025, 14:23
  > Done.

Revision Comment by Vinayakam Mani on 20 February 2025, 15:15 
https://devapps.diality.us/cru/TD-LEAH-838-1#c21512

  I guess air trap monitor function handles the timeout function
  and no need of handling time out here (TODO).

  Reply by Sean Nash on 21 February 2025, 14:25
  > Removed TODO.

Revision Comment by Vinayakam Mani on 20 February 2025, 15:31 
https://devapps.diality.us/cru/TD-LEAH-838-1#c21515

  please add description/details along with the Message ID

  Reply by Sean Nash on 21 February 2025, 14:30
  > Done.

Revision Comment by Vinayakam Mani on 20 February 2025, 15:30 
https://devapps.diality.us/cru/TD-LEAH-838-1#c21514

  Do we need explicit typecast to U32?

  Reply by Sean Nash on 21 February 2025, 14:27
  > I would say we are required to explicitly typecast if any of
  > the following are true:
  > 1) compiler warning if you don't
  > 2) byte count/mem size matters (e.g. message payload) and
  > might not match desired size if you don't cast it
  > 
  > I don't think either is true in this case.

----------------------------------------
File: firmware/App/Controllers/AirTrap.h
Revision Comment by Vinayakam Mani on 20 February 2025, 15:33 
https://devapps.diality.us/cru/TD-LEAH-838-1#c21516

  isAutoControlling?

  Reply by Sean Nash on 21 February 2025, 14:32
  > Done.

----------------------------------------
File: firmware/App/Drivers/GLXferPump.c
Revision Comment by Vinayakam Mani on 20 February 2025, 15:46 
https://devapps.diality.us/cru/TD-LEAH-838-1#c21518

  MotorState to MotorPowerLevel - across file.

  Reply by Sean Nash on 21 February 2025, 14:36
  > Done.

Revision Comment by Vinayakam Mani on 20 February 2025, 15:49 
https://devapps.diality.us/cru/TD-LEAH-838-1#c21519

  No Alarm, Add Event ID.

  Reply by Sean Nash on 21 February 2025, 14:38
  > Done.

Revision Comment by Vinayakam Mani on 20 February 2025, 15:51 
https://devapps.diality.us/cru/TD-LEAH-838-1#c21520

  May be add a check to validate the power level between 0 to
  255.

  Reply by Sean Nash on 21 February 2025, 14:42
  > Done.

----------------------------------------
File: firmware/App/Drivers/Valve3Way.c
Revision Comment by Vinayakam Mani on 20 February 2025, 15:57 
https://devapps.diality.us/cru/TD-LEAH-838-1#c21521

  3-way

  Reply by Sean Nash on 21 February 2025, 14:42
  > Fixed.

Revision Comment by Vinayakam Mani on 20 February 2025, 16:01 
https://devapps.diality.us/cru/TD-LEAH-838-1#c21522

  Do we want to change STATE_CLOSED to CMN_TO_NO_OPEN (or
  similar?), STATE_OPEN to CMN _TO_NC_OPEN?

  Reply by Sean Nash on 21 February 2025, 15:02
  > Done.

----------------------------------------
File: firmware/App/Controllers/BloodFlow.c
Revision Comment by Vinayakam Mani on 20 February 2025, 15:38 
https://devapps.diality.us/cru/TD-LEAH-838-1#c21517

  Please adjust the alignment(few #defines)

  Reply by Sean Nash on 21 February 2025, 14:34
  > Done.


---

ID: TD-LEAH-838-1 https://devapps.diality.us/cru/TD-LEAH-838-1

Title: TD-LEAH-838_FW TD Gas Liquid Transfer Pump
Statement of Objectives:


State: Closed

Summary: 

Author: Sean Nash
Moderator: Sean Nash
Reviewers: (2 active, 2 completed*)
     Vinayakam Mani   (*)
     Michael Garthwaite   (*)
     jpaguio
     Dara Navaei