UI-DEN-10424-1 UI-DEN-10424_FW Request A4 A5 Msg Log

closed on 12 Oct 21

Author

Moderator

Reviewers

UI-DEN-10424_FW Request A4 A5 Msg Log

Activity

Details
Objectives
General Comments 0
Unresolved
Resolved
Number of files included: 38

application 0
- Folder resources 0
  - Folder images 0
    - File Logo d-blue.png 0 Remove
  - Folder settings/messages 0
    - File unhandled.conf 0 Remove
- Folder sources 0
  - Folder canbus 0
    - File MessageDispatcher.cpp 0 Remove
    - File MessageDispatcher.h 0 Remove
    - File MessageGlobals.h 0 Remove
    - File MessageInterpreter.cpp 0 Remove
    - File MessageInterpreter.h 0 Remove
  - Folder gui 0
    - Folder qml 0
      - Folder dialogs 0
        
        File NotificationDialog.qml 0 Remove
      - Folder pages/endtreatment 0
        
        File EndTreatmentRecirculateStack.qml 0 Remove
      - File AlarmItem.qml 0 Remove
      - File main.qml 0 Remove
    - File GuiGlobals.cpp 0 Remove
    - File GuiGlobals.h 0 Remove
  - Folder model 0
    - Folder dg/data 0
      - File MDGGeneralEvent.cpp 0 Remove
      - File MDGGeneralEvent.h 0 Remove
    - Folder hd 0
      - Folder alarm 0
        
        File MAlarmMapping.cpp 0 Remove
        
        File MAlarmTriggered.cpp 3 Remove
        
        File MAlarmTriggered.h 0 Remove
      - Folder data 0
        
        Folder treatment 0
        
        File MTreatmentStopData.cpp 0 Remove
        
        File MTreatmentStopData.h 0 Remove
        
        File MHDDebugText.cpp 0 Remove
        
        File MHDDebugText.h 0 Remove
        
        File MHDGeneralEvent.cpp 0 Remove
        
        File MHDGeneralEvent.h 0 Remove
    - File MAbstractDynamic.cpp 0 Remove
    - File MAbstractDynamic.h 0 Remove
    - File MModel.h 0 Remove
  - Folder storage 0
    - File StorageGlobals.cpp 0 Remove
  - Folder view 0
    - Folder hd/data/treatment 0
      - File VTreatmentStopData.cpp 0 Remove
      - File VTreatmentStopData.h 0 Remove
    - File VView.h 0 Remove
  - File ApplicationController.cpp 0 Remove
  - File ApplicationController.h 0 Remove
- File AlarmMapping.csv 0 Remove
- File denali.pro 0 Remove
- File denali.pro.user 0 Remove
- File en_US.udic 0 Remove
- File ui_build_history.log 0 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
Behrouz NematiPour	Author & Moderator	16m	1	Since we have more than one message which is using the dy...
Sean Nash	Reviewer - Complete	9m
pmontazemi (deleted user)	Reviewer - Complete	13m	2	RESOLVED.
Total		39m	3

Linked issues
- DEN-10161
- DEN-9968

#permalink

Objectives

commit : 161d1431 - DEN-9968: GUI does not indicate the amount of time the device has been stopped in pre-treatment & treatment

Added message ID_TreatmentStop = 0x4900, // 73 and its Model, View
Added a timer on the Alarm Dialog which is visible in Treatment Stop and if the message above has a total value.
commit : b94c297f - Part 2/2: Added the two new General HD/DG messages

commit : 1f89cfbb - DEN-10161: Missing END TREATMENT option in Treatment-Recirculate-Stop screen

The screen (Reconnect) belongs to the TREATMENT_RECIRC_STOPPED_STATE state of the TREATMENT_RECIRC_STATE in the TREATMENT_STATE message, didn't even have a "END TREATMENT" button, which has been added.
The time_IsLeft logic has NOT been removed yet, since I don't recall why it has been used in the first place.
commit : 338575f7 - Part 2/2: make the Alarm Triggered messages modification

Created a class named MAbstractDynamic which is the base class of the dynamic model classes.
+ Dynamic Model classes are the ones with field descriptor (FD) and a data field (DF) after that which the data type in the data field is defined by field descriptor.
+ This combination for now is only for 2 set of FD, DF only.
Made the Alarm Triggered inherit from MAbstractDynamic.
commit : 67d05211 - Updated AlarmMapping

commit : cbb246d6 - Part 1/2: make the unhandled messages dynamic

The messages/unhandled.conf has been created in the settings area and will be loaded and used for the unhandled messages in the message interpreter.

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

There are no general comments on this review.

Click to load diff

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: [Crucible Review CR-1\|CR-1]
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

UI-DEN-10424-1

UI-DEN-10424_FW Request A4 A5 Msg Log

UI-DEN-10424-1 3

Details

Linked issues

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time

UI-DEN-10424_FW Request A4 A5 Msg Log

UI-DEN-10424-1 3

Summarize the review outcomes (optional)

Details

Linked issues

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time